From patchwork Thu Sep 24 07:17:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 313450 Delivered-To: patch@linaro.org Received: by 2002:a92:5ad1:0:0:0:0:0 with SMTP id b78csp1117404ilg; Thu, 24 Sep 2020 00:19:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqKOluNt+Q4SqpEiYeBbZzRyY1WvZ6g5YMhbTpLvRAh8jxdGPXVSwtNJREPEJ45BDbteXD X-Received: by 2002:a17:906:c447:: with SMTP id ck7mr3213405ejb.358.1600931985635; Thu, 24 Sep 2020 00:19:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600931985; cv=none; d=google.com; s=arc-20160816; b=m6VkNPaxnvuSrb7fYLXRzGGNI6jJxPVvpKQI56UF8FpCcUZGlOBjQh8toNkP4REJJB fjERPcd5BR21QUkVWuZqaTq5iA3nUVO41t10VCKU8QXIrq3hawhsPLirngkkyUVK/3v7 zeqbcy5HYCMGTaOca9WErJy24RCITZ1tn9ev2XoaxwfFRtMDHelIcKdz+CnYD80aZvAU Z4yBJKr18glv7nErrzLzuQNHvSXHWW22fAhcjCCYn6TLubLPsPcLyiYPnpJbLtK483cF x6z6I5ItTwXFVYn/DFAnaQ5W0fo065W1v0WOEREHiguWDa1Cn1Fyp6C18yeVoxYHjTMt lQ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jKCPgBoZifUDjMMCwZGOSJO4/f7Mmp752AqKn/FNlvc=; b=0yZmjc6+xPutiWiw0C3kcTDVewNEH28j2V1izyDUTqS+pYqDL6Wu7vj4SSUgrhW03l vN3pstKid4N8gqmwczHFtInm0CtHEnvS7buMDHBLWyuWwZtFSlJ7tKYVrxoAP8T+2y/S HpwYCticZ5Sehd4VtkevYO0wwrd5AZfnLk3KWX1kuk/LXc+cVKg7edQi13X+5JAvbl18 TTb1+mTFQSPw189yp5FmQl87XmKDNP0Na99IOsrqH9K+iW3Mr2NSRj1nbiYb8tlUciyk XWqGSciUzbMogA36jvf095RVR1ijeOjt+DchpER5Q5hGhA30b9hCaBLnHum+CwmsufHQ s4Ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j19si1394050ejx.272.2020.09.24.00.19.45; Thu, 24 Sep 2020 00:19:45 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727206AbgIXHTo (ORCPT + 6 others); Thu, 24 Sep 2020 03:19:44 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:53240 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727110AbgIXHTm (ORCPT ); Thu, 24 Sep 2020 03:19:42 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id C1842825956AD73B710B; Thu, 24 Sep 2020 15:19:37 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.253) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Thu, 24 Sep 2020 15:19:26 +0800 From: Zhen Lei To: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , "Alexey Brodkin" , Vineet Gupta , devicetree , linux-snps-arc , linux-kernel CC: Zhen Lei , Sebastian Hesselbarth , Haoyu Lv , Libin , Kefeng Wang Subject: [PATCH v6 2/6] irqchip: dw-apb-ictl: prepare for support hierarchy irq domain Date: Thu, 24 Sep 2020 15:17:50 +0800 Message-ID: <20200924071754.4509-3-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20200924071754.4509-1-thunder.leizhen@huawei.com> References: <20200924071754.4509-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.177.253] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Rename some functions and variables in advance, to make the next patch looks more clear. The details are as follows: 1. rename dw_apb_ictl_handler() to dw_apb_ictl_handle_irq_cascaded(). 2. change (1 << hwirq) to BIT(hwirq). In function dw_apb_ictl_init(): 1. rename local variable irq to parent_irq. 2. add "const struct irq_domain_ops *domain_ops = &irq_generic_chip_ops", then replace &irq_generic_chip_ops in other places with domain_ops. No functional change. Signed-off-by: Zhen Lei Tested-by: Haoyu Lv --- drivers/irqchip/irq-dw-apb-ictl.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) -- 1.8.3 diff --git a/drivers/irqchip/irq-dw-apb-ictl.c b/drivers/irqchip/irq-dw-apb-ictl.c index e4550e9c810ba94..5458004242e9d20 100644 --- a/drivers/irqchip/irq-dw-apb-ictl.c +++ b/drivers/irqchip/irq-dw-apb-ictl.c @@ -26,7 +26,7 @@ #define APB_INT_FINALSTATUS_H 0x34 #define APB_INT_BASE_OFFSET 0x04 -static void dw_apb_ictl_handler(struct irq_desc *desc) +static void dw_apb_ictl_handle_irq_cascaded(struct irq_desc *desc) { struct irq_domain *d = irq_desc_get_handler_data(desc); struct irq_chip *chip = irq_desc_get_chip(desc); @@ -43,7 +43,7 @@ static void dw_apb_ictl_handler(struct irq_desc *desc) u32 virq = irq_find_mapping(d, gc->irq_base + hwirq); generic_handle_irq(virq); - stat &= ~(1 << hwirq); + stat &= ~BIT(hwirq); } } @@ -73,12 +73,13 @@ static int __init dw_apb_ictl_init(struct device_node *np, struct irq_domain *domain; struct irq_chip_generic *gc; void __iomem *iobase; - int ret, nrirqs, irq, i; + int ret, nrirqs, parent_irq, i; u32 reg; + const struct irq_domain_ops *domain_ops = &irq_generic_chip_ops; /* Map the parent interrupt for the chained handler */ - irq = irq_of_parse_and_map(np, 0); - if (irq <= 0) { + parent_irq = irq_of_parse_and_map(np, 0); + if (parent_irq <= 0) { pr_err("%pOF: unable to parse irq\n", np); return -EINVAL; } @@ -120,8 +121,7 @@ static int __init dw_apb_ictl_init(struct device_node *np, else nrirqs = fls(readl_relaxed(iobase + APB_INT_ENABLE_L)); - domain = irq_domain_add_linear(np, nrirqs, - &irq_generic_chip_ops, NULL); + domain = irq_domain_add_linear(np, nrirqs, domain_ops, NULL); if (!domain) { pr_err("%pOF: unable to add irq domain\n", np); ret = -ENOMEM; @@ -146,7 +146,8 @@ static int __init dw_apb_ictl_init(struct device_node *np, gc->chip_types[0].chip.irq_resume = dw_apb_ictl_resume; } - irq_set_chained_handler_and_data(irq, dw_apb_ictl_handler, domain); + irq_set_chained_handler_and_data(parent_irq, + dw_apb_ictl_handle_irq_cascaded, domain); return 0;