From patchwork Tue Sep 8 07:11:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 249275 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp4304016ilg; Tue, 8 Sep 2020 00:12:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzq6unjcxqbTkKpcLBawFbQ60LKmZWHd0+eU4M5JACp1pECaGAu3PhJAgqULA6BMOUam2JC X-Received: by 2002:a17:906:6b95:: with SMTP id l21mr23786940ejr.317.1599549176170; Tue, 08 Sep 2020 00:12:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599549176; cv=none; d=google.com; s=arc-20160816; b=fslSLtp7oMC9GTRi7Vm1ryNXKfmpd6Q8aZunVbLRixdn+7s1rUAHK3sIMrB/XR+HTZ fAq4NldXnP8po8145ezxndQcWv8JqI2qzO+hF7jd3Y/Timg3jGGEuRLeKQJ6+qVHdNTj Y0ifa4maFIY+mMrPElaj3fTvfRoll9C7ATYvgZlLREQ7n2kmAW2l6hkJN3Ai0dIO+G6v D8tAj4rz6gKYWQ+xwhABOv5KqkeKx3w94zcpIOKkrOsr/1hgQO3w20vdZbRiX8Au+1vb iu9DBmnAPG5QuIBJWANF+wGHCOh31jVoe9AYSlCm+ZsOtFc7zT66oM/+hg67ywG8Uueq f9+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CFDC7RzHxiN0xIogkZtoggiPp+jBQhpBqjC/KuNUryk=; b=DeoLVmN4LXxKzJLTWd3Luj8/KRZe7o8IH5BqRSNJRAmqCmV7oAMeb/GKUHMzcU7lac htpmEysxaIFyHgB3Ez1RXGjiuVQbk4/JlXfGG2QmGr+mCnblL2RYen6fYvVnK6KooO6a H/oMNzxp+TJYU6suIprIaXNg5tP1Az9BNFEQoZvKz1C6JDQ94nNVcQLGic2Jbd1L/mds VysAQ22MnIkD7XiXMDiOuihE1AXvoIrm9FhSjpnd8J6wbJAZgClUQfbplWNYgu2DHV1W G1rszVPH0F1sTUu67EKarYse70twOet5CpoGWzcl2t5Ith3LcUN0oTEr6zXsGJvl/tH4 9DSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x15si11076770eje.180.2020.09.08.00.12.56; Tue, 08 Sep 2020 00:12:56 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729246AbgIHHMs (ORCPT + 6 others); Tue, 8 Sep 2020 03:12:48 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:57896 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728137AbgIHHMk (ORCPT ); Tue, 8 Sep 2020 03:12:40 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 7A2061CFE44A83F966DD; Tue, 8 Sep 2020 15:12:36 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.253) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Tue, 8 Sep 2020 15:12:27 +0800 From: Zhen Lei To: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , devicetree , linux-kernel CC: Zhen Lei , Sebastian Hesselbarth , Haoyu Lv , Libin , Kefeng Wang Subject: [PATCH v2 1/3] irqchip: dw-apb-ictl: prepare for support hierarchy irq domain Date: Tue, 8 Sep 2020 15:11:32 +0800 Message-ID: <20200908071134.2578-2-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20200908071134.2578-1-thunder.leizhen@huawei.com> References: <20200908071134.2578-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.177.253] X-CFilter-Loop: Reflected Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Rename some functions and variables in advance, to make the next patch looks more clear. The details are as follows: 1. rename dw_apb_ictl_handler() to dw_apb_ictl_handle_irq_cascaded(). In function dw_apb_ictl_init(): 1. rename local variable irq to parent_irq. 2. add "const struct irq_domain_ops *domain_ops = &irq_generic_chip_ops", then replace &irq_generic_chip_ops in other places with domain_ops. 3. add "irq_flow_handler_t flow_handler = handle_level_irq", then replace handle_level_irq in other places with flow_handler. No functional change. Signed-off-by: Zhen Lei Tested-by: Haoyu Lv --- drivers/irqchip/irq-dw-apb-ictl.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/irqchip/irq-dw-apb-ictl.c b/drivers/irqchip/irq-dw-apb-ictl.c index e4550e9c810b..aa6214da0b1f 100644 --- a/drivers/irqchip/irq-dw-apb-ictl.c +++ b/drivers/irqchip/irq-dw-apb-ictl.c @@ -26,7 +26,7 @@ #define APB_INT_FINALSTATUS_H 0x34 #define APB_INT_BASE_OFFSET 0x04 -static void dw_apb_ictl_handler(struct irq_desc *desc) +static void dw_apb_ictl_handle_irq_cascaded(struct irq_desc *desc) { struct irq_domain *d = irq_desc_get_handler_data(desc); struct irq_chip *chip = irq_desc_get_chip(desc); @@ -73,12 +73,14 @@ static int __init dw_apb_ictl_init(struct device_node *np, struct irq_domain *domain; struct irq_chip_generic *gc; void __iomem *iobase; - int ret, nrirqs, irq, i; + int ret, nrirqs, parent_irq, i; u32 reg; + const struct irq_domain_ops *domain_ops = &irq_generic_chip_ops; + irq_flow_handler_t flow_handler = handle_level_irq; /* Map the parent interrupt for the chained handler */ - irq = irq_of_parse_and_map(np, 0); - if (irq <= 0) { + parent_irq = irq_of_parse_and_map(np, 0); + if (parent_irq <= 0) { pr_err("%pOF: unable to parse irq\n", np); return -EINVAL; } @@ -120,8 +122,7 @@ static int __init dw_apb_ictl_init(struct device_node *np, else nrirqs = fls(readl_relaxed(iobase + APB_INT_ENABLE_L)); - domain = irq_domain_add_linear(np, nrirqs, - &irq_generic_chip_ops, NULL); + domain = irq_domain_add_linear(np, nrirqs, domain_ops, NULL); if (!domain) { pr_err("%pOF: unable to add irq domain\n", np); ret = -ENOMEM; @@ -129,7 +130,7 @@ static int __init dw_apb_ictl_init(struct device_node *np, } ret = irq_alloc_domain_generic_chips(domain, 32, 1, np->name, - handle_level_irq, clr, 0, + flow_handler, clr, 0, IRQ_GC_INIT_MASK_CACHE); if (ret) { pr_err("%pOF: unable to alloc irq domain gc\n", np); @@ -146,7 +147,8 @@ static int __init dw_apb_ictl_init(struct device_node *np, gc->chip_types[0].chip.irq_resume = dw_apb_ictl_resume; } - irq_set_chained_handler_and_data(irq, dw_apb_ictl_handler, domain); + irq_set_chained_handler_and_data(parent_irq, + dw_apb_ictl_handle_irq_cascaded, domain); return 0;