| Message ID | 20200620224222.1312520-1-j.neuschaefer@gmx.net |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFC,01/10] DT bindings in plain text format | expand |
On Fri, Jun 26, 2020 at 11:55:52PM +0200, Andreas Kemnade wrote: > On Sun, 21 Jun 2020 02:02:20 +0200 > Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: [...] > > Also, do you really need a compatible string to be able to proe the > > driver? What are the chances that you'll get a similar EC without an > > RTC? > > > Tolino Shine 2 HD has the mentioned EC but the vendor kernel does not use > its RTC (not checked whether it is present or functional). > As a key for grepping in the vendor sources: > gptNtxHwCfg->m_val.bPCB = 0x50 Thanks for checking. (In the MMC dump from my Shine 2 HD, it's decimal 50 rather than hex) > Tolino Shine 3 and Kobo Clara HD do not have that EC. Fortunately, this set of drivers isn't needed at all in that case. Thanks, Jonathan
On Sun, Jun 21, 2020 at 08:41:23PM +0200, Andreas Kemnade wrote: > On Sun, 21 Jun 2020 00:42:16 +0200 > Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > > The Netronix embedded controller as found in Kobo Aura and Tolino Shine > > supports one PWM channel, which is used to control the frontlight > > brightness on these devices. > > > > Known problems: > > - `make dt_binding_check` shows the following warnings: > > Documentation/devicetree/bindings/mfd/netronix,ntxec.example.dts:49.17-42: > > Warning (pwms_property): /example-0/backlight:pwms: cell 2 is not a > > phandle reference > > Documentation/devicetree/bindings/mfd/netronix,ntxec.example.dts:49.17-42: > > Warning (pwms_property): /example-0/backlight:pwms: Could not get > > phandle node for (cell 2) > > > In the tolino sources in ./drivers/misc/ntx-misc.c I find this line > > if(4==gptHWCFG->m_val.bFL_PWM) { > > No idea what it does but I would expect to have a kind of translation to > a dt property? As far as I understand it, FL_PWM=4 means that there is a second PWM channel, in order to provide different backlight colors. I think it should be possible to simply extend the binding to list another available PWM channel, once we add support for such hardware. > > + ec_pwm: pwm { > > + compatible = "netronix,ntxec-pwm"; > > + #pwm-cells = <1>; > shouldn't that be 2? > > + }; > > }; > > }; > > + > > + backlight { > > + compatible = "pwm-backlight"; > > + pwms = <&ec_pwm 0 50000>; > since you have 2 values after the &ec_pwm [...] > > +properties: > > + compatible: > > + const: netronix,ntxec-pwm > > + > > + "#pwm-cells": > > + const: 1 > > shouln't that be 2? Right, I'll fix that. Thanks, Jonathan
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 9aeab66be85fc..516c6b6668fba 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -704,6 +704,8 @@ patternProperties: description: Broadcom Corporation (formerly NetLogic Microsystems) "^netron-dy,.*": description: Netron DY + "^netronix,.*": + description: Netronix, Inc. "^netxeon,.*": description: Shenzhen Netxeon Technology CO., LTD "^neweast,.*":
Netronix, Inc. (http://www.netronixinc.com/) makes ebook reader board designs, which are for example used in Kobo and Tolino devices. An alternative prefix for Netronix would be "ntx", which is already used in code released by Netronix. It is shorter, but perhaps less clear. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) -- 2.27.0