From patchwork Wed Apr 1 17:58:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 202541 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD33CC2D0F2 for ; Wed, 1 Apr 2020 17:58:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D96420719 for ; Wed, 1 Apr 2020 17:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585763888; bh=kA/EAqPGu3SnhqPXVjq7VlDuN9vT5z8e1xCkqE8323Q=; h=From:To:Cc:Subject:Date:List-ID:From; b=UItQ+0W+K51FgpACoPkO8SQ2OYOUUxC9xb+7L8//1X3qb/v2enS0BR0YBxkiLV8L5 a9RkC5XO6fgeZeDrSXIXHd7hPpfEf2XoOlf0/DGSQueUJenWyvbJ0IahaCTbc7Mb6F LiNYbUFJxroE44nTMwLAn/m9FR4s4yNdFdsV1fo0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732331AbgDAR6H (ORCPT ); Wed, 1 Apr 2020 13:58:07 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:44195 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730574AbgDAR6G (ORCPT ); Wed, 1 Apr 2020 13:58:06 -0400 Received: by mail-io1-f68.google.com with SMTP id r25so589578ioc.11; Wed, 01 Apr 2020 10:58:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YhnZq6kW0oAS2hnyC5WT5+4Jc6X+26sgyRRXo71R0nw=; b=LaLAGyQxVD2dexQDUi1T9hDIOImPtwYfY9fdUv2OOGVbYE0CwmdGcdjJy4dYrM98rh HH3wxZET/7xsR7PaqGXXRhUOBhr9NaznTb7no+Gw0ZIlFTPIvOFpsgH1JaR0ytRbcNVf VUEavmdUSPMWpeI3eBoEAP40oALh71yEs9atKIzM//8/hwi4CFuYctBOtTFpEK82RWUQ lHZX9zHeylwrLgq0uHNAKqzd9Dkybsl7OSKm/twXHa8YzrPqRNpAdwvR2H6wpwmAsggb 4uhgoGc/2UZ7flA/BgXbStbduPC5FrVZGi1Ldt9ZLUQu9WM0Gfz/rBEvPiYD1EiwQ76W +fWg== X-Gm-Message-State: ANhLgQ1k1JgTtb/mEo9uIx+bsUpmzUgtXybHh68F3laNEZZaxTue1lNY 3UN4KRO+VTfShKCyxFzTkrakj8U= X-Google-Smtp-Source: ADFU+vskUx0caKjWEpqvhl52V9YxFEomzg6LeP8ohqtqv+81Rw6YLLKrL8aJ1yA85E1XQleWax1bVQ== X-Received: by 2002:a6b:6502:: with SMTP id z2mr19396370iob.130.1585763885916; Wed, 01 Apr 2020 10:58:05 -0700 (PDT) Received: from xps15.herring.priv ([64.188.179.250]) by smtp.googlemail.com with ESMTPSA id z20sm771447iod.25.2020.04.01.10.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 10:58:05 -0700 (PDT) From: Rob Herring To: "David S. Miller" Cc: devicetree@vger.kernel.org, Tobias Waldekranz , netdev@vger.kernel.org Subject: [PATCH] dt-bindings: net: mvusb: Fix example errors Date: Wed, 1 Apr 2020 11:58:04 -0600 Message-Id: <20200401175804.2305-1-robh@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The example for Marvell USB to MDIO Controller doesn't build: Error: Documentation/devicetree/bindings/net/marvell,mvusb.example.dts:18.9-14 syntax error FATAL ERROR: Unable to parse input tree This is due to label refs being used which can't be resolved. Fixes: 61e0150cb44b ("dt-bindings: net: add marvell usb to mdio bindings") Cc: Tobias Waldekranz Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Rob Herring --- David, Please take this and send to Linus before rc1 as 'make dt_binding_check' was broken by the above commit. That would have been caught had the DT list been CC'ed or if this had been in linux-next long enough to test and fix (it landed in next on Monday :(). Rob .../bindings/net/marvell,mvusb.yaml | 29 +++++++++---------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml index 9458f6659be1..68573762294b 100644 --- a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml +++ b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml @@ -38,28 +38,27 @@ required: examples: - | /* USB host controller */ - &usb1 { - mvusb: mdio@1 { + usb { + #address-cells = <1>; + #size-cells = <0>; + + mdio@1 { compatible = "usb1286,1fa4"; reg = <1>; #address-cells = <1>; #size-cells = <0>; - }; - }; - /* MV88E6390X devboard */ - &mvusb { - switch@0 { - compatible = "marvell,mv88e6190"; - status = "ok"; - reg = <0x0>; + switch@0 { + compatible = "marvell,mv88e6190"; + reg = <0x0>; - ports { - /* Port definitions */ - }; + ports { + /* Port definitions */ + }; - mdio { - /* PHY definitions */ + mdio { + /* PHY definitions */ + }; }; }; };