| Message ID | 20191126022243.215261-2-joel@jms.id.au |
|---|---|
| State | Superseded |
| Headers | show |
| Series | reset: Add ast2600 support | expand |
On Tue, 26 Nov 2019, at 12:52, Joel Stanley wrote: > The AST2600 has the same LPC layout as previous generation SoCs. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > index 86446074e206..bef07c3b1a3e 100644 > --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > @@ -46,6 +46,7 @@ Required properties > - compatible: One of: > "aspeed,ast2400-lpc", "simple-mfd" > "aspeed,ast2500-lpc", "simple-mfd" > + "aspeed,ast2600-lpc", "simple-mfd" > > - reg: contains the physical address and length values of the Aspeed > LPC memory region. > @@ -64,6 +65,7 @@ BMC Node > - compatible: One of: > "aspeed,ast2400-lpc-bmc" > "aspeed,ast2500-lpc-bmc" > + "aspeed,ast2600-lpc-bmc" > > - reg: contains the physical address and length values of the > H8S/2168-compatible LPC controller memory region > @@ -128,6 +130,7 @@ Required properties: > - compatible: One of: > "aspeed,ast2400-lpc-ctrl"; > "aspeed,ast2500-lpc-ctrl"; > + "aspeed,ast2600-lpc-ctrl"; > > - reg: contains offset/length values of the host interface controller > memory regions > @@ -168,6 +171,7 @@ Required properties: > - compatible: One of: > "aspeed,ast2400-lhc"; > "aspeed,ast2500-lhc"; > + "aspeed,ast2600-lhc"; > > - reg: contains offset/length values of the LHC memory regions. In the > AST2400 and AST2500 there are two regions. > @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to > modify this configuration. > > Required properties: > > - - compatible: "aspeed,ast2500-lpc-reset" or > - "aspeed,ast2400-lpc-reset" > + - compatible: One of: > + "aspeed,ast2400-lhc"; > + "aspeed,ast2500-lhc"; > + "aspeed,ast2600-lhc"; This doesn't look right, you've removed the reset compatibles. It looks like copy/paste from the hunk before. > + > - reg: offset and length of the IP in the LHC memory region > - #reset-controller indicates the number of reset cells expected > > -- > 2.24.0 > >
diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt index 86446074e206..bef07c3b1a3e 100644 --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt @@ -46,6 +46,7 @@ Required properties - compatible: One of: "aspeed,ast2400-lpc", "simple-mfd" "aspeed,ast2500-lpc", "simple-mfd" + "aspeed,ast2600-lpc", "simple-mfd" - reg: contains the physical address and length values of the Aspeed LPC memory region. @@ -64,6 +65,7 @@ BMC Node - compatible: One of: "aspeed,ast2400-lpc-bmc" "aspeed,ast2500-lpc-bmc" + "aspeed,ast2600-lpc-bmc" - reg: contains the physical address and length values of the H8S/2168-compatible LPC controller memory region @@ -128,6 +130,7 @@ Required properties: - compatible: One of: "aspeed,ast2400-lpc-ctrl"; "aspeed,ast2500-lpc-ctrl"; + "aspeed,ast2600-lpc-ctrl"; - reg: contains offset/length values of the host interface controller memory regions @@ -168,6 +171,7 @@ Required properties: - compatible: One of: "aspeed,ast2400-lhc"; "aspeed,ast2500-lhc"; + "aspeed,ast2600-lhc"; - reg: contains offset/length values of the LHC memory regions. In the AST2400 and AST2500 there are two regions. @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to modify this configuration. Required properties: - - compatible: "aspeed,ast2500-lpc-reset" or - "aspeed,ast2400-lpc-reset" + - compatible: One of: + "aspeed,ast2400-lhc"; + "aspeed,ast2500-lhc"; + "aspeed,ast2600-lhc"; + - reg: offset and length of the IP in the LHC memory region - #reset-controller indicates the number of reset cells expected
The AST2600 has the same LPC layout as previous generation SoCs. Signed-off-by: Joel Stanley <joel@jms.id.au> --- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.24.0