From patchwork Fri Jun 28 08:17:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 168020 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3384282ilk; Fri, 28 Jun 2019 01:17:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqw1KPBLUFAI+AJKdgNZx0N1+s6EIDlGmAt+SghdCM+OkMXeD8WB4AU3chknphGbZUQDZZED X-Received: by 2002:a63:e4a:: with SMTP id 10mr8217384pgo.348.1561709835400; Fri, 28 Jun 2019 01:17:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561709835; cv=none; d=google.com; s=arc-20160816; b=VHr2kukAN6rig5qT0PVVkOjvd9ghFJ9xL/wxZRfUe7A9ShiC9xuH4KuR4RomXt1LlA V9wZ3Lfful3okvN9dwWAKA5NK73RHbKPeziNKriuluDDZGDeh3hp9qQrPZVdLHOXQIYv zkcJPyybaP4cG7fbEgZvSgKQrWlzUVGEa1ra4ehc+KuHfIvqjR23aobpWQD7MOzN1xLC bExosAyiZJG3Zv0lSuSQKTlg9EjXyyh7NXPTfa9Q1RUbjtI/ddRjicRYudPK0oM8CZGh c4ha6LrmeEeoxjJOex8qaIv6JCLvdni+cCufU2NmoO4lJR/NJXnOACrWr0Y9PWcoV8ZA CLNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=0iX4GoXUMjYo0yWAqnak7nWNu9SahWjJ+qIlyX2DjnA=; b=WYSgoU6wdZr3xCorCCuEsxC4bEPVDrFG9MAPE5EhQW3wfFjTCztlJP/hNyLYi7wz3X qUbQtjzZn2uWlCHkFnj5uk0SOveEONnVRLGfGBfLq+/5wKdAn4em4U3c70KWpXole+mW +L7Y+9BlZhox6ietiZ6fxKwI5HxLZQ2cp34sq7/HBlJYQ1GpOM2lqbty5nVSWhKti6uI NVjfq126YFWA4GMBmOUtn+KEdUiy4bHDYRgqumK5tbJWNt6eOgvoJOG8INAg3ZdIl3/E H/NytsMkKfoYj7ahN2jgymMaxTDHcxIOZJw+6xbeebuX6/xxphBuF2sKsRRgqrGm0MX3 QDmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=pqUrZZrH; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q5si1500954pgp.111.2019.06.28.01.17.15; Fri, 28 Jun 2019 01:17:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=pqUrZZrH; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726519AbfF1IRO (ORCPT + 8 others); Fri, 28 Jun 2019 04:17:14 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34912 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbfF1IRO (ORCPT ); Fri, 28 Jun 2019 04:17:14 -0400 Received: by mail-wr1-f67.google.com with SMTP id f15so5306942wrp.2 for ; Fri, 28 Jun 2019 01:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0iX4GoXUMjYo0yWAqnak7nWNu9SahWjJ+qIlyX2DjnA=; b=pqUrZZrHnpMwYQiyu/1jCW1Vn1dbIBUApoVZMhyhBwvnhvhfumKMpGn/HD06hkyLKV mAr70tgH1UWNF40M5i4Iu7TZyBCOF9E4DVrgXNhfgFoe68UERxt7W4BtnpD/aXQbHgrr KSKRFDsze0oQlGIrrEesEJEXxvjGoX7ByoMNidbjknRj4Bylt+bqRjjgIIVO6eX4pKnN 1AmfDbD/NeC/4Z9WHyrLlNhDEE1EW62NsHUnaW1L+cOpLHwoL1tVmmD214BJEgmzEGJp UBCPbzQkK8BSlSG9gz7fGNCBlajjvLjh/2C21gkCh6AjXCuIST7i+hrq6mn684QyGZ60 KhUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0iX4GoXUMjYo0yWAqnak7nWNu9SahWjJ+qIlyX2DjnA=; b=Vgk6i8bXa2dRZUzWVW1+KjXbKkpnJfxjUAaAT5b6gY8yW+HD/Lyv0goU7HrNo8ThuE 9hIoo8Pe5uvQAXEC7hBvU0wEA5umMo1iTs5TC9ZEQ5CTVhwEWxidzHhotC10xfADo2Fx GByh4OlSslEXyQxrakh4qkiA9iMyQsSWoI/NYofGYJcH8NNVH4mN+52oMKSWDHSCl8Hj AFag2ULRlktGyo0+k7KVQ+xMkc+QgBDMF0wLiU1kvlIQsndT0SyWxIpn5GPEidRZuePd N6uQ4x/2uh4djdqhFQURZQWy9HO8FDTIiemilq+0/kVNCtOb7xZdDAUgoG2Sm+32BNy2 EWIg== X-Gm-Message-State: APjAAAXFb5aaGkrPpfxlwIFrU+4X5xk2SxLjGTHE4efFZtyagwR4PXhO 6Ogt7fmtAhJmRhV7InCxtRFVzQ== X-Received: by 2002:a05:6000:124a:: with SMTP id j10mr6749454wrx.191.1561709832291; Fri, 28 Jun 2019 01:17:12 -0700 (PDT) Received: from starbuck.baylibre.local (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id r5sm2819216wrg.10.2019.06.28.01.17.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 28 Jun 2019 01:17:11 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood , Kevin Hilman Cc: Jerome Brunet , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Dan Carpenter Subject: [PATCH] ASoC: meson: axg-card: remove useless check on codec Date: Fri, 28 Jun 2019 10:17:08 +0200 Message-Id: <20190628081708.22039-1-jbrunet@baylibre.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Patchwork-Bot: notify Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org While checking cpus before dereferencing the pointer is required, it is not necessary for codecs. 'codec' can't possibly be NULL in the loop Reported-by: Dan Carpenter Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-card.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.21.0 diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c index 70bb0cbad233..14a8321744da 100644 --- a/sound/soc/meson/axg-card.c +++ b/sound/soc/meson/axg-card.c @@ -118,8 +118,7 @@ static void axg_card_clean_references(struct axg_card *priv) if (link->cpus) of_node_put(link->cpus->of_node); for_each_link_codecs(link, j, codec) - if (codec) - of_node_put(codec->of_node); + of_node_put(codec->of_node); } }