From patchwork Wed Oct 31 01:02:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 149761 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp6177085ljp; Tue, 30 Oct 2018 18:02:35 -0700 (PDT) X-Google-Smtp-Source: AJdET5eENVlWXkkiJyGcq146bMWg9azTq2HQdNlFb8YJq7jyqn6tmM4lfoHuO0YnC6IEnaK6DsUE X-Received: by 2002:a17:902:7108:: with SMTP id a8-v6mr1037533pll.290.1540947755273; Tue, 30 Oct 2018 18:02:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540947755; cv=none; d=google.com; s=arc-20160816; b=LgsinrDVSqM8knK8+bZc8zThNgSgjG7wCJ1WBIPsIJ5FVkU2p0YjCWrJsoUbB75cPh LWff4zYICvG1ypuecyApqcRCU6avLF4fAbctIaf3T9CkUEIxXh9ErE9Ehb31yCJdsse0 zoOCUECMYlGwN312YE5/t4jPraXbIx1lWkbh/RJjlvAO4XyHevfpCIdMwOthezHmYdH6 7Ggffr1Vw4eHGY3bKFs1hDA57bevP+WfdFA4pDJx6JvcT0rlpXZ+DjHUj38rIAUKy8Kj XEW9p75uvNEcd1FWu6aqeXQk0CbwD83i4igoWLustckekOdaakllQ1pO7TblDmxbvCt+ Y81Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=a2BLSjGV6eNtm4Jdz3ZPId1ONFq+rOlKV9h7U3Vip04=; b=Cv0D6poenumd8wiRsfX63SP+IlNsNYBBRx4PDiHdAlmmA9ymUyhMuVK11XlNfoRV7A bbv15VD60ebvUpdVemaJsc/YlnD5S3/GHjbqoFPGsPLuHRtBsQ2ERQjm/A7z2reOZA4Z dyUn7g6VaQ2D0gvWmfTfITYLbnWOsWl7OQvLQ5g/MznI8MwqrKNCQltmRGvxoQL953rH 4kvjxyE6o2a18DfzKPJ78rxdEWedl4Rwpa9A1aypCbUA1pAgHaKMz4Huk0F2F6je2tSk v7pi0zohJRzNR+WYOpqwVfYnhY5RjydDwPrjIimxqVV2i7Kd4zKOCbnjVsdr3Sq0e20y KV6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p2-v6si11457624pli.79.2018.10.30.18.02.35; Tue, 30 Oct 2018 18:02:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728928AbeJaJ6V (ORCPT + 6 others); Wed, 31 Oct 2018 05:58:21 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:35578 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728927AbeJaJ6V (ORCPT ); Wed, 31 Oct 2018 05:58:21 -0400 Received: by mail-ot1-f65.google.com with SMTP id 14so13061221oth.2 for ; Tue, 30 Oct 2018 18:02:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a2BLSjGV6eNtm4Jdz3ZPId1ONFq+rOlKV9h7U3Vip04=; b=MsDFEYDPBH5G/7yU4b/Z6YokP8Cz+ygVHeXL19JGCmvPyrk6DODleZvf+j6YDyQ8l/ HhcLOgORrLbDCvU6GO9enrDXiNT4zKfYya0H35pgyiFvhCPd+04TaKef1XmndvS3B4DB HyIva8+MnvnidjVW6qqPDAG4NfXiKxl8qtAflEQ2jGYjTGLGpbJcZ2sJIsfbE2dSXfqU gvm+XGcIlcCdgbEy7ckmbzXt2KKT3pYM4NNeDu9VNSP2OL6z9cV+qKupUIm3x1RshpB0 ZsL09t5bXqR9+TbIti+E7PLNPee7bthWuRIQAiSAJmFK6EIa3hiN0EeFPDvswkKCHSLg w8mA== X-Gm-Message-State: AGRZ1gKF/TEehlkUQO8PROoWK21gSXP71K8KzDvYOXXurqK0qHXoF7S7 cwXB1hQxKxyDXuN6QiUA2w== X-Received: by 2002:a9d:2e26:: with SMTP id q35mr638425otb.283.1540947752847; Tue, 30 Oct 2018 18:02:32 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id d88sm1171852otb.3.2018.10.30.18.02.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Oct 2018 18:02:32 -0700 (PDT) From: Rob Herring To: Shawn Guo Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Mark Rutland , Fabio Estevam , Stefan Agner Subject: [PATCH v2] ARM: dts: fsl: Fix improperly quoted stdout-path values Date: Tue, 30 Oct 2018 20:02:30 -0500 Message-Id: <20181031010230.6723-1-robh@kernel.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org A quoted label reference doesn't expand to the node path and is taken as a literal string. Dropping the quotes can fix this unless the baudrate string is appended in which case we have to use the alias. At least on VF610, the problem was masked by setting the console in bootargs. Use the alias syntax with baudrate parameter so we can drop setting the console in bootargs. Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: NXP Linux Team Cc: Mark Rutland Reviewed-by: Fabio Estevam Reviewed-by: Stefan Agner Signed-off-by: Rob Herring --- v2: - Fix missing closing quote in vf610m4-colibri.dts arch/arm/boot/dts/imx53-ppd.dts | 2 +- arch/arm/boot/dts/vf610m4-colibri.dts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.19.1 diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts index cdb90bee7b4a..f202396e3f2a 100644 --- a/arch/arm/boot/dts/imx53-ppd.dts +++ b/arch/arm/boot/dts/imx53-ppd.dts @@ -55,7 +55,7 @@ }; chosen { - stdout-path = "&uart1:115200n8"; + stdout-path = "serial0:115200n8"; }; memory@70000000 { diff --git a/arch/arm/boot/dts/vf610m4-colibri.dts b/arch/arm/boot/dts/vf610m4-colibri.dts index 41ec66a96990..ca6249558760 100644 --- a/arch/arm/boot/dts/vf610m4-colibri.dts +++ b/arch/arm/boot/dts/vf610m4-colibri.dts @@ -50,8 +50,8 @@ compatible = "fsl,vf610m4"; chosen { - bootargs = "console=ttyLP2,115200 clk_ignore_unused init=/linuxrc rw"; - stdout-path = "&uart2"; + bootargs = "clk_ignore_unused init=/linuxrc rw"; + stdout-path = "serial2:115200"; }; memory@8c000000 {