From patchwork Fri Sep 21 10:21:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 147213 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp629645ljw; Fri, 21 Sep 2018 03:25:14 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaCP8pK/QXNyDoX5CFbQDpx+61bhs8cDS0Agc66xKgvTHSyxD2HlAUz6O4znvHnZP64xaq2 X-Received: by 2002:a17:902:3a3:: with SMTP id d32-v6mr43649953pld.294.1537525514550; Fri, 21 Sep 2018 03:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537525514; cv=none; d=google.com; s=arc-20160816; b=tq+uzKpbQaMHwG6UXPxvE0uLh0hvo5ItTDQAX4f9JvYiBpzRp86/1Wz2VTgODiWx6d ycYoLHGtr/EGaYS7QBUIf6ZrMh3Z6ttVORu7TILQDaUqW0XvtH9YaOSUWqB5dl6RGQcy oGUP8nnDLcSsi9+Xf4Kx8uhysQZ9bxywsrFiQE7kGAhsXL/zcn19s1kodWtCoruCrFou B70k4m8y89XJtG5lPctfIGrvi+zXMUFH6MLT0XvjPq75kolFwvaAkpI5BAxWSana6hVK HRCYcTvDEmM5HwGqBwEl85VQvKqhAu3BANVn4j9OHL9KjOgUJTnNYt4AOx6HEEZadZWO Jthg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=MdVZEmvM9U35LgLquwnypWHuyVsV6bB8cMSesoTOxEQ=; b=RBuFvy8H0C0Oi43rYN17YVapGYtYmr3ZwnNvlkJAJ354j55lOU/lKjZnJt5HiP8Nzs H4IeD76yDjSICfBsJhzfoayu9TL5tMkMnkzy9Zab5QnO4JfDRWSnONs+oI37LDsqdaIJ 2tZHSluUMvdHRimIVD8JAEZcGxvMkFSYCrxXFqy1AfTHmOA/FqmRIhUQ2CFEBj1T29r3 z53qrf12xepmja2kVR0FT5iDrePgCIVkfDbMwoa3QE/htxJqCTiWPogU6bz19jQgzdsV zlEGe2eA8YvpdXADEOtCtMIoCMPf8C32XBTeJcDGTp2qIgg4XK5asrQlF7DOk8n9fiGx sPKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=gwXEhNSA; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m23-v6si7702139pgn.603.2018.09.21.03.25.14; Fri, 21 Sep 2018 03:25:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=gwXEhNSA; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390243AbeIUQNZ (ORCPT + 6 others); Fri, 21 Sep 2018 12:13:25 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:51516 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389264AbeIUQNY (ORCPT ); Fri, 21 Sep 2018 12:13:24 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id w8LAOmZY033499; Fri, 21 Sep 2018 05:24:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1537525488; bh=MdVZEmvM9U35LgLquwnypWHuyVsV6bB8cMSesoTOxEQ=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=gwXEhNSAC61pBkIuwuy7AcVxCQ9aw41u02U0M8FpOa2+GdyzZwgcrrbH3PhlEmGS3 7409X1DNHzKdedZ4L2r2VdVn7IInbRYmwPbQaZUFxB33kyb4s5fklqbiLYfsel9bIo wNDmQdrBa0OZ0a36+nlbWiMdzfFatCIIYORYPyn4= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8LAOmwM020534; Fri, 21 Sep 2018 05:24:48 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 21 Sep 2018 05:24:48 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Fri, 21 Sep 2018 05:24:48 -0500 Received: from a0393678ub.dal.design.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8LAMEta032280; Fri, 21 Sep 2018 05:24:43 -0500 From: Kishon Vijay Abraham I To: Jingoo Han , Joao Pinto , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Murali Karicheri , Kishon Vijay Abraham I , CC: Mark Rutland , Santosh Shilimkar , Tero Kristo , Nishanth Menon , , , , Subject: [RFC PATCH 32/40] phy: core: Invoke pm_runtime_get_*/pm_runtime_put_* before invoking reset callback Date: Fri, 21 Sep 2018 15:51:47 +0530 Message-ID: <20180921102155.22839-33-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180921102155.22839-1-kishon@ti.com> References: <20180921102155.22839-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org PHY drivers may try to access PHY registers in the ->reset() callback. Invoke phy_pm_runtime_get_sync() before invoking the ->reset() callback so that the PHY drivers don't have to enable clocks by themselves before accessing PHY registers. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/phy-core.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.17.1 diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index 35fd38c5a4a1..b2f863f0866e 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -384,10 +384,16 @@ int phy_reset(struct phy *phy) if (!phy || !phy->ops->reset) return 0; + ret = phy_pm_runtime_get_sync(phy); + if (ret < 0 && ret != -ENOTSUPP) + return ret; + mutex_lock(&phy->mutex); ret = phy->ops->reset(phy); mutex_unlock(&phy->mutex); + phy_pm_runtime_put(phy); + return ret; } EXPORT_SYMBOL_GPL(phy_reset);