diff mbox series

[v2,2/2] ARM: dts: da850-lcdk: add unit name for memory node

Message ID 20180418092408.2077-3-nsekhar@ti.com
State Accepted
Commit 01de0be5c1a3a03d043fd28c2a6a6fef245c9ab8
Headers show
Series ARM: dts: da850: fix warnings related to memory node | expand

Commit Message

Sekhar Nori April 18, 2018, 9:24 a.m. UTC
Add unit name for memory node to squash the W=1 warning:

arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

While at it, drop the device_type property from memory
node since its provided by da850.dtsi already.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>

---
v2: drop device_type property. Add a comment on size of SDRAM.

 arch/arm/boot/dts/da850-lcdk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.16.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Lechner April 18, 2018, 3:20 p.m. UTC | #1
On 04/18/2018 04:24 AM, Sekhar Nori wrote:
> Add unit name for memory node to squash the W=1 warning:

> 

> arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

> 

> While at it, drop the device_type property from memory

> node since its provided by da850.dtsi already.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

> ---


Reviewed-by: David Lechner <david@lechnology.com>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sekhar Nori April 24, 2018, 8:59 a.m. UTC | #2
On Wednesday 18 April 2018 08:50 PM, David Lechner wrote:
> On 04/18/2018 04:24 AM, Sekhar Nori wrote:

>> Add unit name for memory node to squash the W=1 warning:

>>

>> arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg):

>> /memory: node has a reg or ranges property, but no unit name

>>

>> While at it, drop the device_type property from memory

>> node since its provided by da850.dtsi already.

>>

>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

>> ---

> 

> Reviewed-by: David Lechner <david@lechnology.com>


Applied both to fixes.

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index a1f4d6d5a569..0edf769ea95c 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -21,8 +21,8 @@ 
 		stdout-path = "serial2:115200n8";
 	};
 
-	memory {
-		device_type = "memory";
+	memory@c0000000 {
+		/* 128 MB DDR2 SDRAM @ 0xc0000000 */
 		reg = <0xc0000000 0x08000000>;
 	};