From patchwork Tue Mar 13 13:15:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 131467 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp723871ljb; Tue, 13 Mar 2018 06:16:10 -0700 (PDT) X-Google-Smtp-Source: AG47ELsoFSy7DoEHPajQh2slt7opncS0+Mchnq571e0vgKi2Momc4Hg/RiD791amBPh+mDP3I3KW X-Received: by 2002:a17:902:6b89:: with SMTP id p9-v6mr525417plk.285.1520946970043; Tue, 13 Mar 2018 06:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520946970; cv=none; d=google.com; s=arc-20160816; b=cf2r2wSdcGZX15zLaDZ/4eQp2RfNwO7FpMg+rojJkJfAD+1OlU71LKw7U98PQJ+1HU 4DFjJmdO4DqZMM2Sr7ttDVt3pYPuJxlqEWQcQyL1FULyXlBB140o2yWoPrasEUwSZxAo 9JesLgBcVcknmBhe+V5BcYyOiIFJxIuy0Ru3g4ICXQGeRNjquW2jt170dXHkpK2wxFgi wsCVnqiN+PYed7BZuNs0qOXWuUt6JNCfcXSEgAhbdA07JaSUc5X9zcXbY8eMBPRLFrXN htFQCQRw7P/OnivmBuIjNlmbQh/FnajvF+fNYv81avrRFz/xRyVCvJT2eUMj0fEF0xL9 jMVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=JwwSVKAEh3pVBzvf6qTBeamJIbIQq00M7nBWbWfPOzY=; b=eLbjT37iHopHkAxYfQJsaQlfXFKq0hVvKC6DIISWh8K7HlMWob+SpgYcsYQzKTkgwp Ft0FgkSeoEQfNFxCLwSaIywU/H5f3K+pE0DjzoL/FnVfqOvN5s5viNQP+KvdAhwxodPO XUTUGOpZgIGDxYPESR1xNB9qP2hWlqKu+e1+/UwNU2oKRDZyENwZs+iBsGJvJ6zgQtSo T2XBdA9asKcOb+ybFkBKwtPavEUCrdzVdMECd9VDSRZvkv741qhOUbWXOFl4VGSHoeFq 58r2PTXDeHrpSJcWuoNSmqODV45iJ4HJqt5KhorPhSYxxrtjWBUILpmHwTcT43XW5gRo evdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si105821pgp.480.2018.03.13.06.16.09; Tue, 13 Mar 2018 06:16:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776AbeCMNQI (ORCPT + 6 others); Tue, 13 Mar 2018 09:16:08 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:56407 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751764AbeCMNQI (ORCPT ); Tue, 13 Mar 2018 09:16:08 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0LqUAj-1eQXlC0vdx-00e2Cn; Tue, 13 Mar 2018 14:16:03 +0100 From: Arnd Bergmann To: Rob Herring , Frank Rowand Cc: Arnd Bergmann , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] of: unittest: move misplaced function declaration Date: Tue, 13 Mar 2018 14:15:42 +0100 Message-Id: <20180313131600.85356-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Lj6atJ1MLBC3rJqIaDHzIpGHrbjTFXxDDVVbnY2TKFeomJck0Pt k2GowvA0Dz0sf5i7n2+8+N/gkd8cPWUnvWr2ccaWTPabnsEcoKhEKHpMJT7cIChRWVdO9Mx BCq1i+P+gZnu3el0M/KLctmE2zyP7pFQEtJ1y0/bBSdiVqkhN32pgX1tWrU/ed1doOQOrj+ TxBtS4aC9QAwesiYYZGIg== X-UI-Out-Filterresults: notjunk:1; V01:K0:pis0q6pz1Cs=:+CwWARWzRuRwaFETTsCT66 sGCkWdSkJvwpOevuXD3CIAtB+OT1pgpU9PpgnPe76gMvqLlE7Iwd87GJsxB2fnF+Q8ABu5XvW BuBhpf8dIAgqpCUgZAG4rZA5ZT34LB5nfi7n8l9/wleWeRzcgK3ENsB3pO+UYbNTN5KepY+jG Oz1YKSl/jvRp5U91yhIBpAjgOSwow+kaFJfgW7wn4X2fT4y10Q3rglC9UyNElEIF1p+jVx7ro ZB/MzbrU1cUIm03T9xvuBk3GLVAhB9IU8Q6xiF6fVRrhHzbRegWWu4P0jWhlxV5Ed4zZLPjwZ ZIPIRENmklcE1+rQjjqhuYs4AYcL97JozZgZj8nFrIoGyd/vQ6KccqS9JP66wnYnouL/gnjRw dj6zDbwdNr2ZnxQFgnUx5H24vaoYMWLJCYF6iJBSPwG0Bjusiui+XLg7GNz1oGQ7UygxmPSED 5DQwDf9cnwv4cDoSmuEC+dCyQqoWJZbTXCppn9OnFHadEu+4oOHcYqK9PO9MhoKPrFEcwwyjx eryAf+k/ZziS+bByEjdZtb+aYPtNZseFuY7K4YMummXehA8brrUBtMop/dyrYrnDGsOZWBxSE ZVOJ/QgPTe+qf7fnJURWLxm71eTxR8TtsPtt6IjvsAtlDD9TdXOEpUWfRPckQSP2hl8cWOZ1n Vs1dUZmLiG6s2G7yWoEMJmIOIQ/0MQK7bkqD/4PpehW/S2Wboo1YI3MJOAgn873wZ9/ni2y/h LFyuM4bcIVYKkQsJz5kgovtCpVU/3P/+p43cFQ== Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The overlay_data_apply() declaration is outside of the #ifdef that contains both the user and the definition, causing a compile-time warning in some configurations: drivers/of/unittest.c:48:19: error: 'overlay_data_apply' declared 'static' but never defined [-Werror=unused-function] static int __init overlay_data_apply(const char *overlay_name, int *overlay_id); This moves the declaration into the #ifdef section. Fixes: 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT") Signed-off-by: Arnd Bergmann --- drivers/of/unittest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index dede77a79820..260d5245491b 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -45,8 +45,6 @@ static struct unittest_results { failed; \ }) -static int __init overlay_data_apply(const char *overlay_name, int *overlay_id); - static void __init of_unittest_find_node_by_name(void) { struct device_node *np; @@ -1185,6 +1183,7 @@ static int __init unittest_data_add(void) } #ifdef CONFIG_OF_OVERLAY +static int __init overlay_data_apply(const char *overlay_name, int *overlay_id); static int unittest_probe(struct platform_device *pdev) {