From patchwork Fri Oct 13 07:44:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 115710 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp430536qgn; Fri, 13 Oct 2017 00:44:56 -0700 (PDT) X-Received: by 10.98.213.194 with SMTP id d185mr611768pfg.107.1507880696599; Fri, 13 Oct 2017 00:44:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507880696; cv=none; d=google.com; s=arc-20160816; b=vijZ6XmiyqwvOMqsgzI9aDWMqOiiVw6Sg9TnJ9ltGSeOdjmDAaEeizqXFIACffOVyX NjLZrach3bnjtLl8lEyO5KIzg6U1cBh3Mhcxo3770bH09vHelBRhupFoV9Ax+1beWUfz qxwMe5SOMa3M+Mz6Y9tdzuWaKpOr+L57AuzKcJJyNpWHaZLNHkUbDI8VdOdFZEi4zAI4 hxrlYCxFGZ7GTPmYoncHCKiVTKPpBolEzU/+I/1k6NkR/0cmEVp4b53PN7K7wQoZ9EY1 g/QeHvBV/X14kO5S5sb/gx+XUSIifM+t1Pa4YB0DBOG7zwCDCDR/KjMkWWohb9GANB0/ K7Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=eWQFDO7bCMMZ45/HtUuKHYr44HG1nTdeojQ9RDOXsZg=; b=Fak7jy+5t2oo2CG5U8sWjg3a+pUDRjaSXHVKSk2+yOU7MGVeYc+OjTzcTTbSTAlw6+ reGPVKmH+NrsxogP6mKQX1ZTfeAqm6IM9RtkIxprcLd4N+yhDjZWgiTciz34MiTyVxmW Dl6kDguJQzgL4RTj1Qjv6bp+oTpCUzOqbwulhrzlGLaXzXC2wx9695MyE/ETz43sRv17 rZgZoMoDQIKqUzwLDLsLcKfTme8YzS/58LcQi4PumHX1ulBr1xRwpyrTF2ZrBESoQawT 5+auOVefjd9oC8MFS58S0DQPqzlSZSkjubdSsNABT9d4wsygdNsIeJsayBbCE8gmhDzV rNaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=dGUBeGaF; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c17si239224pfe.338.2017.10.13.00.44.56; Fri, 13 Oct 2017 00:44:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=dGUBeGaF; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbdJMHoz (ORCPT + 6 others); Fri, 13 Oct 2017 03:44:55 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:53734 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbdJMHoy (ORCPT ); Fri, 13 Oct 2017 03:44:54 -0400 Received: by mail-pf0-f180.google.com with SMTP id t188so6399076pfd.10 for ; Fri, 13 Oct 2017 00:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=FDJhKpHnkAsrZYh8xW9LDBcGaLG7I9FW/squz6OV470=; b=dGUBeGaF5DXT1F7zErRod+gXrEzPVA7eKH+HF2iu73aSZgc46iwQWUrhIeiZzdh1SP KnItCgBKnd5Qs709QNlHLSaZYJFAQ7R0bJ6bwhmA4cYIEDO+TeuYalHW+jo96CklUjer 8s+g2B76dLLIx5JQMLcGgN33cMYKVJv4hWDwE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FDJhKpHnkAsrZYh8xW9LDBcGaLG7I9FW/squz6OV470=; b=SD+ijhx04t+aiW4WYTKV60+uE3qXNcuacglACtvvm8EOCZR2HPbndn3N9xdgTBblbN KHCDa71taPf/WjdNZmzPeUSPg5XNg7pNYNzaanqqwHJDB4rYRtv91FsNWV9VO+yDmLsL z0dh6wstpHcaLkbWBTFtYmRqoVplGG0gzxjwloyL9IN6AXfJbSFKXIgnaV0aNYYCgbkC rGIRSi5eJgwsk9tuM44K8uPeLR66ZykEZATBDY0y89fZVVEpQjXutE0RaWSyIER38U0t J53AtSYoCLJdO8g9gM+fK4SXVVPKlDSSzVyq5ysxkzOTuU4bitYr777Jxraeqw5pvwrB Ke+A== X-Gm-Message-State: AMCzsaV2sYINcvgG8Q7YILvtYrgu/scMnMj9kGqqAoKsCkGIdS0o1Qmu kN717NE2yzU/sjrO9l5Gp2sDvw== X-Google-Smtp-Source: AOwi7QD9Bik2EBWt4EEX9F9+ZHBbhtYeREqMd96v9aXyXJZrCgn/Bc7U3OgcsZ5slQRxSQZ22WArpA== X-Received: by 10.99.121.14 with SMTP id u14mr598386pgc.420.1507880694258; Fri, 13 Oct 2017 00:44:54 -0700 (PDT) Received: from localhost.localdomain (ip72-199-124-160.sd.sd.cox.net. [72.199.124.160]) by smtp.gmail.com with ESMTPSA id h9sm1216374pfh.98.2017.10.13.00.44.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Oct 2017 00:44:53 -0700 (PDT) From: Stephen Boyd To: Rob Herring , Frank Rowand Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH] of: unittest: Remove redundant OF_DETACHED flag setting Date: Fri, 13 Oct 2017 00:44:51 -0700 Message-Id: <20171013074451.14176-1-stephen.boyd@linaro.org> X-Mailer: git-send-email 2.14.GIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org of_fdt_unflatten_tree() already sets the flag on the node to OF_DETACHED, because of_fdt_unflatten_tree() calls __unflatten_device_tree() with the detached bool set to true. Signed-off-by: Stephen Boyd --- drivers/of/unittest.c | 2 -- 1 file changed, 2 deletions(-) -- 2.14.GIT -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Frank Rowand diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 35bf9617ae59..8795478a4754 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1112,7 +1112,6 @@ static int __init unittest_data_add(void) pr_warn("%s: No tree to attach; not running tests\n", __func__); return -ENODATA; } - of_node_set_flag(unittest_data_node, OF_DETACHED); rc = of_resolve_phandles(unittest_data_node); if (rc) { pr_err("%s: Failed to resolve phandles (rc=%i)\n", __func__, rc); @@ -2262,7 +2261,6 @@ static int __init overlay_data_add(int onum) ret = 0; goto out_free_data; } - of_node_set_flag(info->np_overlay, OF_DETACHED); ret = of_resolve_phandles(info->np_overlay); if (ret) {