From patchwork Thu Jul 20 14:27:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 108350 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp2200115obm; Thu, 20 Jul 2017 07:27:18 -0700 (PDT) X-Received: by 10.84.198.3 with SMTP id o3mr4399117pld.84.1500560838648; Thu, 20 Jul 2017 07:27:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500560838; cv=none; d=google.com; s=arc-20160816; b=DLXP/ZQvCkpWRh7ADo+Z8mhRwnt6PyYytpVCg+/DSr7CMM2TPAMUVUPbPZzUdooMl6 NUXHDh9o2CVGC2wERNjjIzyRwP1xBajk7lJZbpS1vLziJ60zLko91Gq9sIluBSmYt2vA CwKr9pJ9eNOSwQFD3Q7C2AKFl+uZoINaT6g+qrhSobvg1cMlu12MSUnLTki52VvmMr8m g78zWb5eUVf1vvaxG7AvmE3VyX7Htp7nqlMmoeaX8yRMtW9xfudBaPxNCDkbqn5Jo1Ne ItB8Z4qNzY4dc1E6lUzhTCrC6zai9NJFFDLoVMtSv/rmNwXCcSr8aRmRnQ6BK6ZN6DW3 DzHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=olWTGKdT1Rk7RU6hzSvSGhC/ys/x1wnsy8t7mz3TfkA=; b=cqG/kP1GgG+ScKEusmV9Uoqb0/fCE5NS9apbTiAGK5WuE1W8JTUNi+dO9WWhMPMLTI 0EMWD3PBYNAVHhpUdIct0SH6yaI00Jt+WsgawDzyvOWJM7qzOz7e2vQsHH51O5ik/n0X zx6TQWuy8DWEN9W29MdRFF/04z9W7Dxfd9xcuvBwybmEniVPytyCWaQBefJ5fELu/h39 FOUxkaKnAyZbqw0zIHOlzuBz9u5dMMCed+u5aQOKjw5DhzR+94xy+L0KpVfOP2sp+LFy QZ2DTnTTnSunB2d/amzUS5jIRrHKISZUzmw7FcwkZ70FPrr5upi0HdVTp3Aq731MOxnO Ov2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c23si1625331pli.718.2017.07.20.07.27.18; Thu, 20 Jul 2017 07:27:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755063AbdGTO1R (ORCPT + 7 others); Thu, 20 Jul 2017 10:27:17 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:38427 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755053AbdGTO1Q (ORCPT ); Thu, 20 Jul 2017 10:27:16 -0400 Received: by mail-yw0-f196.google.com with SMTP id x6so1152532ywd.5; Thu, 20 Jul 2017 07:27:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qSOcjZVIfGV9JD6YISHtC+qvroWBwDgnhxrtN6mEwcQ=; b=kz7+X3luhFa8JhDB0yzqDF5p/C18O6Qcxd6KdmQyKC93NqIvGGhLOW/XVnKw+gFIJm 4oMfXP7FaMkbhbvFBHt9uCgWk92ZpW4cnk352o70C/EAtHGsBhdUgXv9WigjHGA8iO+3 Ud5rr9RHhGKsQjOs/kXO0v9nDs8PI1jLimSprSPsgufbc9fYDkcOkqFzRt84gcqjPQkT SCH6UKi59gp+6CmeSKowWi416tQlNWyYFWkeEmp8asyDgiFMZxshAup5ayLgAmlYBvmv Cp/L9L3JlKNp9/x7PBV75qvdrJuHQi6tXzRMdDv92FfpHepKKVMk8e8Gun+6k0Xk9XNv X+YQ== X-Gm-Message-State: AIVw110kqMplHiT09Hi308JYKAsF2r3GIeMGVgjPcnM2J+oud1gdR5xk u7fjpUeE1tSbiw== X-Received: by 10.129.125.65 with SMTP id y62mr3597169ywc.76.1500560835987; Thu, 20 Jul 2017 07:27:15 -0700 (PDT) Received: from localhost.localdomain (24-223-123-72.static.usa-companies.net. [24.223.123.72]) by smtp.googlemail.com with ESMTPSA id 128sm854484ywb.98.2017.07.20.07.27.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jul 2017 07:27:15 -0700 (PDT) From: Rob Herring To: Thomas Petazzoni Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, Frank Rowand Subject: [PATCH 1/2] net: mvneta: remove bogus use of device_node.data ptr Date: Thu, 20 Jul 2017 09:27:10 -0500 Message-Id: <20170720142711.12847-1-robh@kernel.org> X-Mailer: git-send-email 2.11.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Nothing sets ever sets data, so it is always NULL. Remove it as this is the only user of data ptr in the whole kernel, and it is going to be removed from struct device_node. Cc: Thomas Petazzoni Signed-off-by: Rob Herring --- Probably there's a better fix here to actually enable the h/w buffer manager. I intend to take this thru the DT tree as patch 2 is dependent on this. Rob drivers/net/ethernet/marvell/mvneta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Signed-off-by: Gregory CLEMENT diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 0aab74c2a209..5624f4b49f9d 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -4296,8 +4296,8 @@ static int mvneta_probe(struct platform_device *pdev) /* Obtain access to BM resources if enabled and already initialized */ bm_node = of_parse_phandle(dn, "buffer-manager", 0); - if (bm_node && bm_node->data) { - pp->bm_priv = bm_node->data; + if (bm_node) { + pp->bm_priv = NULL; err = mvneta_bm_port_init(pdev, pp); if (err < 0) { dev_info(&pdev->dev, "use SW buffer management\n");