From patchwork Tue Feb 28 22:43:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 94678 Delivered-To: patch@linaro.org Received: by 10.182.3.34 with SMTP id 2csp1528131obz; Tue, 28 Feb 2017 14:50:57 -0800 (PST) X-Received: by 10.84.216.81 with SMTP id f17mr6103680plj.170.1488322257297; Tue, 28 Feb 2017 14:50:57 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y21si2933657pgh.41.2017.02.28.14.50.56; Tue, 28 Feb 2017 14:50:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbdB1Wuv (ORCPT + 7 others); Tue, 28 Feb 2017 17:50:51 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:36047 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdB1Wuu (ORCPT ); Tue, 28 Feb 2017 17:50:50 -0500 Received: by mail-ot0-f196.google.com with SMTP id i1so2568270ota.3; Tue, 28 Feb 2017 14:50:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uAZcivcoshCfzeGJWKJ2ln/5vbRcGetuYnftl5qaOqs=; b=al5/dGxi/sHeRo8q/eqkkOaSJ+eNtgSgzj1B8FjFhSH6invbDREaTIwsZna17SlxnS iA1XLYFFN6RLYJP4k+Dw3vrR0kVovzCcfyzONEVytRcsHVmiBOZQFwGx/eKE/X2jLs7X LifPyD65kaM5Y/6cL3x+Eejsjogm3dgwouCNJ0DbRpnKmWfkxFVUzvoZ6Kc5xxRA2+Hl WJRTK3wPJLcBtM2v9F/c9s2KSe1snHsKzQdlv20Md9aswodKrVA/B+A6pK7MG6ib3hup +AHlbAFKdLAkhIP9xsiZHlJQZHuH3GA69if08g/X3fWYl90pkrz5fPfkRaDOkQCz4f6E NY2Q== X-Gm-Message-State: AMke39l2oP0dg/ZZS1bxw4Ofj9z42FvHHClj1xQOqFzaTc1h7bm8L8vmLOewCfowOVhtLg== X-Received: by 10.157.17.242 with SMTP id y47mr2846994oty.52.1488321793752; Tue, 28 Feb 2017 14:43:13 -0800 (PST) Received: from rob-hp-laptop.herring.priv (66-90-148-125.dyn.grandenetworks.net. [66.90.148.125]) by smtp.googlemail.com with ESMTPSA id j128sm1203053oif.32.2017.02.28.14.43.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Feb 2017 14:43:13 -0800 (PST) From: Rob Herring To: David Gibson Cc: devicetree-compiler@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 2/3] checks: Add bus checks for simple-bus buses Date: Tue, 28 Feb 2017 16:43:09 -0600 Message-Id: <20170228224310.14162-3-robh@kernel.org> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20170228224310.14162-1-robh@kernel.org> References: <20170228224310.14162-1-robh@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add checks to identify simple-bus bus types and checks for child devices. Simple-bus type is generally identified by "simple-bus" compatible string. We also treat the root as a simple-bus, but only for child nodes with reg property. Signed-off-by: Rob Herring --- v2: - new patch checks.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) -- 2.10.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/checks.c b/checks.c index 5ed91ac50a10..c4865b4c8da0 100644 --- a/checks.c +++ b/checks.c @@ -817,6 +817,72 @@ static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct no } WARNING(pci_device_reg, check_pci_device_reg, NULL, ®_format); +static const struct bus_type simple_bus = { + .name = "simple-bus", +}; + +static bool node_is_compatible(struct node *node, const char *compat) +{ + struct property *prop; + const char *str; + + prop = get_property(node, "compatible"); + if (!prop) + return false; + + for (str = prop->val.val; str < prop->val.val + prop->val.len; str += strlen(str) + 1) { + if (streq(str, compat)) + return true; + } + return false; +} + +static void check_simple_bus_bridge(struct check *c, struct dt_info *dti, struct node *node) +{ + if (node_is_compatible(node, "simple-bus") || !node->parent) + node->bus = &simple_bus; +} +WARNING(simple_bus_bridge, check_simple_bus_bridge, NULL, &addr_size_cells); + +static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct node *node) +{ + struct property *prop; + const char *unitname = get_unitname(node); + char unit_addr[17]; + unsigned int size; + uint64_t reg = 0; + cell_t *cells = NULL; + + if (!node->parent || (node->parent->bus != &simple_bus)) + return; + + prop = get_property(node, "reg"); + if (prop) + cells = (cell_t *)prop->val.val; + else { + prop = get_property(node, "ranges"); + if (prop && prop->val.len) + /* skip of child address */ + cells = ((cell_t *)prop->val.val) + node_addr_cells(node); + } + + if (!cells) { + if (node->parent->parent && !(node->bus == &simple_bus)) + FAIL(c, dti, "Node %s missing or empty reg/ranges property", node->fullpath); + return; + } + + size = node_addr_cells(node->parent); + while (size--) + reg = (reg << 32) | fdt32_to_cpu(*(cells++)); + + snprintf(unit_addr, sizeof(unit_addr), "%lx", reg); + if (!streq(unitname, unit_addr)) + FAIL(c, dti, "Node %s simple-bus unit address format error, expected \"%s\"", + node->fullpath, unit_addr); +} +WARNING(simple_bus_reg, check_simple_bus_reg, NULL, ®_format, &simple_bus_bridge); + /* * Style checks */ @@ -893,6 +959,9 @@ static struct check *check_table[] = { &pci_device_reg, &pci_device_bus_num, + &simple_bus_bridge, + &simple_bus_reg, + &avoid_default_addr_size, &obsolete_chosen_interrupt_controller,