From patchwork Mon Mar 8 03:52:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 395662 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F05C433DB for ; Mon, 8 Mar 2021 04:06:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F093650BF for ; Mon, 8 Mar 2021 04:06:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234110AbhCHEGS (ORCPT ); Sun, 7 Mar 2021 23:06:18 -0500 Received: from mail-eopbgr70044.outbound.protection.outlook.com ([40.107.7.44]:24274 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232464AbhCHEGA (ORCPT ); Sun, 7 Mar 2021 23:06:00 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F7Tn1OZmAPRkG7GQsiLdwfDnzY0/S0a6Ruezr/uVu3sK6jr0UxGHFHrfAlPU140wL/h+RlFtBIYW5S4wHwuYLXLGl+qTI8pq9+/sK5/7GUd+TpaEUsDmp6JnDjiwxbyFjK97IjC93T+Yvuh2S2SyeQQ+gfLy4qh07KNQq2AlFRHGPt5z6LaouxFDBIKZqKMoBJHumJqUlu7sQMNrxQr7kFnRi97DsITrqvQFp7d3SFnYpOglJWOeAF20fNUB1DhELxVlS5Vp3gYnV0PZ8lrsJpslgthqm1tcEolkVskCh8JYojn4eOwKO4cvI7tyLmWTkRK4CIqNyk50SC/2aoSOeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cbInIKlOtjX3/3zhPTADoSmdAO/icXL/ZHMPb5qQbSs=; b=kSoFYlviz4rFpX8+TZmjknzikW/50am144zLsgR1srTaDXRKUeScFr7K7s/yi6TjpH8Hy1LP3T5k/kIDQjpFrFbof7+NM1E/3DGor02RwBPF+Is4umi8+LKfwRHy3hnEzRQgS5qvat8bCJ4oKyiypvuM4UPCGj58muHoOjK+r8/qFTGC/elQ/UIMq/gjnKmfypKKyjRosAPXPc6B1cXNEHGShO1VCeHI4L4TB/p3ukEtKq0+sq762aXN+M8WCLyB3CwyJ0m8szMBRlc73+RkeNm/EdoyNh7PcJ5Ec6+1lF9BpotJwoxHBweiuZtLZZn5xSnLW8wIfNxRZMBAEweGSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cbInIKlOtjX3/3zhPTADoSmdAO/icXL/ZHMPb5qQbSs=; b=pkoCK6puUp3doWzUj712VNukFZISV92ZA2jF7SZNTbVIOyV6Vj3lnYKE16TNNxUA5SKZiw9w1UtiAioIat2RiDlZ9E3juYSRv6lYZweyiKLi5pRTkJTrxQSu2mBIEMmqfyUfLANJUzIlMZocPk8wF0Dn/k3bwEn+MwpfUi9XvoA= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB3983.eurprd04.prod.outlook.com (2603:10a6:803:4c::16) by VI1PR04MB3310.eurprd04.prod.outlook.com (2603:10a6:802:11::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.27; Mon, 8 Mar 2021 04:05:49 +0000 Received: from VI1PR04MB3983.eurprd04.prod.outlook.com ([fe80::2564:cacc:2da5:52d0]) by VI1PR04MB3983.eurprd04.prod.outlook.com ([fe80::2564:cacc:2da5:52d0%5]) with mapi id 15.20.3912.027; Mon, 8 Mar 2021 04:05:49 +0000 From: Liu Ying To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Cc: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org, a.hajda@samsung.com, narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org, robert.chiras@nxp.com, martin.kepplinger@puri.sm, robert.foss@linaro.org Subject: [PATCH v4 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable() Date: Mon, 8 Mar 2021 11:52:17 +0800 Message-Id: <1615175541-29009-2-git-send-email-victor.liu@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1615175541-29009-1-git-send-email-victor.liu@nxp.com> References: <1615175541-29009-1-git-send-email-victor.liu@nxp.com> X-Originating-IP: [119.31.174.66] X-ClientProxiedBy: HK2PR04CA0088.apcprd04.prod.outlook.com (2603:1096:202:15::32) To VI1PR04MB3983.eurprd04.prod.outlook.com (2603:10a6:803:4c::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by HK2PR04CA0088.apcprd04.prod.outlook.com (2603:1096:202:15::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3912.17 via Frontend Transport; Mon, 8 Mar 2021 04:05:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2173e023-d69e-4ab9-42dc-08d8e1e7752d X-MS-TrafficTypeDiagnostic: VI1PR04MB3310: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nc0oFr73I43rJKLus7DfC9hDZEYU2acT/o8FLanAjubROqcICtK8tVdpDqxhFLRxdTSDkMsn1jEgpulXAXEjrjyTbWqSWyHzWYa4XDz3cLnkVPjMwskI0C7zIK86fDkNe+4EkbFWZm5/p8Vfxe8FkWr79+UqI/ia/NQQRPzcRdOKfLR0x7Bp0ge2lZ8sxyoLEtqMvKmHhDZS+aJeVzffSrlkLAoHwN9hptpCRXqjdpGgoy2vpP/t+CFTsGuyB8tCsSJpFNjCCrGlNAhjYHzKS93wbTDL2e8pT+vZDsJ+U0i07IoW1pQZOaP8miEupum0Xkl2mZHvcQQhcvrniv5GV1Wt/Ml1v1cDbCLOrKyF8UDahvxloQbDOqSQ+G1IqXv+6mRnYuwFaqp72pW46lKEoTk51vktD9P0wR/Axzgrz63AJWG9O+2h6iYCdsK/TVFxHuz8A2OiLgUmdMJ9zgZXXy3KYGieyTA5ja70HMjYIrufYK063QgJa7hXQ40/3mchq5HTgwXqTkHP008GJtVjqw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3983.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(136003)(396003)(366004)(346002)(66556008)(186003)(16526019)(478600001)(66946007)(2906002)(316002)(66476007)(26005)(5660300002)(52116002)(8936002)(6666004)(6486002)(36756003)(8676002)(6512007)(7416002)(4326008)(956004)(6506007)(2616005)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?4RAJe5GbSgvhJ38ezXblOpo0KU4?= =?utf-8?q?Om98z8VmpqlECunIs1jZqpzVnEm0Csj369DRa0Z4hBZEFskmyPzHyELo?= =?utf-8?q?0yD4M4w8ZGMB8vXpSmCOFvShObDso4l+QHJs5qtwifqIxMGkm0I3XMQh?= =?utf-8?q?pBQIM70OpKjxkS5IAb3fEKAJwPL07l737c/H8OLTe3+hAMOsKBrvlgil?= =?utf-8?q?n6LwUpOxznP/V8lNinIs5ckZ4+XdZ1OqOzPjSWiManzizo4aDcPSrxj7?= =?utf-8?q?Mp8Fd5Qy/WfGyavwOXIQExzUGxwEwz0KXExssUpxR2TYwvK4t/68w/0a?= =?utf-8?q?Kt6Unug/v942l5aGhs0Nj/d99SktCUiByJweYIb/0zqqej8Hf9hwu0Bs?= =?utf-8?q?+0T4X5G+bNjobpivjQrJupc3mOHNBNrBWuPDfA5faIuno9qPXqtmaDJ2?= =?utf-8?q?4cnkjfjfbIWQgWr1Sk99hXF6px3SOIgWD81q8kUHvinBXTlP7DTCU3+p?= =?utf-8?q?e+shRvwzCxR+iQm7Z7dbw044yL8W9XMs1uqPFHSTL1SpoVYiIZAAnpK/?= =?utf-8?q?9hAO7MitFfGnSJQoilQHI9lQQiiT1FnJuwnxqalGDHLb+T/DgVYLNLMi?= =?utf-8?q?qRUBTth9eDbr7i8gqmsHUp06toUtH6hsBOd4c/rFUgx0FjDRJDiKuUXq?= =?utf-8?q?oi9GMyE0A1cXBlpz9JtNXXoUJhr2PfVSVg+6RaDhT5TJKtFEB83LgBvi?= =?utf-8?q?bOUR/L2HuAeLBnOGCEN9Z51xr2ZwhQPqV0/RRtYvuuhttGDjJayKauQA?= =?utf-8?q?lsMt5GboptSlgLP282o+n3p/QpdckpnK0Pyu6QgqtzMKYRre7GRyHYDt?= =?utf-8?q?E7aT5a9oOB5SiIUXhnw7fkMVfT8C8Pasl9c2Y/axf442fBbPezDhNR7R?= =?utf-8?q?qLtup1f9tXVDIpuhK43nyrhRJ9tM+/P0pcGYS02hU/YiRLcysJoXpZEB?= =?utf-8?q?6s3gDoj6oDsZeHlDIx1K7yqiNqdyE5UQYBkOTA1AVLNkyO5lKMQl7Aib?= =?utf-8?q?qubHSI2oqceS1Nx/230BrRmwK6IwgrB+kwqj5upl3nWZ5Jsv0BBRyN32?= =?utf-8?q?ViDimR4J/AjC5Qw9to1KqOG2mHlnDS/8wSgIOyfSHtapMr5S13zUtuNo?= =?utf-8?q?aqCHqS7slLCiMr8cE3mG7eSMEIjhzA6+g6o31W/Rq4uUEO6NQASYTuvz?= =?utf-8?q?9/MVZEOOAr3RfZd9fArDuntMcN76A5LOjmUl+GcyQKnkf7P0l8K3u0CG?= =?utf-8?q?coz/joiuG6i5rrQuBftJF0NWu+yqKnHtrfSHj+VqjQMtK8kqWFp6KSiY?= =?utf-8?q?491YDCqBm9QrBkNNORi2oiJZOArwhK9sae6+KoKSt4XD0XjDJ9rw7BNy?= =?utf-8?q?v15JHjf/mhMsdJ15yW+UwVhe/L0nP?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2173e023-d69e-4ab9-42dc-08d8e1e7752d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3983.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 04:05:49.4639 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9+eSgLRCf9JFYpvGAG2DTNVEwSvV/TD5QPhBWSy5VJR9HCrx6ptOES9ic04sdYX3lToOyhK+Ew9OK2EC/00odg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3310 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp works with a Mixel MIPI DPHY + LVDS PHY combo to support either a MIPI DSI display or a LVDS display. So, this patch calls phy_set_mode() from nwl_dsi_enable() to set PHY mode to MIPI DPHY explicitly. Cc: Guido Günther Cc: Robert Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v3->v4: * No change. v2->v3: * No change. v1->v2: * Add Guido's R-b tag. drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index 66b6740..be6bfc5 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -678,6 +678,12 @@ static int nwl_dsi_enable(struct nwl_dsi *dsi) return ret; } + ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY); + if (ret < 0) { + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret); + goto uninit_phy; + } + ret = phy_configure(dsi->phy, phy_cfg); if (ret < 0) { DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);