diff mbox series

[v6,11/11] mfd: mt6360: Remove MT6360 regulator of_compatible attribute

Message ID 1604656432-10215-12-git-send-email-gene.chen.richtek@gmail.com
State New
Headers show
Series mfd: mt6360: Merge different sub-devices I2C read/write | expand

Commit Message

Gene Chen Nov. 6, 2020, 9:53 a.m. UTC
From: Gene Chen <gene_chen@richtek.com>

Remove MT6360 regulator of_compatible attribute because
MFD device should just instantiate the platform device.

Signed-off-by: Gene Chen <gene_chen@richtek.com>
---
 drivers/mfd/mt6360-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lee Jones Nov. 11, 2020, 4:47 p.m. UTC | #1
On Fri, 06 Nov 2020, Gene Chen wrote:

> From: Gene Chen <gene_chen@richtek.com>

> 

> Remove MT6360 regulator of_compatible attribute because

> MFD device should just instantiate the platform device.

> 

> Signed-off-by: Gene Chen <gene_chen@richtek.com>

> ---

>  drivers/mfd/mt6360-core.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c

> index 4bcfa7f..539ab43 100644

> --- a/drivers/mfd/mt6360-core.c

> +++ b/drivers/mfd/mt6360-core.c

> @@ -340,7 +340,7 @@ static const struct mfd_cell mt6360_devs[] = {

>  	OF_MFD_CELL("mt6360-led", mt6360_led_resources,

>  		    NULL, 0, 0, "mediatek,mt6360-led"),

>  	OF_MFD_CELL("mt6360-regulator", mt6360_regulator_resources,

> -		    NULL, 0, 0, "mediatek,mt6360-regulator"),

> +		    NULL, 0, 0, NULL),


If you're no longer providing an OF compatible, you should use one of
the simper helpers.

>  	OF_MFD_CELL("mt6360-tcpc", NULL,

>  		    NULL, 0, 0, "mediatek,mt6360-tcpc"),

>  };


-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
diff mbox series

Patch

diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
index 4bcfa7f..539ab43 100644
--- a/drivers/mfd/mt6360-core.c
+++ b/drivers/mfd/mt6360-core.c
@@ -340,7 +340,7 @@  static const struct mfd_cell mt6360_devs[] = {
 	OF_MFD_CELL("mt6360-led", mt6360_led_resources,
 		    NULL, 0, 0, "mediatek,mt6360-led"),
 	OF_MFD_CELL("mt6360-regulator", mt6360_regulator_resources,
-		    NULL, 0, 0, "mediatek,mt6360-regulator"),
+		    NULL, 0, 0, NULL),
 	OF_MFD_CELL("mt6360-tcpc", NULL,
 		    NULL, 0, 0, "mediatek,mt6360-tcpc"),
 };