From patchwork Fri Aug 7 10:25:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kunihiko Hayashi X-Patchwork-Id: 247549 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp2312676ilo; Fri, 7 Aug 2020 03:25:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymIdjFKytXg+1YIf0/ibhDLd3sM4UbVDD1SNQQPjIdqxrMcvIaPyz7yOvNYcLcnlOTvIUL X-Received: by 2002:a05:6402:1591:: with SMTP id c17mr8057419edv.111.1596795945265; Fri, 07 Aug 2020 03:25:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596795945; cv=none; d=google.com; s=arc-20160816; b=WDiJ/3N87fjuBFO6FZtfOa+RYFt4R083AuJmKfFR5hn+0fRepoHEfQaxOPpBzW3S0X w9n5gNNFQijKbpHxuq4mdnO2xROIIwCzCmP3ecgNp3X9ph2vK/xqIoC8X7mLj2wuHkCo z0terGKT56qJX3+tkKHIO8DV+EXPH9Gi5W2gpMlpsRKrIk+EBqyFKglbYkIDJUdvLG5d 74jiYc6jJIMhtNTAsW/vGP8Q7HBE1IWrMP+QF1I4GC7WL1NLRdX7csifo+0ufFT3RsN5 ykdIb17URpSgAatRxKXhLg0jMMkJ7mQKi0ik0UUDxMBkrJ2RgTzwsdNXf12yz5uIqiKo Ny5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=+2Ec5nXE5woyOr+PT30xk9G1oL45h7/1HbB536dKeZs=; b=YrrhRV/blm9KOuRt7Bto1y3OXjNblft5q/+a8VyjFJ7bJlrNbT5XpyYXtg6J7UpOAj ENYHVlia4vdQTVVvmJGk+ZsKo+mQWYoCkilXY3IgSQ8Jpe5jxo2qempfpivtr42K57AV YNqf5c3ZCiY4YoBZkJIYXsjJgoYswG3J/WzD0HlGkN/cBeU6ddzJtAtDI8il40PdGo+1 0x7WEseD/Y8pya0+uiUXTvSV04Cm4jF9NCO+96OcmG1vEmvLVBgtV00BmcD+1wgxY/Ar pUXMUDF9b75xMdDYmQdHzO/zMmLf/igl2+6M4LvLKcrnWPlXVUkkDRGygYVGNOqa9GOg PSzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u18si4950721ejr.700.2020.08.07.03.25.45; Fri, 07 Aug 2020 03:25:45 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727037AbgHGKZn (ORCPT + 6 others); Fri, 7 Aug 2020 06:25:43 -0400 Received: from mx.socionext.com ([202.248.49.38]:31600 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728292AbgHGKZh (ORCPT ); Fri, 7 Aug 2020 06:25:37 -0400 Received: from unknown (HELO kinkan-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 07 Aug 2020 19:25:35 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by kinkan-ex.css.socionext.com (Postfix) with ESMTP id A65EF180BB5; Fri, 7 Aug 2020 19:25:35 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Fri, 7 Aug 2020 19:25:35 +0900 Received: from plum.e01.socionext.com (unknown [10.213.132.32]) by kinkan.css.socionext.com (Postfix) with ESMTP id 28C4C1A0507; Fri, 7 Aug 2020 19:25:35 +0900 (JST) From: Kunihiko Hayashi To: Lorenzo Pieralisi , Bjorn Helgaas , Jingoo Han , Gustavo Pimentel , Rob Herring , Masahiro Yamada , Marc Zyngier Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Jassi Brar , Kunihiko Hayashi Subject: [PATCH v6 6/6] PCI: uniphier: Add error message when failed to get phy Date: Fri, 7 Aug 2020 19:25:22 +0900 Message-Id: <1596795922-705-7-git-send-email-hayashi.kunihiko@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596795922-705-1-git-send-email-hayashi.kunihiko@socionext.com> References: <1596795922-705-1-git-send-email-hayashi.kunihiko@socionext.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Even if phy driver doesn't probe, the error message can't be distinguished from other errors. This displays error message caused by the phy driver explicitly. Signed-off-by: Kunihiko Hayashi --- drivers/pci/controller/dwc/pcie-uniphier.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.7.4 Reviewed-by: Rob Herring diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c index 93ef608..7c8721e 100644 --- a/drivers/pci/controller/dwc/pcie-uniphier.c +++ b/drivers/pci/controller/dwc/pcie-uniphier.c @@ -489,8 +489,12 @@ static int uniphier_pcie_probe(struct platform_device *pdev) return PTR_ERR(priv->rst); priv->phy = devm_phy_optional_get(dev, "pcie-phy"); - if (IS_ERR(priv->phy)) - return PTR_ERR(priv->phy); + if (IS_ERR(priv->phy)) { + ret = PTR_ERR(priv->phy); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get phy (%d)\n", ret); + return ret; + } platform_set_drvdata(pdev, priv);