From patchwork Thu Jun 18 08:38:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kunihiko Hayashi X-Patchwork-Id: 191091 Delivered-To: patch@linaro.org Received: by 2002:a54:30ca:0:0:0:0:0 with SMTP id e10csp1126012ecs; Thu, 18 Jun 2020 01:39:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfS9Kun7yezbC0utU/WSod3hvgfOm9mSsqoFck+6Kzrg+A4J6Cz6cF1EQLO4LQYN5wWdvz X-Received: by 2002:a17:906:1d52:: with SMTP id o18mr2687738ejh.399.1592469543814; Thu, 18 Jun 2020 01:39:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592469543; cv=none; d=google.com; s=arc-20160816; b=ItfESFgxWs53IAzBcUdZaUzOuUvZj03TbMwlcQEGOz3QnGdl2cVJZevDGl+QNzv9NN jgd6NTIjADNGL1I7uvmmUolnJinmbpqXDDS4Km4Zdz1belwQB747dDIH/80woPffEyfX F+ZnkTRnx456E0gjyDeRb4mN3rz3L3dvNPGG+O+qdOHRe2+slU7HT/cVOg1Q8rln5luj 7uTi7Tf/o5yftT6gr51IxqJkanwdTs6nwN95tI5U4MG/HqDblMz2UFJqoQAkvk8/oCRi CZMxTeGXmXIpm7uOVgwbpcY/myovZUq2Gi322RxBFlmmyRmIgcfvxwsmHtVrxsglrQ8f JXIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=AqLr77e+YiK8+HVwWmuG9SWDToMvkIOUFQNYa7obawA=; b=jHNzPK88RpOHiwnoOkAba9qtzbWrLiYO8JHmPbwWFmOii9zdWd6m0TKGCstnQWs3o8 /9Mcint/ubSZW95o1dFwulFB+z3eJIFvthdxB9UCqlElpj/JZHwXjFuoh1Eg8seEZVOY z4SKAJnCCbZEtAl+8syjM9g/Wt1D2LmLsyvmJtK5q8H6Ra2nZWZ4qnO+YMOULxEyv/ge ibnyIIL6gmOnSy/PbPPZCHFpX+Ry6XmMigxmipAwowBTFonTfJz+lHAkbrUnN6hwGDkt fYnOPNb4wTMrYyiKRobalz2wMZrLOxMosWoFcI9cWlud4mwttlhrlwWBEgV0ecm3MAgy BB2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si1490925ejd.215.2020.06.18.01.39.03; Thu, 18 Jun 2020 01:39:03 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728890AbgFRIjC (ORCPT + 6 others); Thu, 18 Jun 2020 04:39:02 -0400 Received: from mx.socionext.com ([202.248.49.38]:19368 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728825AbgFRIi2 (ORCPT ); Thu, 18 Jun 2020 04:38:28 -0400 Received: from unknown (HELO kinkan-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 18 Jun 2020 17:38:27 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by kinkan-ex.css.socionext.com (Postfix) with ESMTP id 75A22180B51; Thu, 18 Jun 2020 17:38:27 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Thu, 18 Jun 2020 17:38:27 +0900 Received: from plum.e01.socionext.com (unknown [10.213.132.32]) by kinkan.css.socionext.com (Postfix) with ESMTP id 1A10B1A12AD; Thu, 18 Jun 2020 17:38:27 +0900 (JST) From: Kunihiko Hayashi To: Bjorn Helgaas , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Rob Herring , Masahiro Yamada , Marc Zyngier Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Jassi Brar , Kunihiko Hayashi Subject: [PATCH v5 5/6] PCI: uniphier: Add error message when failed to get phy Date: Thu, 18 Jun 2020 17:38:12 +0900 Message-Id: <1592469493-1549-6-git-send-email-hayashi.kunihiko@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1592469493-1549-1-git-send-email-hayashi.kunihiko@socionext.com> References: <1592469493-1549-1-git-send-email-hayashi.kunihiko@socionext.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Even if phy driver doesn't probe, the error message can't be distinguished from other errors. This displays error message caused by the phy driver explicitly. Signed-off-by: Kunihiko Hayashi --- drivers/pci/controller/dwc/pcie-uniphier.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c index c37a968..8356dd3 100644 --- a/drivers/pci/controller/dwc/pcie-uniphier.c +++ b/drivers/pci/controller/dwc/pcie-uniphier.c @@ -470,8 +470,12 @@ static int uniphier_pcie_probe(struct platform_device *pdev) return PTR_ERR(priv->rst); priv->phy = devm_phy_optional_get(dev, "pcie-phy"); - if (IS_ERR(priv->phy)) - return PTR_ERR(priv->phy); + if (IS_ERR(priv->phy)) { + ret = PTR_ERR(priv->phy); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get phy (%d)\n", ret); + return ret; + } platform_set_drvdata(pdev, priv);