From patchwork Tue May 9 02:49:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 98863 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp1616790qge; Mon, 8 May 2017 19:51:18 -0700 (PDT) X-Received: by 10.99.101.130 with SMTP id z124mr21708753pgb.8.1494298278798; Mon, 08 May 2017 19:51:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494298278; cv=none; d=google.com; s=arc-20160816; b=mUZ0AXieNfBHMUC8pFXzEvdraDMo5mYOh2yRK6naskADfkFs5NnTnSsjisp98kn5se 5wuJsQjAQ37U3om0dh9mQ78l2iFoWRYHzuEywyTt/4U/JdX21H4UcnyWmt8gQLOpqFmx /K7DSAe6PigYaY9RzvYsEbolqh7gkAkapriZjCdhwRGJ8lm7/uCKpMJ6z7O5R6jA9YxJ 3sfg5oN43osAO5XpsR3ebdDsaUmyMk98Ag/N9tfSG0Hz14CRZqSmwyVOK70T+Jsa9h/x A4dP7ziPRCzZ1N6u9bx9wVJEo30AJDluvD7EWtFVFW9tOHcnlLCdUQMj1rIFpQ1MgXX+ GI9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=PnpN8Va5xDrvbAb6sO2mTuizYThuGNG8c3U1vVTHVw8=; b=I716G9tmE0fiDjew1ZvkYgo7dIH7bel+rI/LWPiH8HMAop524WqHbcqowEi/OMTxhN RmynI1OGHki+/BPTW3ddqYImsgV4O6O5kgJ8si5KQoTa4SY4pKvOxItOtnx4fPN+D8g9 3lVmuk9FW0XoBVPbjm2wM8Syj/2CIvag9oul8GkpHumsPdcTldJdxIYBU00arTyeHFAI IHdGyS6Cz4nqVY9GgR9GFMBo0hUeaJwlSuYaVLEybY6Phs4OoSbgfXdbRLhU4mpsJ1xL oAZXet/WxrbMYYcCi/vk41qji0yDi+KSQwcM3wcmT4PW2N9VmO4gEm1oQRxhxXCcNVHk OCrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n17si15254207pfj.260.2017.05.08.19.51.18; Mon, 08 May 2017 19:51:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755061AbdEICvK (ORCPT + 7 others); Mon, 8 May 2017 22:51:10 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36168 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659AbdEICvI (ORCPT ); Mon, 8 May 2017 22:51:08 -0400 Received: by mail-pf0-f170.google.com with SMTP id m17so12803639pfg.3 for ; Mon, 08 May 2017 19:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KPg79NY3sGvLdvwjFFRlkg3unWx7G4i/7+aegEzxzF8=; b=WEjp4b2J3kiT59Wo7WK9YyPotimTQtlc4x1G90cluCy5QJdZz/UeZS98Qm3eE6uEH6 POMNWcwutlxkzsAygOOiFWyu68uqXvUPqSxVGWNkDvjdHw4/Qw1txGRoWp8TRqqhA098 loAOQ8PYejG7/vTwYGwTyFcpXVKjq/QRlcW2Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KPg79NY3sGvLdvwjFFRlkg3unWx7G4i/7+aegEzxzF8=; b=g9DGa49gMmT8TdLi7t3++sOq88Ql/BwBJ3DNMYbLWsdSjj2xXZrvmQdRwHtDxWskBa aSHN7QH38UjsvMynWZly9f+7mWCAEJgPbQIBfGcw7a0hGqS3fQZFioAGbRARnRZdgtPK 4W/8ombG29VkhtqT4xpD1Io8ofrtsGDVRT6xPM/pWAowdClSSdqTBnGI0t1TaoKhANiL sVQR7NiSq0OFo4TyUKBZt0N3e+FcKcKxD1Zu+km8XAOG1NLLqvpqdY3XC2qLrWmubVaW CynAy92eS2+U39zRBBloTgeTxCTjKPeh35pAnz807aPKrvRM6q1xy+uTURn2XIpeOVvn yp4w== X-Gm-Message-State: AODbwcDbuuG1ojcfzzaO6qcbXok5iHfhEh0SN2eKvsW97gPT/+14Tzg7 1jhhPOShNN0Kx2C1 X-Received: by 10.98.23.74 with SMTP id 71mr14045240pfx.30.1494298268128; Mon, 08 May 2017 19:51:08 -0700 (PDT) Received: from localhost.localdomain (li1627-128.members.linode.com. [172.104.47.128]) by smtp.gmail.com with ESMTPSA id 20sm35326370pfq.42.2017.05.08.19.50.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 08 May 2017 19:51:06 -0700 (PDT) From: Leo Yan To: Jonathan Corbet , Mathieu Poirier , Rob Herring , Mark Rutland , Wei Xu , Catalin Marinas , Will Deacon , Andy Gross , David Brown , Greg Kroah-Hartman , Suzuki K Poulose , Stephen Boyd , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Mike Leach , Sudeep Holla Cc: Leo Yan Subject: [PATCH v9 5/9] coresight: of_get_coresight_platform_data: Add missing of_node_put Date: Tue, 9 May 2017 10:49:58 +0800 Message-Id: <1494298202-6739-6-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1494298202-6739-1-git-send-email-leo.yan@linaro.org> References: <1494298202-6739-1-git-send-email-leo.yan@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Suzuki K Poulose The of_get_coresight_platform_data iterates over the possible CPU nodes to find a given cpu phandle. However it does not drop the reference to the node pointer returned by the of_get_coresight_platform_data. This patch also introduces another minor fix is to use of_cpu_device_node_get() to replace of_get_cpu_node(). Cc: Mathieu Poirier Reviewed-by: Suzuki K Poulose Signed-off-by: Suzuki K Poulose [Leo: minor tweaks for of_get_coresight_platform_data] Signed-off-by: Leo Yan --- drivers/hwtracing/coresight/of_coresight.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c index 2749853..225b2dd 100644 --- a/drivers/hwtracing/coresight/of_coresight.c +++ b/drivers/hwtracing/coresight/of_coresight.c @@ -109,7 +109,8 @@ of_get_coresight_platform_data(struct device *dev, struct coresight_platform_data *pdata; struct of_endpoint endpoint, rendpoint; struct device *rdev; - struct device_node *dn; + bool found; + struct device_node *dn, *np; struct device_node *ep = NULL; struct device_node *rparent = NULL; struct device_node *rport = NULL; @@ -176,17 +177,19 @@ of_get_coresight_platform_data(struct device *dev, } while (ep); } - /* Affinity defaults to CPU0 */ - pdata->cpu = 0; dn = of_parse_phandle(node, "cpu", 0); - for (cpu = 0; dn && cpu < nr_cpu_ids; cpu++) { - if (dn == of_get_cpu_node(cpu, NULL)) { - pdata->cpu = cpu; + for_each_possible_cpu(cpu) { + np = of_cpu_device_node_get(cpu); + found = (dn == np); + of_node_put(np); + if (found) break; - } } of_node_put(dn); + /* Affinity to CPU0 if no cpu nodes are found */ + pdata->cpu = found ? cpu : 0; + return pdata; } EXPORT_SYMBOL_GPL(of_get_coresight_platform_data);