From patchwork Sat Jan 7 11:04:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu YiPing X-Patchwork-Id: 90274 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp71708qgi; Sat, 7 Jan 2017 03:04:46 -0800 (PST) X-Received: by 10.84.178.7 with SMTP id y7mr287623plb.60.1483787086835; Sat, 07 Jan 2017 03:04:46 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12si82651263plg.84.2017.01.07.03.04.46; Sat, 07 Jan 2017 03:04:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032106AbdAGLEp (ORCPT + 7 others); Sat, 7 Jan 2017 06:04:45 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:6800 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032100AbdAGLEo (ORCPT ); Sat, 7 Jan 2017 06:04:44 -0500 Received: from 172.24.1.137 (EHLO szxeml431-hub.china.huawei.com) ([172.24.1.137]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DTB95079; Sat, 07 Jan 2017 19:04:38 +0800 (CST) Received: from vm167-7.huawei.com (10.177.167.7) by szxeml431-hub.china.huawei.com (10.82.67.208) with Microsoft SMTP Server id 14.3.235.1; Sat, 7 Jan 2017 19:04:27 +0800 From: YiPing Xu To: , , , , , Subject: [PATCH] of: remove redundant memset in overlay Date: Sat, 7 Jan 2017 19:04:27 +0800 Message-ID: <1483787067-108430-1-git-send-email-xuyiping@hisilicon.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [10.177.167.7] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.5870CB47.019B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 7f8d3dbbe01443c4d9f87c0a5552ff2b Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: XuYing memset in of_build_overlay_info is redundant, the ovinfo has been zeroed in of_fill_overlay_info when error. Signed-off-by: YiPing Xu --- drivers/of/overlay.c | 1 - 1 file changed, 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Frank Rowand diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 0d4cda7..4b1b6b3 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -314,7 +314,6 @@ static int of_build_overlay_info(struct of_overlay *ov, cnt = 0; for_each_child_of_node(tree, node) { - memset(&ovinfo[cnt], 0, sizeof(*ovinfo)); err = of_fill_overlay_info(ov, node, &ovinfo[cnt]); if (err == 0) cnt++;