From patchwork Tue Apr 5 22:56:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanimir Varbanov X-Patchwork-Id: 65148 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp730943lbc; Tue, 5 Apr 2016 15:58:21 -0700 (PDT) X-Received: by 10.98.0.202 with SMTP id 193mr33092572pfa.120.1459897098204; Tue, 05 Apr 2016 15:58:18 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ot4si10441257pab.169.2016.04.05.15.58.17; Tue, 05 Apr 2016 15:58:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760204AbcDEW5i (ORCPT + 7 others); Tue, 5 Apr 2016 18:57:38 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:33025 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760196AbcDEW5f (ORCPT ); Tue, 5 Apr 2016 18:57:35 -0400 Received: by mail-wm0-f46.google.com with SMTP id f198so50568667wme.0 for ; Tue, 05 Apr 2016 15:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nrltqaL4Lfccs8XQgWc5v2xW9Tj9ltknjgUfWwbjjEs=; b=EByU60gjECumjOS2K4S/ZdX02eDvlhSzvjUwVYv2Av6BHTNaZ/UpCvk8Vc/K06oFgv tbgzEGE99b1F+f8rdm5Z9XXXY38VJJX3z2l5N9Pnk9XdZZm9FKKckEgft8pfFMF1xiuj 8GicPjFmp6/lnussnxqPym6CP9zUs992q+dh4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nrltqaL4Lfccs8XQgWc5v2xW9Tj9ltknjgUfWwbjjEs=; b=ifbyxSFFTCxuajnHFya5BEdHu4vjFWHVb1QLLWuEC3Bfk+qb6Aokq+3IsNecA1Ts9h 7Qov3gwAacKfafH8dyJTwEZ+qHz1AaQlUUDCOQWh6WNkJ/ect8maHlDnvX6tsO38dXaf 7babpgkIJ1SNFuU7gmDcXRRuflUIt5i52vEgB9YVyqsu7FxioHfmZKITO55QuNqCDSYM +eM8UAZ1Nqth1srCqEQDQET2vSdAprNZuVZhUkaVXcW7ODPonYOT0gvIZSwp08PxF1rY KzID/I+VKVrhj4A8H/pz8nYbNMvly5lYWbdLTC9XWAyby8S+zvaHZ9heEU9Csy1xcLde 0QuQ== X-Gm-Message-State: AD7BkJJSEmyq2HHwG8uQQkW1u5vsQLOEpRzwkfIpaIVXLEIEekMI3QBclCePk2SWbfudVJAW X-Received: by 10.194.86.202 with SMTP id r10mr28916478wjz.113.1459897048470; Tue, 05 Apr 2016 15:57:28 -0700 (PDT) Received: from localhost.localdomain (hst-221-11.medicom.bg. [84.238.221.11]) by smtp.gmail.com with ESMTPSA id n3sm21914wja.6.2016.04.05.15.57.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Apr 2016 15:57:27 -0700 (PDT) From: Stanimir Varbanov To: Rob Herring , Mark Rutland , Vinod Koul , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Sinan Kaya , Pramod Gurav , Stanimir Varbanov Subject: [PATCH v2 4/5] dmaengine: qcom: bam_dma: use correct pipe FIFO size Date: Wed, 6 Apr 2016 01:56:21 +0300 Message-Id: <1459896982-30171-5-git-send-email-stanimir.varbanov@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459896982-30171-1-git-send-email-stanimir.varbanov@linaro.org> References: <1459896982-30171-1-git-send-email-stanimir.varbanov@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The pipe fifo size register must instruct the bam hw how many hw descriptors can be pushed to fifo. Currently we isntruct the hw with 32KBytes but wrap the tail in bam_start_dma in BAM_P_EVNT_REG on 4095 i.e. 32760. This leads to stalled transactions when the tail wraps. Fix this by use the correct fifo size in BAM_P_FIFO_SIZES register i.e. 32K - 8. Signed-off-by: Stanimir Varbanov --- drivers/dma/qcom/bam_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index d0f878a78fae..7e5ad1c25e21 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -459,7 +459,7 @@ static void bam_chan_init_hw(struct bam_chan *bchan, */ writel_relaxed(ALIGN(bchan->fifo_phys, sizeof(struct bam_desc_hw)), bam_addr(bdev, bchan->id, BAM_P_DESC_FIFO_ADDR)); - writel_relaxed(BAM_DESC_FIFO_SIZE, + writel_relaxed(BAM_MAX_DATA_SIZE, bam_addr(bdev, bchan->id, BAM_P_FIFO_SIZES)); /* enable the per pipe interrupts, enable EOT, ERR, and INT irqs */