From patchwork Tue Mar 29 11:27:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 64591 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1949839lbc; Tue, 29 Mar 2016 04:28:24 -0700 (PDT) X-Received: by 10.98.7.81 with SMTP id b78mr2506473pfd.49.1459250903982; Tue, 29 Mar 2016 04:28:23 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3si10253164pas.21.2016.03.29.04.28.23; Tue, 29 Mar 2016 04:28:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756989AbcC2L2F (ORCPT + 7 others); Tue, 29 Mar 2016 07:28:05 -0400 Received: from mail-vk0-f53.google.com ([209.85.213.53]:33147 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757001AbcC2L2B (ORCPT ); Tue, 29 Mar 2016 07:28:01 -0400 Received: by mail-vk0-f53.google.com with SMTP id k1so14269420vkb.0 for ; Tue, 29 Mar 2016 04:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NRDxYnb3e1kCHaFjvz4oKBxPjfNh7jNtgdi9rdSgwDs=; b=SMbu8Nwk3wgEibrMBiYCWQS7mPBrpsUK6o4kU0fJSwOMWKivFPDM6mc9QIRkd+7NJS dU0Aur2bZmtzgtG6ysZnVCDicQ9OiLJRENqdRhSC4fQYqLiaCVxfVtt893yEEQw8jdLJ CPo8C0LC5f19wP/Rcz5R0JvpxHvMu90s+fis4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NRDxYnb3e1kCHaFjvz4oKBxPjfNh7jNtgdi9rdSgwDs=; b=lXHFNLhH+Bzb/Utnr2HWHn/7qV02CSpd8SkZ27QyH6Xv91gZ7HYxgoVM3BbmYuiSzg 6+ZvM7siPeRAm6ZFE5y9SIMAwzqBLtesUOCpj+Lc6iywxFe34dwDhRDeWAJoDAU4dPMv wWzgMuxe0JvaNoKXJDJ53E/ZnVpjh5BzuTFz7/9Xhou/NTOH/gqttrxcikiLtp4vT5el sphYeCE9Eq0yMMr3pnUug6WZoofKAqTxf/kJMo+3FhjMxehTnxSsG8xfhOFnJVhHlEfE D74Wm8kRJdV1qHXgfDWO9VKgTqL43LieozIL/2UGkDi69eq1vt49c2KGGQ4bP77ccfjJ jKvQ== X-Gm-Message-State: AD7BkJLvaKg0uSwSrg/+6r06W2U1I0luINHfbB2ZiGjxLQy4tmDMSiBWhmJpIJBCvpCsw//e X-Received: by 10.31.162.20 with SMTP id l20mr728323vke.137.1459250880549; Tue, 29 Mar 2016 04:28:00 -0700 (PDT) Received: from leoy-linaro.a1.60in.com ([66.155.104.79]) by smtp.gmail.com with ESMTPSA id 97sm4665954uat.9.2016.03.29.04.27.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 29 Mar 2016 04:27:59 -0700 (PDT) From: Leo Yan To: Wei Xu , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Zhang Rui , Eduardo Valentin Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Leo Yan Subject: [PATCH v3 2/4] thermal: hisilicon: fix IRQ imbalance enabling Date: Tue, 29 Mar 2016 19:27:13 +0800 Message-Id: <1459250835-25561-3-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459250835-25561-1-git-send-email-leo.yan@linaro.org> References: <1459250835-25561-1-git-send-email-leo.yan@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org When register sensors into thermal zone during initialization phase, it reports error for IRQ imbalance enabling: [ 2.040713] WARNING: at kernel/irq/manage.c:513 [ 2.040719] Modules linked in: [ 2.040721] [ 2.040729] CPU: 1 PID: 804 Comm: irq/33-hisi_the Not tainted 4.5.0-rc4+ #505 [ 2.040732] Hardware name: HiKey Development Board (DT) [ 2.040736] task: ffffffc03ae82580 ti: ffffffc0379c8000 task.ti: ffffffc0379c8000 [ 2.040745] PC is at __enable_irq+0x74/0x84 [ 2.040749] LR is at __enable_irq+0x74/0x84 This warning is for IRQ imbalance enabling, which is caused by enable_irq() twice. During sensor's initialization it tries to enable IRQ, the driver will call thermal_zone_of_sensor_register() to bind sensors and read sensor's temperature. But at this moment the flag "data->irq_enabled" has been not initialized as correct state, so it finally introduces the function enabled_irq() to be called twice. In essentially this is caused by the flag "data->irq_enabled" is inconsistent with real hardware IRQ enabling state. So this patch is to fix this issue, firstly init "irq_enabled" flag before binding sensors to thermal zone. Also change to use the function irq_get_irqchip_state() to read back real interrupt line state. Signed-off-by: Leo Yan --- drivers/thermal/hisi_thermal.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c index 0fed5cf..4fef1b3 100644 --- a/drivers/thermal/hisi_thermal.c +++ b/drivers/thermal/hisi_thermal.c @@ -343,6 +343,10 @@ static int hisi_thermal_probe(struct platform_device *pdev) return ret; } + hisi_thermal_enable_bind_irq_sensor(data); + irq_get_irqchip_state(data->irq, IRQCHIP_STATE_MASKED, + &data->irq_enabled); + for (i = 0; i < HISI_MAX_SENSORS; ++i) { ret = hisi_thermal_register_sensor(pdev, data, &data->sensors[i], i); @@ -353,9 +357,6 @@ static int hisi_thermal_probe(struct platform_device *pdev) hisi_thermal_toggle_sensor(&data->sensors[i], true); } - hisi_thermal_enable_bind_irq_sensor(data); - data->irq_enabled = true; - return 0; }