From patchwork Tue Jun 23 14:09:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Fernandez X-Patchwork-Id: 50235 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f72.google.com (mail-wg0-f72.google.com [74.125.82.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2398D216E1 for ; Tue, 23 Jun 2015 14:13:04 +0000 (UTC) Received: by wgbhy7 with SMTP id hy7sf3282048wgb.3 for ; Tue, 23 Jun 2015 07:13:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=aH2s8Pd52htviW0m3ywk5QW7ZctOJTjoL90SG2WJtxs=; b=ZnOoqvd1ugT/Dd4ESyVM1WMqP3CYqbUN8Oab8JC0i3bYyMo735hNl+/BtE9asI7guG fT38oV6HHoXFLCQTE1dPZMVpJcMNFWeKue1AhZQhDNzt5bf7lcpAydjGblLkfwdsiGq9 o2EfRbYOCyJGKj+7giyzhQ3oZkeaseijgik3ZFTkSio34l4mGavVlbKS3yegdbCEQwdG WZXudUVre6fxuHW/9ag1lVh6ICJMJvR8cPX9dhD6y6ioMMqrOKMX+Ud798Vuxa6xkeed RrdmdoWYsl172/sO1zf/C6Er13bTgMbt7B7bvH3FmD+zJPyaaOjpO7bq+tOb6KBv1oZy EZPw== X-Gm-Message-State: ALoCoQk+0IvgQp0YZrCaaZL1Ut+xcWnqxh+ZUZ6p5Y80H251htraKTeSiC6SGcT7hqQwKr/Bf1/R X-Received: by 10.180.216.12 with SMTP id om12mr1492317wic.1.1435068783454; Tue, 23 Jun 2015 07:13:03 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.115.161 with SMTP id jp1ls50446lab.96.gmail; Tue, 23 Jun 2015 07:13:03 -0700 (PDT) X-Received: by 10.152.18.163 with SMTP id x3mr35206261lad.70.1435068783282; Tue, 23 Jun 2015 07:13:03 -0700 (PDT) Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com. [209.85.217.179]) by mx.google.com with ESMTPS id xj4si19411835lbb.112.2015.06.23.07.13.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jun 2015 07:13:03 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) client-ip=209.85.217.179; Received: by lbnk3 with SMTP id k3so7578862lbn.1 for ; Tue, 23 Jun 2015 07:13:03 -0700 (PDT) X-Received: by 10.112.198.74 with SMTP id ja10mr35424595lbc.19.1435068783166; Tue, 23 Jun 2015 07:13:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp3104765lbb; Tue, 23 Jun 2015 07:13:01 -0700 (PDT) X-Received: by 10.68.239.70 with SMTP id vq6mr69484628pbc.157.1435068781686; Tue, 23 Jun 2015 07:13:01 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ml1si34926762pab.24.2015.06.23.07.13.00; Tue, 23 Jun 2015 07:13:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933363AbbFWOMz (ORCPT + 7 others); Tue, 23 Jun 2015 10:12:55 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:35364 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933289AbbFWOKV (ORCPT ); Tue, 23 Jun 2015 10:10:21 -0400 Received: by wgbhy7 with SMTP id hy7so10806160wgb.2 for ; Tue, 23 Jun 2015 07:10:19 -0700 (PDT) X-Received: by 10.194.97.196 with SMTP id ec4mr8694174wjb.3.1435068618925; Tue, 23 Jun 2015 07:10:18 -0700 (PDT) Received: from lmenx315.lme.st.com (LPuteaux-656-1-48-212.w82-127.abo.wanadoo.fr. [82.127.83.212]) by mx.google.com with ESMTPSA id lk5sm22556790wic.24.2015.06.23.07.10.16 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jun 2015 07:10:18 -0700 (PDT) From: Gabriel Fernandez To: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Russell King , Michael Turquette , Stephen Boyd , Gabriel Fernandez , Peter Griffin , Pankaj Dev , Olivier Bideau , Javier Martinez Canillas , Geert Uytterhoeven , Fabian Frederick Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com, linux-clk@vger.kernel.org Subject: [PATCH 5/9] drivers: clk: st: Fix flexgen lock init Date: Tue, 23 Jun 2015 16:09:23 +0200 Message-Id: <1435068567-30995-6-git-send-email-gabriel.fernandez@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1435068567-30995-1-git-send-email-gabriel.fernandez@linaro.org> References: <1435068567-30995-1-git-send-email-gabriel.fernandez@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: gabriel.fernandez@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Giuseppe Cavallaro While proving lock, the following warning happens and it is fixed after initializing lock in the setup function INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.10.27-02861-g39df285-dirty #33 [] (unwind_backtrace+0x0/0xf4) from [] (show_stack+0x10/0x14) [] (show_stack+0x10/0x14) from [] (__lock_acquire+0x900/0xb14) [] (__lock_acquire+0x900/0xb14) from [] (lock_acquire+0x68/0x7c) [] (lock_acquire+0x68/0x7c) from [] (_raw_spin_lock_irqsave+0x48/0x5c) [] (_raw_spin_lock_irqsave+0x48/0x5c) from [] (clk_gate_endisable+0x28/0x88) [] (clk_gate_endisable+0x28/0x88) from [] (clk_gate_enable+0xc/0x14) [] (clk_gate_enable+0xc/0x14) from [] (flexgen_enable+0x28/0x40) [] (flexgen_enable+0x28/0x40) from [] (__clk_enable+0x5c/0x9c) [] (__clk_enable+0x5c/0x9c) from [] (clk_enable+0x18/0x2c) [] (clk_enable+0x18/0x2c) from [] (st_lpc_of_register+0xc0/0x248) [] (st_lpc_of_register+0xc0/0x248) from [] (clocksource_of_init+0x34/0x58) [] (clocksource_of_init+0x34/0x58) from [] (sti_timer_init+0x10/0x18) [] (sti_timer_init+0x10/0x18) from [] (time_init+0x20/0x30) [] (time_init+0x20/0x30) from [] (start_kernel+0x20c/0x2e8) [] (start_kernel+0x20c/0x2e8) from [<40008074>] (0x40008074) Signed-off-by: Giuseppe Cavallaro Signed-off-by: Gabriel Fernandez --- drivers/clk/st/clk-flexgen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c index 657ca14..be06d2a 100644 --- a/drivers/clk/st/clk-flexgen.c +++ b/drivers/clk/st/clk-flexgen.c @@ -303,6 +303,8 @@ static void __init st_of_flexgen_setup(struct device_node *np) if (!rlock) goto err; + spin_lock_init(rlock); + for (i = 0; i < clk_data->clk_num; i++) { struct clk *clk; const char *clk_name;