diff mbox series

[v4,1/5] dt-bindings: PCI: add snps,dw-pcie.yaml

Message ID 0454d09414d74d9789213f5e7779002bcc024537.1626174242.git.mchehab+huawei@kernel.org
State Superseded
Headers show
Series convert designware-pcie.txt and kirin-pcie.txt to yaml | expand

Commit Message

Mauro Carvalho Chehab July 13, 2021, 11:17 a.m. UTC 
Currently, the designware schema is defined on a text file:
	designware-pcie.txt

Convert the pci-bus part into a schema.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 .../devicetree/bindings/pci/snps,dw-pcie.yaml | 96 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 97 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

Comments

Rob Herring (Arm) July 15, 2021, 5:23 p.m. UTC | #1 
On Tue, Jul 13, 2021 at 01:17:51PM +0200, Mauro Carvalho Chehab wrote:
> Currently, the designware schema is defined on a text file:

> 	designware-pcie.txt

> 

> Convert the pci-bus part into a schema.

> 

> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

> ---

>  .../devicetree/bindings/pci/snps,dw-pcie.yaml | 96 +++++++++++++++++++

>  MAINTAINERS                                   |  1 +

>  2 files changed, 97 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

> 

> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

> new file mode 100644

> index 000000000000..fd372d715ab4

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

> @@ -0,0 +1,96 @@

> +# SPDX-License-Identifier: GPL-2.0

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/pci/snps,dw-pcie.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: Synopsys DesignWare PCIe interface

> +

> +maintainers:

> +  - Jingoo Han <jingoohan1@gmail.com>

> +  - Gustavo Pimentel <gustavo.pimentel@synopsys.com>

> +

> +description: |

> +  Synopsys DesignWare PCIe host controller

> +

> +allOf:

> +  - $ref: /schemas/pci/pci-bus.yaml#

> +

> +properties:

> +  compatible:

> +    anyOf:

> +      - {}

> +      - const: snps,dw-pcie

> +

> +  reg:

> +    description: |

> +      It should contain Data Bus Interface (dbi) and config registers for all

> +      versions.

> +      For designware core version >= 4.80, it may contain ATU address space.

> +    minItems: 2

> +    maxItems: 4

> +

> +  reg-names:

> +    minItems: 2

> +    maxItems: 4

> +    items:

> +      enum: [dbi, dbi2, config, atu, addr_space, app, elbi, mgmt]


Isn't 'config' only for host and 'addr_space' only for endpoint?

> +

> +  num-lanes:

> +    $ref: '/schemas/types.yaml#/definitions/uint32'

> +    description: |

> +      number of lanes to use (this property should be specified unless

> +      the link is brought already up in BIOS)

> +    maximum: 16

> +

> +  reset-gpio:

> +    description: GPIO pin number of PERST# signal

> +    maxItems: 1

> +    deprecated: true

> +

> +  reset-gpios:

> +    description: GPIO controlled connection to PERST# signal

> +    maxItems: 1

> +

> +  snps,enable-cdm-check:

> +    type: boolean

> +    description: |

> +      This is a boolean property and if present enables

> +      automatic checking of CDM (Configuration Dependent Module) registers

> +      for data corruption. CDM registers include standard PCIe configuration

> +      space registers, Port Logic registers, DMA and iATU (internal Address

> +      Translation Unit) registers.

> +

> +  num-viewport:

> +    description: |

> +      number of view ports configured in hardware. If a platform

> +      does not specify it, the driver autodetects it.

> +    deprecated: true

> +

> +unevaluatedProperties: false

> +

> +required:

> +  - reg

> +  - reg-names

> +  - compatible

> +

> +examples:

> +  - |

> +    bus {

> +      #address-cells = <1>;

> +      #size-cells = <1>;

> +      pcie@dfc00000 {

> +        device_type = "pci";

> +        compatible = "snps,dw-pcie";

> +        reg = <0xdfc00000 0x0001000>, /* IP registers */

> +              <0xd0000000 0x0002000>; /* Configuration space */

> +        reg-names = "dbi", "config";

> +        #address-cells = <3>;

> +        #size-cells = <2>;

> +        ranges = <0x81000000 0 0x00000000 0xde000000 0 0x00010000>,

> +                 <0x82000000 0 0xd0400000 0xd0400000 0 0x0d000000>;

> +        interrupts = <25>, <24>;


Not documented.

> +        #interrupt-cells = <1>;


Not documented.

> +        num-lanes = <1>;

> +      };

> +    };

> diff --git a/MAINTAINERS b/MAINTAINERS

> index 4529cf5ed430..f0115c590731 100644

> --- a/MAINTAINERS

> +++ b/MAINTAINERS

> @@ -14283,6 +14283,7 @@ M:	Gustavo Pimentel <gustavo.pimentel@synopsys.com>

>  L:	linux-pci@vger.kernel.org

>  S:	Maintained

>  F:	Documentation/devicetree/bindings/pci/designware-pcie.txt

> +F:	Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

>  F:	drivers/pci/controller/dwc/*designware*

>  

>  PCI DRIVER FOR TI DRA7XX/J721E

> -- 

> 2.31.1

> 

>
Mauro Carvalho Chehab July 18, 2021, 9:59 a.m. UTC | #2 
Em Thu, 15 Jul 2021 11:23:37 -0600
Rob Herring <robh@kernel.org> escreveu:

> On Tue, Jul 13, 2021 at 01:17:51PM +0200, Mauro Carvalho Chehab wrote:

> > Currently, the designware schema is defined on a text file:

> > 	designware-pcie.txt

> > 

> > Convert the pci-bus part into a schema.

> > 

> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

> > ---

> >  .../devicetree/bindings/pci/snps,dw-pcie.yaml | 96 +++++++++++++++++++

> >  MAINTAINERS                                   |  1 +

> >  2 files changed, 97 insertions(+)

> >  create mode 100644 Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

> > 

> > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

> > new file mode 100644

> > index 000000000000..fd372d715ab4

> > --- /dev/null

> > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

> > @@ -0,0 +1,96 @@

> > +# SPDX-License-Identifier: GPL-2.0

> > +%YAML 1.2

> > +---

> > +$id: http://devicetree.org/schemas/pci/snps,dw-pcie.yaml#

> > +$schema: http://devicetree.org/meta-schemas/core.yaml#

> > +

> > +title: Synopsys DesignWare PCIe interface

> > +

> > +maintainers:

> > +  - Jingoo Han <jingoohan1@gmail.com>

> > +  - Gustavo Pimentel <gustavo.pimentel@synopsys.com>

> > +

> > +description: |

> > +  Synopsys DesignWare PCIe host controller

> > +

> > +allOf:

> > +  - $ref: /schemas/pci/pci-bus.yaml#

> > +

> > +properties:

> > +  compatible:

> > +    anyOf:

> > +      - {}

> > +      - const: snps,dw-pcie

> > +

> > +  reg:

> > +    description: |

> > +      It should contain Data Bus Interface (dbi) and config registers for all

> > +      versions.

> > +      For designware core version >= 4.80, it may contain ATU address space.

> > +    minItems: 2

> > +    maxItems: 4

> > +

> > +  reg-names:

> > +    minItems: 2

> > +    maxItems: 4

> > +    items:

> > +      enum: [dbi, dbi2, config, atu, addr_space, app, elbi, mgmt]  

> 

> Isn't 'config' only for host and 'addr_space' only for endpoint?


The problem on enforcing an enum here is that severa *.dts files violate it. 
In the specific case of 'addr_space', there is (are?) place(s) where the wrong
compatible was used, like on arch/arm/boot/dts/artpec6.dtsi:

	pcie: pcie@f8050000 {
		compatible = "axis,artpec6-pcie", "snps,dw-pcie";
		reg = <0xf8050000 0x2000
		       0xf8040000 0x1000
		       0xc0000000 0x2000>;
		reg-names = "dbi", "phy", "config";
		#address-cells = <3>;
		#size-cells = <2>;
		device_type = "pci";
			  /* downstream I/O */
		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000
			  /* non-prefetchable memory */
			  0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>;
		num-lanes = <2>;
		bus-range = <0x00 0xff>;
		interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
		interrupt-names = "msi";
		#interrupt-cells = <1>;
		interrupt-map-mask = <0 0 0 0x7>;
		interrupt-map = <0 0 0 1 &intc GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>,
				<0 0 0 2 &intc GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
				<0 0 0 3 &intc GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,
				<0 0 0 4 &intc GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
		axis,syscon-pcie = <&syscon>;
		status = "disabled";
	};

	pcie_ep: pcie_ep@f8050000 {
		compatible = "axis,artpec6-pcie-ep", "snps,dw-pcie";
		reg = <0xf8050000 0x2000
		       0xf8051000 0x2000
		       0xf8040000 0x1000
		       0xc0000000 0x20000000>;
		reg-names = "dbi", "dbi2", "phy", "addr_space";
		num-ib-windows = <6>;
		num-ob-windows = <2>;
		num-lanes = <2>;
		axis,syscon-pcie = <&syscon>;
		status = "disabled";
	};

(funny enough, this is not generating warnings here).

Btw, besides the above, there are some DTS that use something different
from what's there at the enum:


	$ make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 dtbs_check 2>&1 |tee dtbs_check.log
	$ grep "\['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt'\]" dtbs_check.log|sed "s,From schema:,,"|cut -d: -f 2-|cut -d' ' -f 4-|sort|uniq -c|sort -n -r
	     51 'ctrl' is not one of ['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt']
	     44 'parf' is not one of ['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt']
	     18 'cfg' is not one of ['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt']
	      4 'link' is not one of ['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt']

In order to use an enum and not having warnings, the enum should be 
instead:

	reg-names:
	  minItems: 2
	  maxItems: 4
	  items:
	    enum: [dbi, dbi2, config, atu, app, elbi, mgmt, ctrl, parf, cfg, link]  


Thanks,
Mauro
Mauro Carvalho Chehab July 18, 2021, 10:55 a.m. UTC | #3 
Em Sun, 18 Jul 2021 11:59:16 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:

> Em Thu, 15 Jul 2021 11:23:37 -0600

> Rob Herring <robh@kernel.org> escreveu:

> 

> > On Tue, Jul 13, 2021 at 01:17:51PM +0200, Mauro Carvalho Chehab wrote:  

> > > Currently, the designware schema is defined on a text file:

> > > 	designware-pcie.txt

> > > 

> > > Convert the pci-bus part into a schema.

> > > 

> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

> > > ---

> > >  .../devicetree/bindings/pci/snps,dw-pcie.yaml | 96 +++++++++++++++++++

> > >  MAINTAINERS                                   |  1 +

> > >  2 files changed, 97 insertions(+)

> > >  create mode 100644 Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

> > > 

> > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

> > > new file mode 100644

> > > index 000000000000..fd372d715ab4

> > > --- /dev/null

> > > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

> > > @@ -0,0 +1,96 @@

> > > +# SPDX-License-Identifier: GPL-2.0

> > > +%YAML 1.2

> > > +---

> > > +$id: http://devicetree.org/schemas/pci/snps,dw-pcie.yaml#

> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#

> > > +

> > > +title: Synopsys DesignWare PCIe interface

> > > +

> > > +maintainers:

> > > +  - Jingoo Han <jingoohan1@gmail.com>

> > > +  - Gustavo Pimentel <gustavo.pimentel@synopsys.com>

> > > +

> > > +description: |

> > > +  Synopsys DesignWare PCIe host controller

> > > +

> > > +allOf:

> > > +  - $ref: /schemas/pci/pci-bus.yaml#

> > > +

> > > +properties:

> > > +  compatible:

> > > +    anyOf:

> > > +      - {}

> > > +      - const: snps,dw-pcie

> > > +

> > > +  reg:

> > > +    description: |

> > > +      It should contain Data Bus Interface (dbi) and config registers for all

> > > +      versions.

> > > +      For designware core version >= 4.80, it may contain ATU address space.

> > > +    minItems: 2

> > > +    maxItems: 4

> > > +

> > > +  reg-names:

> > > +    minItems: 2

> > > +    maxItems: 4

> > > +    items:

> > > +      enum: [dbi, dbi2, config, atu, addr_space, app, elbi, mgmt]    

> > 

> > Isn't 'config' only for host and 'addr_space' only for endpoint?  

> 

> The problem on enforcing an enum here is that severa *.dts files violate it. 

> In the specific case of 'addr_space', there is (are?) place(s) where the wrong

> compatible was used, like on arch/arm/boot/dts/artpec6.dtsi:

> 

> 	pcie: pcie@f8050000 {

> 		compatible = "axis,artpec6-pcie", "snps,dw-pcie";

> 		reg = <0xf8050000 0x2000

> 		       0xf8040000 0x1000

> 		       0xc0000000 0x2000>;

> 		reg-names = "dbi", "phy", "config";

> 		#address-cells = <3>;

> 		#size-cells = <2>;

> 		device_type = "pci";

> 			  /* downstream I/O */

> 		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000

> 			  /* non-prefetchable memory */

> 			  0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>;

> 		num-lanes = <2>;

> 		bus-range = <0x00 0xff>;

> 		interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;

> 		interrupt-names = "msi";

> 		#interrupt-cells = <1>;

> 		interrupt-map-mask = <0 0 0 0x7>;

> 		interrupt-map = <0 0 0 1 &intc GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>,

> 				<0 0 0 2 &intc GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,

> 				<0 0 0 3 &intc GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,

> 				<0 0 0 4 &intc GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;

> 		axis,syscon-pcie = <&syscon>;

> 		status = "disabled";

> 	};

> 

> 	pcie_ep: pcie_ep@f8050000 {

> 		compatible = "axis,artpec6-pcie-ep", "snps,dw-pcie";

> 		reg = <0xf8050000 0x2000

> 		       0xf8051000 0x2000

> 		       0xf8040000 0x1000

> 		       0xc0000000 0x20000000>;

> 		reg-names = "dbi", "dbi2", "phy", "addr_space";

> 		num-ib-windows = <6>;

> 		num-ob-windows = <2>;

> 		num-lanes = <2>;

> 		axis,syscon-pcie = <&syscon>;

> 		status = "disabled";

> 	};

> 

> (funny enough, this is not generating warnings here).

> 

> Btw, besides the above, there are some DTS that use something different

> from what's there at the enum:

> 

> 

> 	$ make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 dtbs_check 2>&1 |tee dtbs_check.log

> 	$ grep "\['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt'\]" dtbs_check.log|sed "s,From schema:,,"|cut -d: -f 2-|cut -d' ' -f 4-|sort|uniq -c|sort -n -r

> 	     51 'ctrl' is not one of ['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt']

> 	     44 'parf' is not one of ['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt']

> 	     18 'cfg' is not one of ['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt']

> 	      4 'link' is not one of ['dbi', 'dbi2', 'config', 'atu', 'app', 'elbi', 'mgmt']

> 

> In order to use an enum and not having warnings, the enum should be 

> instead:

> 

> 	reg-names:

> 	  minItems: 2

> 	  maxItems: 4

> 	  items:

> 	    enum: [dbi, dbi2, config, atu, app, elbi, mgmt, ctrl, parf, cfg, link] 


Actually, some reg definitions have 5 items.

I'm sending an updated patch series.

Thanks,
Mauro
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
new file mode 100644
index 000000000000..fd372d715ab4
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
@@ -0,0 +1,96 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/snps,dw-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Synopsys DesignWare PCIe interface
+
+maintainers:
+  - Jingoo Han <jingoohan1@gmail.com>
+  - Gustavo Pimentel <gustavo.pimentel@synopsys.com>
+
+description: |
+  Synopsys DesignWare PCIe host controller
+
+allOf:
+  - $ref: /schemas/pci/pci-bus.yaml#
+
+properties:
+  compatible:
+    anyOf:
+      - {}
+      - const: snps,dw-pcie
+
+  reg:
+    description: |
+      It should contain Data Bus Interface (dbi) and config registers for all
+      versions.
+      For designware core version >= 4.80, it may contain ATU address space.
+    minItems: 2
+    maxItems: 4
+
+  reg-names:
+    minItems: 2
+    maxItems: 4
+    items:
+      enum: [dbi, dbi2, config, atu, addr_space, app, elbi, mgmt]
+
+  num-lanes:
+    $ref: '/schemas/types.yaml#/definitions/uint32'
+    description: |
+      number of lanes to use (this property should be specified unless
+      the link is brought already up in BIOS)
+    maximum: 16
+
+  reset-gpio:
+    description: GPIO pin number of PERST# signal
+    maxItems: 1
+    deprecated: true
+
+  reset-gpios:
+    description: GPIO controlled connection to PERST# signal
+    maxItems: 1
+
+  snps,enable-cdm-check:
+    type: boolean
+    description: |
+      This is a boolean property and if present enables
+      automatic checking of CDM (Configuration Dependent Module) registers
+      for data corruption. CDM registers include standard PCIe configuration
+      space registers, Port Logic registers, DMA and iATU (internal Address
+      Translation Unit) registers.
+
+  num-viewport:
+    description: |
+      number of view ports configured in hardware. If a platform
+      does not specify it, the driver autodetects it.
+    deprecated: true
+
+unevaluatedProperties: false
+
+required:
+  - reg
+  - reg-names
+  - compatible
+
+examples:
+  - |
+    bus {
+      #address-cells = <1>;
+      #size-cells = <1>;
+      pcie@dfc00000 {
+        device_type = "pci";
+        compatible = "snps,dw-pcie";
+        reg = <0xdfc00000 0x0001000>, /* IP registers */
+              <0xd0000000 0x0002000>; /* Configuration space */
+        reg-names = "dbi", "config";
+        #address-cells = <3>;
+        #size-cells = <2>;
+        ranges = <0x81000000 0 0x00000000 0xde000000 0 0x00010000>,
+                 <0x82000000 0 0xd0400000 0xd0400000 0 0x0d000000>;
+        interrupts = <25>, <24>;
+        #interrupt-cells = <1>;
+        num-lanes = <1>;
+      };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index 4529cf5ed430..f0115c590731 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14283,6 +14283,7 @@  M:	Gustavo Pimentel <gustavo.pimentel@synopsys.com>
 L:	linux-pci@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/bindings/pci/designware-pcie.txt
+F:	Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
 F:	drivers/pci/controller/dwc/*designware*
 
 PCI DRIVER FOR TI DRA7XX/J721E