mbox series

[v2,0/4] Add missing TPM compatible strings

Message ID cover.1705140898.git.lukas@wunner.de
Headers show
Series Add missing TPM compatible strings | expand

Message

Lukas Wunner Jan. 13, 2024, 5:10 p.m. UTC
Dear Jarkko,

you've requested me to resend two patches which add "atmel,attpm20p"
as a compatible string to the dt-bindings and to the driver:

https://lore.kernel.org/all/CY65RSEA4VMD.MXHPX898TSW4@suppilovahvero/

The patches depend on a commit which landed in Linus' tree yesterday,
it consolidates the TPM dt-bindings:

https://git.kernel.org/linus/26c9d152ebf3

So after pulling from Linus, you should be able to apply the enclosed
patches cleanly.

I am also including two patches to add other missing compatible strings
to the driver.  I already submitted them in November and December but
they haven't been picked up yet:

https://lore.kernel.org/all/096e5d9d22eaed0a256d2d9b315a77245bd423c6.1701095446.git.lukas@wunner.de/
https://lore.kernel.org/all/5c92620082189dc4e6be277952d0b46df26a6478.1702811113.git.lukas@wunner.de/

Because all these patches merely add device IDs, I believe they can be
picked up and forwarded to Linus at any time, even outside the merge
window.  (According to Documentation/process/stable-kernel-rules.rst,
patches which "just add a device ID" are eligible for stable and
should thus be fair game for fixes pulls.)

Thank you!

Lukas Wunner (4):
  dt-bindings: tpm: Add compatible string atmel,attpm20p
  tpm_tis_spi: Add compatible string atmel,attpm20p
  tpm_tis: Add compatible string atmel,at97sc3204
  tpm: tis_i2c: Add compatible string nuvoton,npct75x

 Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml | 1 +
 drivers/char/tpm/tpm_tis.c                                 | 1 +
 drivers/char/tpm/tpm_tis_i2c.c                             | 2 ++
 drivers/char/tpm/tpm_tis_spi_main.c                        | 1 +
 4 files changed, 5 insertions(+)

Comments

Jarkko Sakkinen Jan. 13, 2024, 9:17 p.m. UTC | #1
On Sat Jan 13, 2024 at 7:10 PM EET, Lukas Wunner wrote:
> Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM device")
> added a devicetree node for the Trusted Platform Module on certain
> Gateworks boards.
>
> The commit only used the generic "tcg,tpm_tis-spi" compatible string,
> but public documentation shows that the chip is an ATTPM20P from Atmel
> (nowadays Microchip):
> https://trac.gateworks.com/wiki/tpm
>
> Add the chip to the supported compatible strings of the TPM TIS SPI
> schema.
>
> For reference, a datasheet is available at:
> https://ww1.microchip.com/downloads/en/DeviceDoc/ATTPM20P-Trusted-Platform-Module-TPM-2.0-SPI-Interface-Summary-Data-Sheet-DS40002082A.pdf
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> Cc: Tim Harvey <tharvey@gateworks.com>
> ---
>  Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml b/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml
> index c3413b4..6cb2de7 100644
> --- a/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml
> +++ b/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml
> @@ -20,6 +20,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> +          - atmel,attpm20p
>            - infineon,slb9670
>            - st,st33htpm-spi
>            - st,st33zp24-spi

You should to send the patch set with Rob Herring as CC for syncing
up. Please do it for future versions, if there is need for additional
versions.

Rob, 3 out of 4 patches are TPM patches. Do you mind if I take all
four patches once the patch set is ready or do you want to pick this
patch (assuming that you think it is correctly implemented ofc)?

BR, Jarkko