| Message ID | cover.1704788539.git.ysato@users.sourceforge.jp |
|---|---|
| Headers | show |
| Series | Device Tree support for SH7751 based board | expand |
On Wed, Jan 10, 2024 at 04:11:44PM +0000, Conor Dooley wrote: > On Wed, Jan 10, 2024 at 12:23:37PM +0100, Geert Uytterhoeven wrote: > > Hi Conor, > > > > On Tue, Jan 9, 2024 at 7:06 PM Conor Dooley <conor@kernel.org> wrote: > > > On Tue, Jan 09, 2024 at 05:23:23PM +0900, Yoshinori Sato wrote: > > > > Add Silicon Mortion Technology Corporation > > > > Motion > > > > > > https://www.siliconmotion.com/ > > > > > > > > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> > > > > --- > > > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > > index 94ed63d9f7de..a338bdd743ab 100644 > > > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > > @@ -1283,6 +1283,8 @@ patternProperties: > > > > description: Skyworks Solutions, Inc. > > > > "^smartlabs,.*": > > > > description: SmartLabs LLC > > > > + "^smi,.*": > > > > + description: Silicon Motion Technology Corporation > > > > > > How come "smi" is used for a company with this name? > > > Why is it not something like SMTC? There's probably some history here > > > that I am unaware of. > > > > See Documentation/devicetree/bindings/display/sm501fb.txt > > The stock ticker is "SIMO", though. > > https://www.nasdaq.com/market-activity/stocks/simo > > If there's an existing user, there's little reason to stand in the way I > think. > Acked-by: Conor Dooley <conor.dooley@microchip.com> Or reason not to apply, so I'm applying this. BTW, 'RFC' is the standard way to say 'DO NOT MERGE'. Rob
Hi Sato-san, On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> Thanks for your patch! > --- > .../bindings/display/smi,sm501.yaml | 417 ++++++++++++++++++ > 1 file changed, 417 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/smi,sm501.yaml Surely Documentation/devicetree/bindings/display/sm501fb.txt should be removed, too? > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/smi,sm501.yaml > + crt: > + type: object > + description: CRT output control > + properties: > + edid: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + description: | > + verbatim EDID data block describing attached display. > + Data from the detailed timing descriptor will be used to > + program the display controller. > + > + smi,flags: > + $ref: /schemas/types.yaml#/definitions/string-array > + description: Display control flags. > + items: > + anyOf: > + - const: use-init-done > + - const: disable-at-exit > + - const: use-hwcursor > + - const: use-hwaccel The "use-*" flags look like software policy, not hardware description, and thus do not belong in DT? > + - const: panel-no-fpen > + - const: panel-no-vbiasen > + - const: panel-inv-fpen > + - const: panel-inv-vbiasen > + maxItems: 8 > + > + bpp: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Color depth > + > + panel: > + type: object > + description: Panel output control > + properties: > + edid: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + description: | > + verbatim EDID data block describing attached display. > + Data from the detailed timing descriptor will be used to > + program the display controller. > + > + smi,flags: > + $ref: /schemas/types.yaml#/definitions/string-array > + description: Display control flags. > + items: > + anyOf: > + - const: use-init-done > + - const: disable-at-exit > + - const: use-hwcursor > + - const: use-hwaccel The "use-*" flags look like software policy, not hardware description, and thus do not belong in DT? > + - const: panel-no-fpen > + - const: panel-no-vbiasen > + - const: panel-inv-fpen > + - const: panel-inv-vbiasen > + maxItems: 8 > + > + bpp: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Color depth > + > + smi,devices: > + $ref: /schemas/types.yaml#/definitions/string-array > + description: Select SM501 device functions. > + items: > + anyOf: > + - const: usb-host > + - const: usb-slave > + - const: ssp0 > + - const: ssp1 > + - const: uart0 > + - const: uart1 > + - const: fbaccel > + - const: ac97 > + - const: i2s > + - const: gpio > + minItems: 1 > + maxItems: 10 I think it would be better to have individual subnodes for the sub devices, with status = "ok"/"disabled". If you go that route, you do need some fallback code to handle the lack of subnodes in the existing user in arch/powerpc/boot/dts/charon.dts. BTW, why can sm501_pci_initdata get away with setting ".devices = SM501_USE_ALL"? Or, would it hurt to enable all subdevices unconditionally? > + > + smi,mclk: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: mclk frequency. > + > + smi,m1xclk: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: m1xclk frequency. These two should be clock specifiers (i.e. phandles pointing to clock nodes + optional clock indices). > + > + misc-timing: > + type: object > + description: Miscellaneous Timing register values. > + properties: > + ex: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Extend bus holding time. > + enum: [0, 16, 32, 48, 64, 80, 96, 112, 128, 144, 160, 176, 192, 208, 224, 240] > + > + xc: > + $ref: /schemas/types.yaml#/definitions/string > + description: Xscale clock input select. > + items: > + enum: > + - internal-pll > + - hclk > + - gpio33 Software policy instead of hardware description again? I am not familiar with how the SM501 works, so I cannot comment on the other properties, but several of them look like they need rework. Gr{oetje,eeting}s, Geert
This is an updated version of something I wrote about 7 years ago. Minimum support for R2D-plus and LANDISK. I think R2D-1 will work if you add AX88796 to dts. And board-specific functions and SCI's SPI functions are not supported. You can get it working with qemu found here. https://gitlab.com/yoshinori.sato/qemu/-/tree/landisk v6 changes. - pci-sh7751: merge register define. - pci-sh7751: use 'dma-ranges' property. - pci-sh7751: rename general PCI properties. - sm501 and sm501fb: Re-design Device Tree properties. - sh/kernel/setup: cleanup command line setup. - irq-sh7751.c: some cleanup. v5 changes. - pci-sh7751: revert header changes. and some fix in previuous driver. - sh/kernel/iomap.c: Use SH io functions. - sm501 and sm501fb: re-write DT support. v4 changes. - cpg-sh7750: use clk-divider and clk-gate. - pci-sh7751: unified header files to old PCI driver. - irq-renesas-sh7751: IPR registers direct mapping. - irq-renesas-sh7751irl: useful register bit mapping. - sm501 and sm501fb: re-write dt parser. - j2_minus: fix build error. - dt-binding schema: fix some errors. - *.dts: cleanup. v3 changes. - Rewrite clk drivers. - Added sh_tmu to OF support. - Cleanup PCI stuff. - Update sm501 and sm501fb OF support. - Update devicetree and documents. v2 changes. - Rebasing v6,6-rc1 - re-write irqchip driver. - Add binding documents. - Cleanup review comment. Yoshinori Sato (37): sh: passing FDT address to kernel startup. sh: Kconfig unified OF supported targets. sh: Enable OF support for build and configuration. dt-bindings: interrupt-controller: Add header for Renesas SH3/4 INTC. sh: GENERIC_IRQ_CHIP support for CONFIG_OF=y sh: kernel/setup Update DT support. sh: Fix COMMON_CLK support in CONFIG_OF=y. clocksource: sh_tmu: CLOCKSOURCE support. dt-bindings: timer: renesas,tmu: add renesas,tmu-sh7750 sh: Common PCI Framework driver support. pci: pci-sh7751: Add SH7751 PCI driver dt-bindings: pci: pci-sh7751: Add SH7751 PCI dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header. clk: Compatible with narrow registers clk: renesas: Add SH7750/7751 CPG Driver irqchip: Add SH7751 INTC driver dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema irqchip: SH7751 external interrupt encoder with enable gate. dt-bindings: interrupt-controller: renesas,sh7751-irl-ext: Add json-schema serial: sh-sci: fix SH4 OF support. dt-bindings: serial: renesas,scif: Add scif-sh7751. dt-bindings: display: smi,sm501: SMI SM501 binding json-schema mfd: sm501: Convert platform_data to OF property dt-binding: sh: cpus: Add SH CPUs json-schema dt-bindings: vendor-prefixes: Add iodata dt-bindings: vendor-prefixes: Add smi dt-bindings: ata: ata-generic: Add new targets dt-bindings: soc: renesas: sh: Add SH7751 based target sh: SH7751R SoC Internal peripheral definition dtsi. sh: add RTS7751R2D Plus DTS sh: Add IO DATA LANDISK dts sh: Add IO DATA USL-5P dts sh: j2_mimas_v2.dts update sh: Add dtbs target support. sh: RTS7751R2D Plus OF defconfig sh: LANDISK OF defconfig sh: j2_defconfig: update .../devicetree/bindings/ata/ata-generic.yaml | 2 + .../bindings/clock/renesas,sh7750-cpg.yaml | 103 ++++ .../bindings/display/smi,sm501.yaml | 417 +++++++++++++++ .../renesas,sh7751-intc.yaml | 105 ++++ .../renesas,sh7751-irl-ext.yaml | 72 +++ .../bindings/pci/renesas,sh7751-pci.yaml | 150 ++++++ .../bindings/serial/renesas,scif.yaml | 1 + .../devicetree/bindings/sh/cpus.yaml | 74 +++ .../devicetree/bindings/soc/renesas/sh.yaml | 32 ++ .../bindings/timer/renesas,tmu.yaml | 67 ++- .../devicetree/bindings/vendor-prefixes.yaml | 4 + arch/sh/Kconfig | 12 +- arch/sh/boards/Kconfig | 24 +- arch/sh/boards/of-generic.c | 28 +- arch/sh/boot/compressed/head_32.S | 5 +- arch/sh/boot/dts/Makefile | 5 + arch/sh/boot/dts/j2_mimas_v2.dts | 2 +- arch/sh/boot/dts/landisk.dts | 75 +++ arch/sh/boot/dts/rts7751r2dplus.dts | 180 +++++++ arch/sh/boot/dts/sh7751r.dtsi | 152 ++++++ arch/sh/boot/dts/usl-5p.dts | 83 +++ arch/sh/configs/j2_defconfig | 11 +- arch/sh/configs/landisk-of_defconfig | 104 ++++ arch/sh/configs/rts7751r2dplus-of_defconfig | 80 +++ arch/sh/drivers/Makefile | 2 + arch/sh/include/asm/io.h | 8 + arch/sh/include/asm/irq.h | 10 +- arch/sh/include/asm/pci.h | 4 + arch/sh/kernel/cpu/Makefile | 6 +- arch/sh/kernel/cpu/irq/imask.c | 17 + arch/sh/kernel/cpu/sh4/Makefile | 3 + arch/sh/kernel/iomap.c | 18 + arch/sh/kernel/setup.c | 33 +- arch/sh/kernel/time.c | 12 + drivers/clk/clk-divider.c | 56 +- drivers/clk/clk-gate.c | 56 +- drivers/clk/renesas/Kconfig | 16 +- drivers/clk/renesas/Makefile | 1 + drivers/clk/renesas/clk-sh7750.c | 498 ++++++++++++++++++ drivers/clocksource/sh_tmu.c | 161 ++++-- drivers/irqchip/Kconfig | 15 + drivers/irqchip/Makefile | 3 + drivers/irqchip/irq-renesas-sh7751.c | 313 +++++++++++ drivers/irqchip/irq-renesas-sh7751irl.c | 228 ++++++++ drivers/mfd/sm501.c | 436 +++++++++++++++ drivers/pci/controller/Kconfig | 9 + drivers/pci/controller/Makefile | 1 + drivers/pci/controller/pci-sh7751.c | 392 ++++++++++++++ drivers/tty/serial/Kconfig | 2 +- drivers/tty/serial/sh-sci.c | 6 +- drivers/video/fbdev/sm501fb.c | 106 ++++ include/dt-bindings/clock/sh7750-cpg.h | 26 + .../renesas,sh7751-intc.h | 19 + include/linux/clk-provider.h | 22 +- include/linux/sh_intc.h | 7 +- 55 files changed, 4096 insertions(+), 178 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.yaml create mode 100644 Documentation/devicetree/bindings/display/smi,sm501.yaml create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-irl-ext.yaml create mode 100644 Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml create mode 100644 Documentation/devicetree/bindings/sh/cpus.yaml create mode 100644 Documentation/devicetree/bindings/soc/renesas/sh.yaml create mode 100644 arch/sh/boot/dts/landisk.dts create mode 100644 arch/sh/boot/dts/rts7751r2dplus.dts create mode 100644 arch/sh/boot/dts/sh7751r.dtsi create mode 100644 arch/sh/boot/dts/usl-5p.dts create mode 100644 arch/sh/configs/landisk-of_defconfig create mode 100644 arch/sh/configs/rts7751r2dplus-of_defconfig create mode 100644 drivers/clk/renesas/clk-sh7750.c create mode 100644 drivers/irqchip/irq-renesas-sh7751.c create mode 100644 drivers/irqchip/irq-renesas-sh7751irl.c create mode 100644 drivers/pci/controller/pci-sh7751.c create mode 100644 include/dt-bindings/clock/sh7750-cpg.h create mode 100644 include/dt-bindings/interrupt-controller/renesas,sh7751-intc.h