| Message ID | cover.1685693501.git.zhoubinbin@loongson.cn |
|---|---|
| Headers | show |
| Series | Add rtc driver for the Loongson family chips | expand |
Hi Alexandre: Gentle ping. The dt-binding part of the patchset looks good now, do you have any more comments on the driver part? Thanks. Binbin On Fri, Jun 2, 2023 at 5:51 PM Binbin Zhou <zhoubinbin@loongson.cn> wrote: > > Hi all: > > The initial DT-base ls2x rtc driver was written by Wang Xuerui, He has > released five versions of patchset before, and all related mail records > are shown below if you are interested: > > https://lore.kernel.org/all/?q=ls2x-rtc > > In this series of patches, based on the code above, I have added the > following support: > > 1. Add ACPI-related support, as Loongson-3A5000 + LS7A is now ACPI-base > by default under LoongArch architecture; > 2. Add rtc alarm/walarm related functions; > 3. Merge LS1X rtc and LS2X rtc into a unified rtc-loongson driver. > > I have tested on Loongson-3A5000LA+LS7A1000/LS7A2000, Loongson-2K1000LA, > Loongson-2K0500 and Loongson-2K2000(ACPI/DT). > > Thanks to everyone for reviewing and testing the code. > > ------- > v5: > patch(1/5) > - The reason why ls2x can be removed directly is explained in the > commit message; > - Use fallback compatible; > Thanks to all who participated in the fallback compatible discussion. > patch(3/5) > - Since ls1b and ls1c have different register definitions, we'd better > distinguish them with different > configurations(ls1b_rtc_config/ls1c_rtc_config); > - Due to the use of fallback compatible, the redundant compatible is > removed. We can see the full list of supported chips in dt-binding.. > > v4: > https://lore.kernel.org/linux-rtc/cover.1684983279.git.zhoubinbin@loongson.cn/ > > - Rebase on the top of rtc-next; > - Drop defconfig-related patches; > patch(1/5) > - New patch, Loongson RTC bindings have been rewritten and we have > dropped the wildcard (ls2x) in compatible. > Thanks to Krzysztof for your comments; > patch(2/5) > - New patch, drop the ls1x rtc driver; > patch(3/5) > - Clear RTC_FEATURE_UPDATE_INTERRUPT bit, for the rtc does not support > UIE; > - Add LS2K2000 support(DT/ACPI); > - Merge ls1x support and name the driver rtc-loongson; > Thanks to Jiaxun for his comments and Keguang for his assistance in > testing. > > v3: > https://lore.kernel.org/linux-rtc/cover.1681370153.git.zhoubinbin@loongson.cn/ > > patch(2/7): > - Check patchset with "checkpatch.pl --strict"; > - Drop static inline functions which are used only once, such as > ls2x_rtc_regs_to_time; > - Remove the suruct ls2x_rtc_regs and regmap_bulk_xxx() is used to read > and write rtc registers; > - Clear the RTC wakeup interrupt manually; > - Enable the RTC in set_time() and check in read_time(); > - device_get_match_data() is used to get ls2x_pm_offset, for LS2k1000 > has the different value; > - Remove some inexact CONFIG_ACPI. > > v2: > 1. Rebased on top of latest loongarch-next; > 2. Add interrupt descriptions to the ls2k and ls7a DTS files to avoid > errors when the driver gets the IRQ number, Thanks to Qing Zhang for > testing; > 3. Remove some inexact CONFIG_ACPI. > > Thanks. > > Binbin Zhou (5): > dt-bindings: rtc: Remove the LS2X from the trivial RTCs > rtc: Remove the Loongson-1 RTC driver > rtc: Add rtc driver for the Loongson family chips > MIPS: Loongson64: DTS: Add RTC support to LS7A PCH > MIPS: Loongson64: DTS: Add RTC support to Loongson-2K1000 > > .../devicetree/bindings/rtc/loongson,rtc.yaml | 57 +++ > .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - > .../boot/dts/loongson/loongson64-2k1000.dtsi | 7 + > arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 7 + > drivers/rtc/Kconfig | 23 +- > drivers/rtc/Makefile | 2 +- > drivers/rtc/rtc-loongson.c | 397 ++++++++++++++++++ > drivers/rtc/rtc-ls1x.c | 192 --------- > 8 files changed, 482 insertions(+), 205 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/loongson,rtc.yaml > create mode 100644 drivers/rtc/rtc-loongson.c > delete mode 100644 drivers/rtc/rtc-ls1x.c > > -- > 2.39.1 > >
On Fri, 02 Jun 2023 17:50:19 +0800, Binbin Zhou wrote: > The initial DT-base ls2x rtc driver was written by Wang Xuerui, He has > released five versions of patchset before, and all related mail records > are shown below if you are interested: > > https://lore.kernel.org/all/?q=ls2x-rtc > > In this series of patches, based on the code above, I have added the > following support: > > [...] Applied, thanks! [1/5] dt-bindings: rtc: Remove the LS2X from the trivial RTCs commit: 487ef32caebe010f0ff0f17267230ebaf2177e67 [2/5] rtc: Remove the Loongson-1 RTC driver commit: 9fb23090658adbd7f8f44bf5c38aa3fc4b1699bd [3/5] rtc: Add rtc driver for the Loongson family chips commit: 1b733a9ebc3d8011ca66ec6ff17f55a440358794 Best regards,
Hi all: The initial DT-base ls2x rtc driver was written by Wang Xuerui, He has released five versions of patchset before, and all related mail records are shown below if you are interested: https://lore.kernel.org/all/?q=ls2x-rtc In this series of patches, based on the code above, I have added the following support: 1. Add ACPI-related support, as Loongson-3A5000 + LS7A is now ACPI-base by default under LoongArch architecture; 2. Add rtc alarm/walarm related functions; 3. Merge LS1X rtc and LS2X rtc into a unified rtc-loongson driver. I have tested on Loongson-3A5000LA+LS7A1000/LS7A2000, Loongson-2K1000LA, Loongson-2K0500 and Loongson-2K2000(ACPI/DT). Thanks to everyone for reviewing and testing the code. ------- v5: patch(1/5) - The reason why ls2x can be removed directly is explained in the commit message; - Use fallback compatible; Thanks to all who participated in the fallback compatible discussion. patch(3/5) - Since ls1b and ls1c have different register definitions, we'd better distinguish them with different configurations(ls1b_rtc_config/ls1c_rtc_config); - Due to the use of fallback compatible, the redundant compatible is removed. We can see the full list of supported chips in dt-binding.. v4: https://lore.kernel.org/linux-rtc/cover.1684983279.git.zhoubinbin@loongson.cn/ - Rebase on the top of rtc-next; - Drop defconfig-related patches; patch(1/5) - New patch, Loongson RTC bindings have been rewritten and we have dropped the wildcard (ls2x) in compatible. Thanks to Krzysztof for your comments; patch(2/5) - New patch, drop the ls1x rtc driver; patch(3/5) - Clear RTC_FEATURE_UPDATE_INTERRUPT bit, for the rtc does not support UIE; - Add LS2K2000 support(DT/ACPI); - Merge ls1x support and name the driver rtc-loongson; Thanks to Jiaxun for his comments and Keguang for his assistance in testing. v3: https://lore.kernel.org/linux-rtc/cover.1681370153.git.zhoubinbin@loongson.cn/ patch(2/7): - Check patchset with "checkpatch.pl --strict"; - Drop static inline functions which are used only once, such as ls2x_rtc_regs_to_time; - Remove the suruct ls2x_rtc_regs and regmap_bulk_xxx() is used to read and write rtc registers; - Clear the RTC wakeup interrupt manually; - Enable the RTC in set_time() and check in read_time(); - device_get_match_data() is used to get ls2x_pm_offset, for LS2k1000 has the different value; - Remove some inexact CONFIG_ACPI. v2: 1. Rebased on top of latest loongarch-next; 2. Add interrupt descriptions to the ls2k and ls7a DTS files to avoid errors when the driver gets the IRQ number, Thanks to Qing Zhang for testing; 3. Remove some inexact CONFIG_ACPI. Thanks. Binbin Zhou (5): dt-bindings: rtc: Remove the LS2X from the trivial RTCs rtc: Remove the Loongson-1 RTC driver rtc: Add rtc driver for the Loongson family chips MIPS: Loongson64: DTS: Add RTC support to LS7A PCH MIPS: Loongson64: DTS: Add RTC support to Loongson-2K1000 .../devicetree/bindings/rtc/loongson,rtc.yaml | 57 +++ .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - .../boot/dts/loongson/loongson64-2k1000.dtsi | 7 + arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 7 + drivers/rtc/Kconfig | 23 +- drivers/rtc/Makefile | 2 +- drivers/rtc/rtc-loongson.c | 397 ++++++++++++++++++ drivers/rtc/rtc-ls1x.c | 192 --------- 8 files changed, 482 insertions(+), 205 deletions(-) create mode 100644 Documentation/devicetree/bindings/rtc/loongson,rtc.yaml create mode 100644 drivers/rtc/rtc-loongson.c delete mode 100644 drivers/rtc/rtc-ls1x.c