mbox series

[v3,0/3] Add Qualcomm Technologies, Inc. PM8008 MFD driver

Message ID cover.1618278453.git.gurus@codeaurora.org
Headers show
Series Add Qualcomm Technologies, Inc. PM8008 MFD driver | expand

Message

Guru Das Srinagesh April 13, 2021, 2 a.m. UTC
Changes from v2:
  - Collected Rob Herring's Acked-by for the IRQ listing patch
  - Addressed Rob's comments for the dt-bindings patch

Changes from v1:
  - Removed errant Change-Id from dt-bindings IRQ patch and gathered Bjorn's
    Reviewed-by
  - Fixed up YAML errors using make dt_binding_check

This driver is dependent on changes that have been made to the regmap-irq
framework that have currently been accepted [1][2] in regmap.git upstream by
Mark Brown but haven't made it to Linus' tree yet. For this reason, this driver
has been based on the tip of regmap.git and not mfd.git.

Those changes, and this driver, are the result of a rewrite effort that was
promised a long ago [3]. The framework changes and this driver have been tested
and verified end-to-end on an internal platform.

[1] https://lore.kernel.org/lkml/20210318183607.gFxO2hoTO274vl3jUuxWbi19rq9wQELzN-y3B4jvO10@z/
[2] https://lore.kernel.org/lkml/161726943419.2413.4844313396830856637.b4-ty@kernel.org/
[3] https://lore.kernel.org/lkml/20200519185757.GA13992@codeaurora.org/


Guru Das Srinagesh (3):
  dt-bindings: mfd: pm8008: Add IRQ listing
  dt-bindings: mfd: pm8008: Add bindings
  mfd: pm8008: Add driver for QCOM PM8008 PMIC

 .../devicetree/bindings/mfd/qcom,pm8008.yaml       | 121 +++++++++
 drivers/mfd/Kconfig                                |  15 ++
 drivers/mfd/Makefile                               |   1 +
 drivers/mfd/qcom-pm8008.c                          | 284 +++++++++++++++++++++
 include/dt-bindings/mfd/qcom-pm8008.h              |  19 ++
 5 files changed, 440 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
 create mode 100644 drivers/mfd/qcom-pm8008.c
 create mode 100644 include/dt-bindings/mfd/qcom-pm8008.h

Comments

Guru Das Srinagesh April 20, 2021, 4:46 p.m. UTC | #1
On Mon, Apr 12, 2021 at 07:00:24PM -0700, Guru Das Srinagesh wrote:
> Changes from v2:

>   - Collected Rob Herring's Acked-by for the IRQ listing patch

>   - Addressed Rob's comments for the dt-bindings patch

> 

> Changes from v1:

>   - Removed errant Change-Id from dt-bindings IRQ patch and gathered Bjorn's

>     Reviewed-by

>   - Fixed up YAML errors using make dt_binding_check

> 

> This driver is dependent on changes that have been made to the regmap-irq

> framework that have currently been accepted [1][2] in regmap.git upstream by

> Mark Brown but haven't made it to Linus' tree yet. For this reason, this driver

> has been based on the tip of regmap.git and not mfd.git.

> 

> Those changes, and this driver, are the result of a rewrite effort that was

> promised a long ago [3]. The framework changes and this driver have been tested

> and verified end-to-end on an internal platform.

> 

> [1] https://lore.kernel.org/lkml/20210318183607.gFxO2hoTO274vl3jUuxWbi19rq9wQELzN-y3B4jvO10@z/

> [2] https://lore.kernel.org/lkml/161726943419.2413.4844313396830856637.b4-ty@kernel.org/

> [3] https://lore.kernel.org/lkml/20200519185757.GA13992@codeaurora.org/


Hi Lee, mfd reviewers,

This new driver depends on three regmap-irq framework changes that have
been accepted by Mark (please see above) and hence will land only in the
next rc-1 release. I just wanted to make sure that this patch series was
on your radar [1]. The dt-bindings has been Acked by Rob already, and
I'd be happy to address any review comments while patiently waiting for
the dependencies to land.

[1] https://lore.kernel.org/lkml/20210419072229.GA4869@dell/

Thank you.

Guru Das.
Lee Jones April 23, 2021, 9:33 a.m. UTC | #2
On Tue, 20 Apr 2021, Guru Das Srinagesh wrote:

> On Mon, Apr 12, 2021 at 07:00:24PM -0700, Guru Das Srinagesh wrote:

> > Changes from v2:

> >   - Collected Rob Herring's Acked-by for the IRQ listing patch

> >   - Addressed Rob's comments for the dt-bindings patch

> > 

> > Changes from v1:

> >   - Removed errant Change-Id from dt-bindings IRQ patch and gathered Bjorn's

> >     Reviewed-by

> >   - Fixed up YAML errors using make dt_binding_check

> > 

> > This driver is dependent on changes that have been made to the regmap-irq

> > framework that have currently been accepted [1][2] in regmap.git upstream by

> > Mark Brown but haven't made it to Linus' tree yet. For this reason, this driver

> > has been based on the tip of regmap.git and not mfd.git.

> > 

> > Those changes, and this driver, are the result of a rewrite effort that was

> > promised a long ago [3]. The framework changes and this driver have been tested

> > and verified end-to-end on an internal platform.

> > 

> > [1] https://lore.kernel.org/lkml/20210318183607.gFxO2hoTO274vl3jUuxWbi19rq9wQELzN-y3B4jvO10@z/

> > [2] https://lore.kernel.org/lkml/161726943419.2413.4844313396830856637.b4-ty@kernel.org/

> > [3] https://lore.kernel.org/lkml/20200519185757.GA13992@codeaurora.org/

> 

> Hi Lee, mfd reviewers,

> 

> This new driver depends on three regmap-irq framework changes that have

> been accepted by Mark (please see above) and hence will land only in the

> next rc-1 release. I just wanted to make sure that this patch series was

> on your radar [1]. The dt-bindings has been Acked by Rob already, and

> I'd be happy to address any review comments while patiently waiting for

> the dependencies to land.


Yes, it's on my to-review list.

Linus is about to release v5.12.  I'll review this set in good time.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog