mbox series

[v2,0/4] Add support for Azoteq IQS7222D

Message ID ZKrotyhz7eueujys@nixie71
Headers show
Series Add support for Azoteq IQS7222D | expand

Message

Jeff LaBundy July 9, 2023, 5:04 p.m. UTC 
This series adds support for the latest member of the Azoteq IQS7222x
family of devices; it also sneaks in a bug fix and a clarification to
the binding.

Changes in v2:
 - Added patches [1/4] and [2/4]
 - Updated patch [3/4] as follows:
   - Wrapped words instead of splitting them
   - Specified units for the 'azoteq,top-speed', 'azoteq,bottom-speed'
     and 'azoteq,gesture-dist' properties as in patch [2/4]
   - Corrected the 'azoteq,gesture-dist' property's role in the case of
     tap gestures
   - Updated the if/then/else schema to consolidate restrictions common
     to both IQS7222B and IQS7222D, and to indicate that the latter can
     support the 'azoteq,ulp-allow' property
   - Added more details to the commit message
 - Removed unused variable 'val' from patch [4/4]

Jeff LaBundy (4):
  Input: iqs7222 - configure power mode before triggering ATI
  dt-bindings: input: iqs7222: Define units for slider properties
  dt-bindings: input: iqs7222: Add properties for Azoteq IQS7222D
  Input: iqs7222 - add support for Azoteq IQS7222D

 .../bindings/input/azoteq,iqs7222.yaml        | 248 ++++++++-
 drivers/input/misc/Kconfig                    |   4 +-
 drivers/input/misc/iqs7222.c                  | 476 +++++++++++++++++-
 3 files changed, 688 insertions(+), 40 deletions(-)

Comments

Krzysztof Kozlowski July 10, 2023, 8:45 a.m. UTC | #1 
On 09/07/2023 19:07, Jeff LaBundy wrote:
> Extend the common binding to include a new variant of the silicon,
> which effectively replaces a pair of slider nodes with a trackpad
> node comprising the same or similar properties.
> 
> As part of this change, the if/then/else schema have been updated
> to identify properties that are not supported by the new device.
> 
> Signed-off-by: Jeff LaBundy <jeff@labundy.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Dmitry Torokhov July 10, 2023, 7:08 p.m. UTC | #2 
On Sun, Jul 09, 2023 at 12:04:55PM -0500, Jeff LaBundy wrote:
> This series adds support for the latest member of the Azoteq IQS7222x
> family of devices; it also sneaks in a bug fix and a clarification to
> the binding.
> 
> Changes in v2:
>  - Added patches [1/4] and [2/4]
>  - Updated patch [3/4] as follows:
>    - Wrapped words instead of splitting them
>    - Specified units for the 'azoteq,top-speed', 'azoteq,bottom-speed'
>      and 'azoteq,gesture-dist' properties as in patch [2/4]
>    - Corrected the 'azoteq,gesture-dist' property's role in the case of
>      tap gestures
>    - Updated the if/then/else schema to consolidate restrictions common
>      to both IQS7222B and IQS7222D, and to indicate that the latter can
>      support the 'azoteq,ulp-allow' property
>    - Added more details to the commit message
>  - Removed unused variable 'val' from patch [4/4]
> 
> Jeff LaBundy (4):
>   Input: iqs7222 - configure power mode before triggering ATI
>   dt-bindings: input: iqs7222: Define units for slider properties
>   dt-bindings: input: iqs7222: Add properties for Azoteq IQS7222D
>   Input: iqs7222 - add support for Azoteq IQS7222D

Applied the lot, thank you.