mbox series

[v2,0/2] coresight: core: Add device name support

Message ID 20240115164252.26510-1-quic_jinlmao@quicinc.com
Headers show
Series coresight: core: Add device name support | expand

Message

Mao Jinlong Jan. 15, 2024, 4:42 p.m. UTC
With current design, the name of the non-cpu bounded coresight
component is the device type with the number. And with 'ls' command
we can get the register address of the component. But from these
information, we can't know what the HW or system the component belongs
to. Add device-name in DT to support it.

cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0
cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1
tpdm0 -> ../../../devices/platform/soc@0/10b0d000.tpdm/tpdm0
tpdm1 -> ../../../devices/platform/soc@0/10c28000.tpdm/tpdm1
tpdm2 -> ../../../devices/platform/soc@0/10c29000.tpdm/tpdm2

Change since V1:
1. Change coresight-name to device name.
2. Add the device-name in coresight dt bindings.

Mao Jinlong (2):
  coresight: core: Add device name support
  dt-bindings: arm: Add device-name in the coresight components

 .../bindings/arm/arm,coresight-catu.yaml      |  5 +++
 .../bindings/arm/arm,coresight-cpu-debug.yaml |  5 +++
 .../bindings/arm/arm,coresight-cti.yaml       |  5 +++
 .../arm/arm,coresight-dummy-sink.yaml         |  5 +++
 .../arm/arm,coresight-dummy-source.yaml       |  5 +++
 .../arm/arm,coresight-dynamic-funnel.yaml     |  5 +++
 .../arm/arm,coresight-dynamic-replicator.yaml |  5 +++
 .../bindings/arm/arm,coresight-etb10.yaml     |  5 +++
 .../bindings/arm/arm,coresight-etm.yaml       |  5 +++
 .../arm/arm,coresight-static-funnel.yaml      |  5 +++
 .../arm/arm,coresight-static-replicator.yaml  |  5 +++
 .../bindings/arm/arm,coresight-stm.yaml       |  5 +++
 .../bindings/arm/arm,coresight-tmc.yaml       |  5 +++
 .../bindings/arm/arm,coresight-tpiu.yaml      |  5 +++
 .../bindings/arm/qcom,coresight-tpda.yaml     |  5 +++
 .../bindings/arm/qcom,coresight-tpdm.yaml     |  5 +++
 drivers/hwtracing/coresight/coresight-core.c  | 33 ++++++++++---------
 .../hwtracing/coresight/coresight-platform.c  | 31 +++++++++++++++++
 include/linux/coresight.h                     |  1 +
 19 files changed, 130 insertions(+), 15 deletions(-)

Comments

Suzuki K Poulose Jan. 16, 2024, 1:43 p.m. UTC | #1
On 15/01/2024 16:42, Mao Jinlong wrote:
> With current design, the name of the non-cpu bounded coresight
> component is the device type with the number. And with 'ls' command
> we can get the register address of the component. But from these
> information, we can't know what the HW or system the component belongs
> to. Add device-name in DT to support it.
> 
> cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0
> cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1
> tpdm0 -> ../../../devices/platform/soc@0/10b0d000.tpdm/tpdm0
> tpdm1 -> ../../../devices/platform/soc@0/10c28000.tpdm/tpdm1
> tpdm2 -> ../../../devices/platform/soc@0/10c29000.tpdm/tpdm2

Please could you rebase this on for-next/queue (which has all bells and 
whistles enabled to report Warnings), fixing the reported issue by 
kernel test robot ?

Suzuki


> 
> Change since V1:
> 1. Change coresight-name to device name.
> 2. Add the device-name in coresight dt bindings.
> 
> Mao Jinlong (2):
>    coresight: core: Add device name support
>    dt-bindings: arm: Add device-name in the coresight components
> 
>   .../bindings/arm/arm,coresight-catu.yaml      |  5 +++
>   .../bindings/arm/arm,coresight-cpu-debug.yaml |  5 +++
>   .../bindings/arm/arm,coresight-cti.yaml       |  5 +++
>   .../arm/arm,coresight-dummy-sink.yaml         |  5 +++
>   .../arm/arm,coresight-dummy-source.yaml       |  5 +++
>   .../arm/arm,coresight-dynamic-funnel.yaml     |  5 +++
>   .../arm/arm,coresight-dynamic-replicator.yaml |  5 +++
>   .../bindings/arm/arm,coresight-etb10.yaml     |  5 +++
>   .../bindings/arm/arm,coresight-etm.yaml       |  5 +++
>   .../arm/arm,coresight-static-funnel.yaml      |  5 +++
>   .../arm/arm,coresight-static-replicator.yaml  |  5 +++
>   .../bindings/arm/arm,coresight-stm.yaml       |  5 +++
>   .../bindings/arm/arm,coresight-tmc.yaml       |  5 +++
>   .../bindings/arm/arm,coresight-tpiu.yaml      |  5 +++
>   .../bindings/arm/qcom,coresight-tpda.yaml     |  5 +++
>   .../bindings/arm/qcom,coresight-tpdm.yaml     |  5 +++
>   drivers/hwtracing/coresight/coresight-core.c  | 33 ++++++++++---------
>   .../hwtracing/coresight/coresight-platform.c  | 31 +++++++++++++++++
>   include/linux/coresight.h                     |  1 +
>   19 files changed, 130 insertions(+), 15 deletions(-)
>
Mao Jinlong Jan. 17, 2024, 1:58 a.m. UTC | #2
On 1/16/2024 9:43 PM, Suzuki K Poulose wrote:
> On 15/01/2024 16:42, Mao Jinlong wrote:
>> With current design, the name of the non-cpu bounded coresight
>> component is the device type with the number. And with 'ls' command
>> we can get the register address of the component. But from these
>> information, we can't know what the HW or system the component belongs
>> to. Add device-name in DT to support it.
>>
>> cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0
>> cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1
>> tpdm0 -> ../../../devices/platform/soc@0/10b0d000.tpdm/tpdm0
>> tpdm1 -> ../../../devices/platform/soc@0/10c28000.tpdm/tpdm1
>> tpdm2 -> ../../../devices/platform/soc@0/10c29000.tpdm/tpdm2
> 
> Please could you rebase this on for-next/queue (which has all bells and 
> whistles enabled to report Warnings), fixing the reported issue by 
> kernel test robot ?
> 
I will rebase the patch.

Thanks
Jinlong Mao
> Suzuki
> 
> 
>>
>> Change since V1:
>> 1. Change coresight-name to device name.
>> 2. Add the device-name in coresight dt bindings.
>>
>> Mao Jinlong (2):
>>    coresight: core: Add device name support
>>    dt-bindings: arm: Add device-name in the coresight components
>>
>>   .../bindings/arm/arm,coresight-catu.yaml      |  5 +++
>>   .../bindings/arm/arm,coresight-cpu-debug.yaml |  5 +++
>>   .../bindings/arm/arm,coresight-cti.yaml       |  5 +++
>>   .../arm/arm,coresight-dummy-sink.yaml         |  5 +++
>>   .../arm/arm,coresight-dummy-source.yaml       |  5 +++
>>   .../arm/arm,coresight-dynamic-funnel.yaml     |  5 +++
>>   .../arm/arm,coresight-dynamic-replicator.yaml |  5 +++
>>   .../bindings/arm/arm,coresight-etb10.yaml     |  5 +++
>>   .../bindings/arm/arm,coresight-etm.yaml       |  5 +++
>>   .../arm/arm,coresight-static-funnel.yaml      |  5 +++
>>   .../arm/arm,coresight-static-replicator.yaml  |  5 +++
>>   .../bindings/arm/arm,coresight-stm.yaml       |  5 +++
>>   .../bindings/arm/arm,coresight-tmc.yaml       |  5 +++
>>   .../bindings/arm/arm,coresight-tpiu.yaml      |  5 +++
>>   .../bindings/arm/qcom,coresight-tpda.yaml     |  5 +++
>>   .../bindings/arm/qcom,coresight-tpdm.yaml     |  5 +++
>>   drivers/hwtracing/coresight/coresight-core.c  | 33 ++++++++++---------
>>   .../hwtracing/coresight/coresight-platform.c  | 31 +++++++++++++++++
>>   include/linux/coresight.h                     |  1 +
>>   19 files changed, 130 insertions(+), 15 deletions(-)
>>
>