| Message ID | 20240105070925.2948871-1-leong.ching.swee@intel.com |
|---|---|
| Headers | show |
| Series | net: stmmac: Enable Per DMA Channel interrupt | expand |
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 5 Jan 2024 15:09:21 +0800 you wrote: > From: Swee Leong Ching <leong.ching.swee@intel.com> > > Hi, > Add Per DMA Channel interrupt feature for DWXGMAC IP. > > Patchset (link below) contains per DMA channel interrupt, But it was > achieved. > https://lore.kernel.org/lkml/20230821203328.GA2197059- > robh@kernel.org/t/#m849b529a642e1bff89c05a07efc25d6a94c8bfb4 > > [...] Here is the summary with links: - [net-next,v2,1/4] dt-bindings: net: snps,dwmac: per channel irq https://git.kernel.org/netdev/net-next/c/67d47c8ada0f - [net-next,v2,2/4] net: stmmac: Make MSI interrupt routine generic https://git.kernel.org/netdev/net-next/c/477bd4beb93b - [net-next,v2,3/4] net: stmmac: Add support for TX/RX channel interrupt https://git.kernel.org/netdev/net-next/c/9072e03d3208 - [net-next,v2,4/4] net: stmmac: Use interrupt mode INTM=1 for per channel irq https://git.kernel.org/netdev/net-next/c/36af9f25ddfd You are awesome, thank you!
On 07/01/2024 17:40, patchwork-bot+netdevbpf@kernel.org wrote: > Hello: > > This series was applied to netdev/net-next.git (main) > by David S. Miller <davem@davemloft.net>: > > On Fri, 5 Jan 2024 15:09:21 +0800 you wrote: >> From: Swee Leong Ching <leong.ching.swee@intel.com> >> >> Hi, >> Add Per DMA Channel interrupt feature for DWXGMAC IP. >> >> Patchset (link below) contains per DMA channel interrupt, But it was >> achieved. >> https://lore.kernel.org/lkml/20230821203328.GA2197059- >> robh@kernel.org/t/#m849b529a642e1bff89c05a07efc25d6a94c8bfb4 >> >> [...] > > Here is the summary with links: > - [net-next,v2,1/4] dt-bindings: net: snps,dwmac: per channel irq > https://git.kernel.org/netdev/net-next/c/67d47c8ada0f Please wait for DT bindings review a bit more than one working day (I don't count Saturday and Sunday, because we all have some life...). Best regards, Krzysztof
On Sun, Jan 07, 2024 at 08:06:55PM +0100, Krzysztof Kozlowski wrote: > On 07/01/2024 17:40, patchwork-bot+netdevbpf@kernel.org wrote: > > Hello: > > > > This series was applied to netdev/net-next.git (main) > > by David S. Miller <davem@davemloft.net>: > > > > On Fri, 5 Jan 2024 15:09:21 +0800 you wrote: > >> From: Swee Leong Ching <leong.ching.swee@intel.com> > >> > >> Hi, > >> Add Per DMA Channel interrupt feature for DWXGMAC IP. > >> > >> Patchset (link below) contains per DMA channel interrupt, But it was > >> achieved. > >> https://lore.kernel.org/lkml/20230821203328.GA2197059- > >> robh@kernel.org/t/#m849b529a642e1bff89c05a07efc25d6a94c8bfb4 > >> > >> [...] > > > > Here is the summary with links: > > - [net-next,v2,1/4] dt-bindings: net: snps,dwmac: per channel irq > > https://git.kernel.org/netdev/net-next/c/67d47c8ada0f > > Please wait for DT bindings review a bit more than one working day (I > don't count Saturday and Sunday, because we all have some life...). +1. Would be very nice to have some more time to review the rest of the bits too. This would be specifically important for the STMMAC driver which doesn't currently have active maintainer. What about 5-10 work days to make sure that no comment would be submitted? Besides I thought that no features were supposed to be submitted during the merge window. Are we over the merge window already? (I might have lost track of time on the holidays.) Leong, next time before re-submitting your patchsets please wait for some more time than just two days. I waited for your response for almost two weeks. -Serge(y) > > Best regards, > Krzysztof > >
On Mon, 8 Jan 2024 00:24:24 +0300 Serge Semin wrote: > > Please wait for DT bindings review a bit more than one working day (I > > don't count Saturday and Sunday, because we all have some life...). > > +1. Sorry about that, reverting.
> -----Original Message----- > From: Serge Semin <fancer.lancer@gmail.com> > Sent: Monday, January 8, 2024 5:24 AM > To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Swee, Leong > Ching <leong.ching.swee@intel.com>; David S. Miller > <davem@davemloft.net> > Cc: patchwork-bot+netdevbpf@kernel.org; mcoquelin.stm32@gmail.com; > alexandre.torgue@foss.st.com; joabreu@synopsys.com; > davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > peppe.cavallaro@st.com; linux-stm32@st-md-mailman.stormreply.com; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > netdev@vger.kernel.org; devicetree@vger.kernel.org > Subject: Re: [PATCH net-next v2 0/4] net: stmmac: Enable Per DMA Channel > interrupt > > On Sun, Jan 07, 2024 at 08:06:55PM +0100, Krzysztof Kozlowski wrote: > > On 07/01/2024 17:40, patchwork-bot+netdevbpf@kernel.org wrote: > > > Hello: > > > > > > This series was applied to netdev/net-next.git (main) by David S. > > > Miller <davem@davemloft.net>: > > > > > > On Fri, 5 Jan 2024 15:09:21 +0800 you wrote: > > >> From: Swee Leong Ching <leong.ching.swee@intel.com> > > >> > > >> Hi, > > >> Add Per DMA Channel interrupt feature for DWXGMAC IP. > > >> > > >> Patchset (link below) contains per DMA channel interrupt, But it > > >> was achieved. > > >> https://lore.kernel.org/lkml/20230821203328.GA2197059- > > >> robh@kernel.org/t/#m849b529a642e1bff89c05a07efc25d6a94c8bfb4 > > >> > > >> [...] > > > > > > Here is the summary with links: > > > - [net-next,v2,1/4] dt-bindings: net: snps,dwmac: per channel irq > > > https://git.kernel.org/netdev/net-next/c/67d47c8ada0f > > > > Please wait for DT bindings review a bit more than one working day (I > > don't count Saturday and Sunday, because we all have some life...). > > +1. Would be very nice to have some more time to review the rest of > the bits too. This would be specifically important for the STMMAC driver > which doesn't currently have active maintainer. What about 5-10 work days > to make sure that no comment would be submitted? Besides I thought that > no features were supposed to be submitted during the merge window. Are > we over the merge window already? (I might have lost track of time on the > holidays.) > > Leong, next time before re-submitting your patchsets please wait for some > more time than just two days. I waited for your response for almost two > weeks. > > -Serge(y) > Sorry for that, will wait 5-10 days before resubmitting v3 patches. > > > > Best regards, > > Krzysztof > > > >
From: Swee Leong Ching <leong.ching.swee@intel.com> Hi, Add Per DMA Channel interrupt feature for DWXGMAC IP. Patchset (link below) contains per DMA channel interrupt, But it was achieved. https://lore.kernel.org/lkml/20230821203328.GA2197059- robh@kernel.org/t/#m849b529a642e1bff89c05a07efc25d6a94c8bfb4 Some of the changes in this patchset are based on reviewer comment on patchset mentioned beforehand. changelog v2: *extend irq_name array to 9 *add empty line after int i *avoid polluting rx_irq/tx_irq array with temporary variable *move tx/rx IRQ loop to bottom of stmmac_get_platform_resource() *rename stmmac_xx_queue_interrupt() to stmmac_dma_xx_interrupt() *fix error message in stmmac_request_irq_multi() *move STMMAC_FLAG_MULTI_IRQ_EN handling to glue driver Swee Leong Ching (4): dt-bindings: net: snps,dwmac: per channel irq net: stmmac: Make MSI interrupt routine generic net: stmmac: Add support for TX/RX channel interrupt net: stmmac: Use interrupt mode INTM=1 for per channel irq .../devicetree/bindings/net/snps,dwmac.yaml | 24 ++++++++++---- .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 +-- .../ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 ++ .../net/ethernet/stmicro/stmmac/dwmac4_dma.c | 2 +- .../net/ethernet/stmicro/stmmac/dwxgmac2.h | 3 ++ .../ethernet/stmicro/stmmac/dwxgmac2_dma.c | 32 +++++++++++-------- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 30 ++++++++--------- .../ethernet/stmicro/stmmac/stmmac_platform.c | 28 ++++++++++++++++ include/linux/stmmac.h | 4 +-- 9 files changed, 90 insertions(+), 40 deletions(-)