| Message ID | 20231219080021.2048889-1-kcfeng0@nuvoton.com |
|---|---|
| Headers | show |
| Series | hwmon: Driver for Nuvoton NCT7363Y | expand |
On 21/12/2023 01:44, Ban Feng wrote: > Hi Rob, > > On Tue, Dec 19, 2023 at 5:22 PM Rob Herring <robh@kernel.org> wrote: >> >> >> On Tue, 19 Dec 2023 16:00:20 +0800, baneric926@gmail.com wrote: >>> From: Ban Feng <kcfeng0@nuvoton.com> >>> >>> Adding bindings for the Nuvoton NCT7363Y Fan Controller >>> >>> Signed-off-by: Ban Feng <kcfeng0@nuvoton.com> >>> --- >>> .../bindings/hwmon/nuvoton,nct7363.yaml | 62 +++++++++++++++++++ >>> MAINTAINERS | 6 ++ >>> 2 files changed, 68 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > > Our design is based on [1], and adds fan-common.yaml to Nothing in the patch or cover letter described the dependency. Best regards, Krzysztof
Hi Krzysztof, On Thu, Dec 21, 2023 at 4:20 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 21/12/2023 01:44, Ban Feng wrote: > > Hi Rob, > > > > On Tue, Dec 19, 2023 at 5:22 PM Rob Herring <robh@kernel.org> wrote: > >> > >> > >> On Tue, 19 Dec 2023 16:00:20 +0800, baneric926@gmail.com wrote: > >>> From: Ban Feng <kcfeng0@nuvoton.com> > >>> > >>> Adding bindings for the Nuvoton NCT7363Y Fan Controller > >>> > >>> Signed-off-by: Ban Feng <kcfeng0@nuvoton.com> > >>> --- > >>> .../bindings/hwmon/nuvoton,nct7363.yaml | 62 +++++++++++++++++++ > >>> MAINTAINERS | 6 ++ > >>> 2 files changed, 68 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml > >>> > >> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > Our design is based on [1], and adds fan-common.yaml to > > Nothing in the patch or cover letter described the dependency. > ok, in v3, I'll attach a relevant patch and describe it in the cover letter. Thanks, Ban
From: Ban Feng <kcfeng0@nuvoton.com> NCT7363Y is an I2C based hardware monitoring chip from Nuvoton. Changes since version 1: - Modify NCT736X(nct736x) to NCT7363Y(nct7363) - Convert to devm_hwmon_device_register_with_info API - All ID tables are next to each other and should be consistent between i2c_device_id and of_device_id - Ref. fan-common.yaml and modify properties (nuvoton,pwm-mask/ nuvoton,fanin-mask) to (pwms/tach-ch) - Convert to devm_regmap_init_i2c API - Remove unused function (watchdog timer) - Fix uninitialized symbol which is reported by kernel test robot Ban Feng (2): dt-bindings: hwmon: Add NCT7363Y documentation hwmon: Driver for Nuvoton NCT7363Y .../bindings/hwmon/nuvoton,nct7363.yaml | 62 +++ Documentation/hwmon/index.rst | 1 + Documentation/hwmon/nct7363.rst | 33 ++ MAINTAINERS | 8 + drivers/hwmon/Kconfig | 11 + drivers/hwmon/Makefile | 1 + drivers/hwmon/nct7363.c | 515 ++++++++++++++++++ 7 files changed, 631 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml create mode 100644 Documentation/hwmon/nct7363.rst create mode 100644 drivers/hwmon/nct7363.c