mbox series

[v2,0/5] Add 2 rk3588 based boards from Cool Pi

Message ID 20231210080313.1667013-1-andyshrk@163.com
Headers show
Series Add 2 rk3588 based boards from Cool Pi | expand

Message

Andy Yan Dec. 10, 2023, 8:03 a.m. UTC
This series add support for rk3588s based SBC Cool Pi 4B
and rk3588 based board Cool Pi CM5 EVB

Changes in v2:
- change board compatible from "CoolPi 4 Model B" to "coolpi,pi-4b" for
  Cool Pi 4B
- change board compatible from "CoolPi CM5 EVB" to "coolpi,pi-cm5-evb"
  for Cool Pi CM5 EVB
- drop ununnecessary property status = "okay" for gpio-led
- drop ununnecessary blank line
- change node name to rtc for hym8563

Andy Yan (5):
  dt-bindings: vendor-prefixes: Add Cool Pi
  dt-bindings: arm: rockchip: Add Cool Pi 4B
  arm64: dts: rockchip: Add support for rk3588s based board Cool Pi 4B
  dt-bindings: arm: rockchip: Add Cool Pi CM5 EVB
  arm64: dts: rockchip: Add support for rk3588 based board Cool Pi CM5
    EVB

 .../devicetree/bindings/arm/rockchip.yaml     |  10 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/rockchip/Makefile         |   2 +
 .../dts/rockchip/rk3588-coolpi-cm5-evb.dts    | 887 ++++++++++++++++++
 .../boot/dts/rockchip/rk3588s-coolpi-4b.dts   | 840 +++++++++++++++++
 5 files changed, 1741 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts

Comments

Andy Yan Dec. 11, 2023, 7:46 a.m. UTC | #1
Hi Krzysztof:

At 2023-12-10 19:11:33, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> wrote:
>On 10/12/2023 09:06, Andy Yan wrote:
>> Add Cool Pi CM5 EVB, a board powered by RK3588
>> 
>> Signed-off-by: Andy Yan <andyshrk@163.com>
>> 
>> ---
>> 
>> Changes in v2:
>> - change board compatible from "CoolPi CM5 EVB" to "coolpi,pi-cm5-evb"
>> 
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 11d03035f3db..4da83bbd642a 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -95,6 +95,11 @@ properties:
>>            - const: chipspark,rayeager-px2
>>            - const: rockchip,rk3066a
>>  
>> +      - description: Cool Pi Compute Module 5(CM5) EVB
>> +        items:
>> +          - const: coolpi,pi-cm5-evb
>
>If it is module you are maybe missing here module DTSI and compatible.
>

Yes, it is a core board(CM5) + mother board = CM5 EVB,this is
the  variant I current have, I want to keep the dts as it is now,I will
convert it to a dtsi when I get another variant for this core board(CM5).

>Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>Best regards,
>Krzysztof
>
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel