| Message ID | 20231030-ipq5332-nsscc-v1-0-6162a2c65f0a@quicinc.com |
|---|---|
| Headers | show |
| Series | Add NSS clock controller support for IPQ5332 | expand |
On 30/10/2023 10:47, Kathiravan Thirumoorthy wrote:
> Build Qualcomm IPQ9574 NSSCC driver as module.
Why? Commit msg should answer this.
Best regards,
Krzysztof
On 30/10/2023 10:47, Kathiravan Thirumoorthy wrote: > Add NSSCC clock and reset definitions for IPQ5332. Qualcomm IPQ5332 This applies to all your patches in all your patchsets in entire Qualcomm organisation. You add code to common, upstream Linux kernel where hundreds of companies also contribute. Except me and few more folks, no one knows what is IPQ5332. Other 5000 developers do not know. Other millions of users do not know. > > Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 30.10.2023 10:47, Kathiravan Thirumoorthy wrote: > gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk are > enabled by default and it's RCG is properly configured by bootloader. The maskrom or something later on? > Some of the NSS clocks needs these clocks to be enabled. To avoid > these clocks being disabled by clock framework, drop these entries. Perhaps pm_clk could be an option for you? Konrad
On 10/30/2023 4:38 PM, Krzysztof Kozlowski wrote: > On 30/10/2023 10:47, Kathiravan Thirumoorthy wrote: >> Build Qualcomm IPQ9574 NSSCC driver as module. > > Why? Commit msg should answer this. Sure, will fix it in V2. > > Best regards, > Krzysztof >
Add bindings, driver and devicetree node for networking sub system clock controller on IPQ5332. Some of the nssnoc clocks present in GCC driver is enabled by default and its RCG is configured by bootloaders, so drop those clocks from GCC driver. The NSS clock controller driver depends on the below patchset which adds support for multiple configurations for same frequency. https://lore.kernel.org/linux-arm-msm/20230531222654.25475-1-ansuelsmth@gmail.com/ Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com> --- Kathiravan Thirumoorthy (8): clk: qcom: ipq5332: drop the few nssnoc clocks dt-bindings: clock: ipq5332: drop the few nss clocks definition dt-bindings: clock: ipq5332: add definition for GPLL0_OUT_AUX clock clk: qcom: ipq5332: add gpll0_out_aux clock dt-bindings: clock: add IPQ5332 NSSCC clock and reset definitions clk: qcom: add NSS clock Controller driver for IPQ5332 arm64: dts: qcom: ipq5332: add support for the NSSCC arm64: defconfig: build NSS Clock Controller driver for IPQ5332 .../bindings/clock/qcom,ipq5332-nsscc.yaml | 60 ++ arch/arm64/boot/dts/qcom/ipq5332.dtsi | 28 + arch/arm64/configs/defconfig | 1 + drivers/clk/qcom/Kconfig | 7 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-ipq5332.c | 71 +- drivers/clk/qcom/nsscc-ipq5332.c | 1035 ++++++++++++++++++++ include/dt-bindings/clock/qcom,ipq5332-gcc.h | 4 +- include/dt-bindings/clock/qcom,ipq5332-nsscc.h | 86 ++ 9 files changed, 1233 insertions(+), 60 deletions(-) --- base-commit: c503e3eec382ac708ee7adf874add37b77c5d312 change-id: 20231030-ipq5332-nsscc-aeac9e153045 Best regards,