| Message ID | 20230717172651.64324-1-sebastian.reichel@collabora.com |
|---|---|
| Headers | show |
| Series | RK3588 PCIe2 support | expand |
On Mon, Jul 17, 2023 at 07:26:47PM +0200, Sebastian Reichel wrote: > Allow missing "msi" interrupt, iff the node has a "msi-map" property. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../devicetree/bindings/pci/snps,dw-pcie.yaml | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > index 1a83f0f65f19..abc1bcef13ec 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > @@ -25,6 +25,15 @@ select: > allOf: > - $ref: /schemas/pci/pci-bus.yaml# > - $ref: /schemas/pci/snps,dw-pcie-common.yaml# > + - if: > + not: > + required: > + - msi-map > + then: > + properties: > + interrupt-names: > + contains: > + const: "msi" Don't need quotes. > > properties: > reg: > @@ -193,9 +202,6 @@ properties: > oneOf: > - description: See native "app" IRQ for details > enum: [ intr ] > - allOf: > - - contains: > - const: msi > > additionalProperties: true > > -- > 2.40.1 >
Hi, This adds PCIe v2 support for RK3588. The series has been tested with the onboard RTL8125 network card on Rockchip RK3588 EVB1 (&pcie2x1l1) and Radxa Rock 5B (&pcie2x1l2). Changes since v2: * https://lore.kernel.org/all/20230713171851.73052-1-sebastian.reichel@collabora.com/ * Removed num-ib-windows/num-ob-windows/num-viewport from DT * Added patch making 'msi' irq optional, if 'msi-map' property is available * Updated binding according two discussion with Serge Semin, I provided two options by adding one extra patch that should be squashed into the main one or dropped depending on preferences from DT binding maintainers. * Collected Reviewed-by/Tested-by from Jagan Teki Changes since v1: * https://lore.kernel.org/all/20230616170022.76107-1-sebastian.reichel@collabora.com/ * Dropped patch adding 'RK3588' (queued by Rob) * Updated patch adding legacy-interrupt-controller according to comments from Rob and Serge - added missing additionalProperties: false - added all properties to new required property - removed useless quotes around interrupt-controller - added Rob's Reviewed-by * Updated patch adding the missing RK356x/RK3588 interrupt names, so that it provides more details about the interrupts * Updated the DT patch according to the comment from Jonas Karlman, so that the addresses are in 32 bit address space starting at 0x40000000 [0] https://lore.kernel.org/all/20230612171337.74576-1-sebastian.reichel@collabora.com/ Thanks, -- Sebastian Sebastian Reichel (5): dt-bindings: PCI: dwc: improve msi handling dt-bindings: PCI: dwc: rockchip: Fix interrupt-names issue dt-bindings: PCI: dwc: rockchip: Use generic binding dt-bindings: PCI: dwc: rockchip: Add missing legacy-interrupt-controller arm64: dts: rockchip: rk3588: add PCIe2 support .../bindings/pci/rockchip-dw-pcie.yaml | 70 ++++++++++++ .../devicetree/bindings/pci/snps,dw-pcie.yaml | 18 +++- arch/arm64/boot/dts/rockchip/rk3588.dtsi | 51 +++++++++ arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 102 ++++++++++++++++++ 4 files changed, 237 insertions(+), 4 deletions(-)