| Message ID | 20230713095127.1230109-1-huaqian.li@siemens.com |
|---|---|
| Headers | show |
| Series | Add support for WDIOF_CARDRESET on TI AM65x | expand |
On 17:51-20230713, huaqian.li@siemens.com wrote: > From: Li Hua Qian <huaqian.li@siemens.com> I guess I should be explicit about this: Lets keep this dts patch as "DONOTMERGE" in subject line for driver subsystem maintainer (I don't want a repeat of cpufreq maintainers picking up dts and associated warnings that are now pending fixes), resubmit at next rc1 and I can queue up the dts once the maintainers pick up the driver and bindings. Ref: https://lore.kernel.org/all/20230714084725.27847-1-krzysztof.kozlowski@linaro.org/ > > This patch adds a reserved memory for the TI AM65X platform watchdog to > reserve the specific info, triggering the watchdog reset in last boot, > to know if the board reboot is due to a watchdog reset. > > Signed-off-by: Li Hua Qian <huaqian.li@siemens.com> > --- > arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi > index e26bd988e522..4bb20d493651 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi > @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 { > alignment = <0x1000>; > no-map; > }; > + > + /* To reserve the power-on(PON) reason for watchdog reset */ > + wdt_reset_memory_region: wdt-memory@a2200000 { > + reg = <0x00 0xa2200000 0x00 0x1000>; > + no-map; > + }; > }; > > leds { > @@ -718,3 +724,7 @@ &mcu_r5fss0_core1 { > <&mcu_r5fss0_core1_memory_region>; > mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>; > }; > + > +&mcu_rti1 { > + memory-region = <&wdt_reset_memory_region>; > +}; > -- > 2.34.1 >
On 7/14/23 15:52, Nishanth Menon wrote: > On 17:51-20230713, huaqian.li@siemens.com wrote: >> From: Li Hua Qian <huaqian.li@siemens.com> > > I guess I should be explicit about this: Lets keep this dts patch as > "DONOTMERGE" in subject line for driver subsystem maintainer (I don't > want a repeat of cpufreq maintainers picking up dts and associated > warnings that are now pending fixes), resubmit at next rc1 and I can > queue up the dts once the maintainers pick up the driver and bindings. > FWIW, I never pick up patches outside drivers/hwmon without explicit Ack from responsible maintainers (and most definitely not dts patches unless a maintainer responsible for the file(s) specifically asks me to do it (which I think never happened). Guenter > Ref: https://lore.kernel.org/all/20230714084725.27847-1-krzysztof.kozlowski@linaro.org/ > >> >> This patch adds a reserved memory for the TI AM65X platform watchdog to >> reserve the specific info, triggering the watchdog reset in last boot, >> to know if the board reboot is due to a watchdog reset. >> >> Signed-off-by: Li Hua Qian <huaqian.li@siemens.com> >> --- >> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >> index e26bd988e522..4bb20d493651 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >> @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 { >> alignment = <0x1000>; >> no-map; >> }; >> + >> + /* To reserve the power-on(PON) reason for watchdog reset */ >> + wdt_reset_memory_region: wdt-memory@a2200000 { >> + reg = <0x00 0xa2200000 0x00 0x1000>; >> + no-map; >> + }; >> }; >> >> leds { >> @@ -718,3 +724,7 @@ &mcu_r5fss0_core1 { >> <&mcu_r5fss0_core1_memory_region>; >> mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>; >> }; >> + >> +&mcu_rti1 { >> + memory-region = <&wdt_reset_memory_region>; >> +}; >> -- >> 2.34.1 >> >
On 16:27-20230714, Guenter Roeck wrote: > On 7/14/23 15:52, Nishanth Menon wrote: > > On 17:51-20230713, huaqian.li@siemens.com wrote: > > > From: Li Hua Qian <huaqian.li@siemens.com> > > > > I guess I should be explicit about this: Lets keep this dts patch as > > "DONOTMERGE" in subject line for driver subsystem maintainer (I don't > > want a repeat of cpufreq maintainers picking up dts and associated > > warnings that are now pending fixes), resubmit at next rc1 and I can > > queue up the dts once the maintainers pick up the driver and bindings. > > > > FWIW, I never pick up patches outside drivers/hwmon without explicit Ack > from responsible maintainers (and most definitely not dts patches unless > a maintainer responsible for the file(s) specifically asks me to do it > (which I think never happened). Oops Guenter, didn't mean to indicate your tree :( -> just wanted to ensure that developers are clearly aware of what happens with cross posting series involving multiple maintainers and level set their expectations. Saves a bunch of private pings later on :)
From: Li Hua Qian <huaqian.li@siemens.com> The watchdog hardware of TI AM65X platform does not support WDIOF_CARDRESET feature, add a reserved memory to save the watchdog reset cause, to know if the board reboot is due to a watchdog reset. Changes in v3: - Add memory-region back for the reserved memory, and remove reserved memory from the watchdog IO address space. - Add changelog. - Link to v2: https://lore.kernel.org/linux-watchdog/20230711091713.1113010-1-huaqian.li@siemens.com Changes in v2: - Remove memory-region and memory-size properties, and bind the reserved memory to watchdog IO address space. - Remove the unnecessary rti_wdt_ioctl. - Fix the mail list - Link to v1: https://lore.kernel.org/all/3137d87e56ef75ba0b8a923d407b2fecace6ccbd.camel@siemens.com/ v1 had a wrong mail list at the beginning, and the mail thread was messed up. Li Hua Qian (3): dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET arm64: dts: ti: Add reserved memory for watchdog watchdog:rit_wdt: Add support for WDIOF_CARDRESET .../bindings/watchdog/ti,rti-wdt.yaml | 12 +++++ .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 10 ++++ drivers/watchdog/rti_wdt.c | 51 +++++++++++++++++++ 3 files changed, 73 insertions(+)