mbox series

[0/7] random msm bindings fixes

Message ID 20230626-topic-bindingsfixups-v1-0-254ae8642e69@linaro.org
Headers show
Series random msm bindings fixes | expand

Message

Konrad Dybcio June 26, 2023, 8 p.m. UTC 
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (7):
      dt-bindings: qcom: Allow SoC names ending in "pro"
      dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks
      arm64: dts: qcom: pm6150l: Add missing short interrupt
      arm64: dts: qcom: pm660l: Add missing short interrupt
      arm64: dts: qcom: pmi8950: Add missing OVP interrupt
      arm64: dts: qcom: pmi8994: Add missing OVP interrupt
      arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3

 Documentation/devicetree/bindings/arm/qcom-soc.yaml                | 2 +-
 .../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml       | 7 +++----
 arch/arm64/boot/dts/qcom/pm6150l.dtsi                              | 5 +++--
 arch/arm64/boot/dts/qcom/pm660l.dtsi                               | 5 +++--
 arch/arm64/boot/dts/qcom/pmi8950.dtsi                              | 5 +++--
 arch/arm64/boot/dts/qcom/pmi8994.dtsi                              | 5 +++--
 arch/arm64/boot/dts/qcom/sc8180x.dtsi                              | 1 +
 7 files changed, 17 insertions(+), 13 deletions(-)
---
base-commit: 3eedd211ad93c322fb360b83a3d76a2c6cd622dc
change-id: 20230626-topic-bindingsfixups-93d737dbf054

Best regards,

Comments

Konrad Dybcio June 26, 2023, 8:18 p.m. UTC | #1 
On 26.06.2023 22:17, Luca Weiss wrote:
> On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
>> Add the missing short interrupt. This fixes the schema warning:
>>
>> wled@d800: interrupt-names: ['ovp'] is too short
>>
>> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
>> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
>> 100644
>> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
>> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
>>  		pm6150l_wled: leds@d800 {
>>  			compatible = "qcom,pm6150l-wled";
>>  			reg = <0xd800>, <0xd900>;
>> -			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
>> -			interrupt-names = "ovp";
>> +			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
>> +				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
>> +			interrupt-names = "ovp", "short";
> 
> Are you sure this interrupt really exists? It's not a thing used downstream at
> least:
> https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293
> 
Confirmed with a reliable source.

Konrad
> Regards
> Luca
> 
>>  			label = "backlight";
>>
>>  			status = "disabled";
> 
> 
> 
>
Luca Weiss June 26, 2023, 8:26 p.m. UTC | #2 
On Montag, 26. Juni 2023 22:18:11 CEST Konrad Dybcio wrote:
> On 26.06.2023 22:17, Luca Weiss wrote:
> > On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
> >> Add the missing short interrupt. This fixes the schema warning:
> >> 
> >> wled@d800: interrupt-names: ['ovp'] is too short
> >> 
> >> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >> ---
> >> 
> >>  arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
> >> 100644
> >> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
> >> 
> >>  		pm6150l_wled: leds@d800 {
> >>  		
> >>  			compatible = "qcom,pm6150l-wled";
> >>  			reg = <0xd800>, <0xd900>;
> >> 
> >> -			interrupts = <0x5 0xd8 0x1 
IRQ_TYPE_EDGE_RISING>;
> >> -			interrupt-names = "ovp";
> >> +			interrupts = <0x5 0xd8 0x1 
IRQ_TYPE_EDGE_RISING>,
> >> +				     <0x5 0xd8 0x2 
IRQ_TYPE_EDGE_RISING>;
> >> +			interrupt-names = "ovp", "short";
> > 
> > Are you sure this interrupt really exists? It's not a thing used
> > downstream at least:
> > https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/
> > android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293
> Confirmed with a reliable source.

Fine by me then.

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

> 
> Konrad
> 
> > Regards
> > Luca
> > 
> >>  			label = "backlight";
> >>  			
> >>  			status = "disabled";
Rob Herring (Arm) June 26, 2023, 9:27 p.m. UTC | #3 
On Mon, Jun 26, 2023 at 10:00:23PM +0200, Konrad Dybcio wrote:
> There are a couple of SoCs whose names end in "pro", with the currently-
> upstream examples being msm8974pro and msm8996pro. Allow such suffix in
> SoC-specific compatibles.
> 
> Fixes: 5aa332c5e7ca ("dt-bindings: qcom: document preferred compatible naming")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom-soc.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index e333ec4a9c5f..607a1cf1ef94 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -31,7 +31,7 @@ properties:
>    compatible:
>      oneOf:
>        # Preferred naming style for compatibles of SoC components:
> -      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$"
> +      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+(pro|)-.*$"

"(pro)?" would be slightly better than "(pro|)" IMO.

Acked-by: Rob Herring <robh@kernel.org>

>        - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
>  
>        # Legacy namings - variations of existing patterns/compatibles are OK,
> 
> -- 
> 2.41.0
>
Bjorn Andersson July 14, 2023, 5:48 a.m. UTC | #4 
On Mon, 26 Jun 2023 22:00:22 +0200, Konrad Dybcio wrote:
> 


Applied, thanks!

[3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt
      commit: 7e1f024ef0d1da456f61d00f01dc3287ede915b3
[4/7] arm64: dts: qcom: pm660l: Add missing short interrupt
      commit: 9a4ac09db3c7413e334b4abd6b2f6de8930dd781
[5/7] arm64: dts: qcom: pmi8950: Add missing OVP interrupt
      commit: 4d77b639531fd85b84a7079c3369908dfaddf8b2
[6/7] arm64: dts: qcom: pmi8994: Add missing OVP interrupt
      commit: 8db94432690371b1736e9a2566a9b3d8a73d5a97
[7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3
      commit: e4322bb818bbcd36b441de9880fa4ac911a5eb51

Best regards,