mbox series

[v7,0/4] dt-bindings: mtd: marvell-nand: Add YAML scheme

Message ID 20230530235456.1009082-1-chris.packham@alliedtelesis.co.nz
Headers show
Series dt-bindings: mtd: marvell-nand: Add YAML scheme | expand

Message

Chris Packham May 30, 2023, 11:54 p.m. UTC
Add YAML scheme for the Marvell's NAND controller
to validate it's DT bindings. Old txt file is deleted,
not included the compatibles and properties which were marked as
deprecated.

Also fix node name in cp11x DTSI acording to nand-controller.yaml

I've picked up this series to hopefully get it over the line. I think I've
addressed all the feedback from the last round of review.

As of v7 I've re-ordered the patches so the fixups for the device trees come
before the schema so if the series is applied in order the various checkers
should pass cleanly.

Chris Packham (2):
  ARM: dts: mvebu: align MTD partition nodes to dtschema
  dt-bindings: mtd: marvell-nand: Remove deprecated compatibles

Vadym Kochan (2):
  arm64: dts: marvell: cp11x: Fix nand_controller node name according to
    YAML
  dt-bindings: mtd: marvell-nand: Convert to YAML DT scheme

 .../bindings/mtd/marvell,nand-controller.yaml | 218 ++++++++++++++++++
 .../devicetree/bindings/mtd/marvell-nand.txt  | 126 ----------
 MAINTAINERS                                   |   1 -
 arch/arm/boot/dts/armada-385-atl-x530.dts     |  14 +-
 arch/arm64/boot/dts/marvell/armada-cp11x.dtsi |   2 +-
 5 files changed, 226 insertions(+), 135 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
 delete mode 100644 Documentation/devicetree/bindings/mtd/marvell-nand.txt

Comments

Chris Packham May 31, 2023, 10:36 p.m. UTC | #1
On 31/05/23 19:33, Miquel Raynal wrote:
> Hi Chris,
>
> chris.packham@alliedtelesis.co.nz wrote on Wed, 31 May 2023 11:54:56
> +1200:
>
>> Remove compatible values that were marked as deprecated in the old text
>> binding.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> ---
>>   .../devicetree/bindings/mtd/marvell,nand-controller.yaml       | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
>> index 7cd4a2e99343..80ce854291cb 100644
>> --- a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
>> @@ -18,9 +18,6 @@ properties:
>>         - enum:
>>             - marvell,armada370-nand-controller
>>             - marvell,pxa3xx-nand-controller
>> -          - marvell,armada-8k-nand
>> -          - marvell,armada370-nand
>> -          - marvell,pxa3xx-nand
> Not sure what you're doing here?
That's me being in an awkward timezone and guessing (badly). I think 
I've got the deprecated compatibles sorted now so I'll drop this from v8.
>   I would actually expect these three
> lines to have something along:
>
>                   deprecated: true
>
> and this should be part of the conversion to yaml. Or perhaps I am
> missing something?
>
> The rest of the series looks good to me.
>
>>   
>>     reg:
>>       maxItems: 1
>
> Thanks,
> Miquèl