| Message ID | 20230510-feature-ts_virtobj_patch-v1-0-5ae5e81bc264@wolfvision.net |
|---|---|
| Headers | show |
| Series | Input: support virtual objects on touchscreens | expand |
On 10.05.23 16:59, Krzysztof Kozlowski wrote: > On Wed, 10 May 2023 15:50:49 +0200, Javier Carrasco wrote: >> The st1232 driver supports the virtual-touchscreen and virtual-buttons >> objects defined in the generic touchscreen bindings and implemented in >> the ts-virtobj module. Add an example where nodes for a virtual >> touchscreen and virtual buttons are defined. >> >> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> >> --- >> .../input/touchscreen/sitronix,st1232.yaml | 40 ++++++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.example.dtb: touchscreen@55: Unevaluated properties are not allowed ('virtual-buttons', 'virtual-touchscreen' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml > Thanks for your feedback. This patch depends on: 'PATCH 2/4: dt-bindings: touchscreen: add virtual-touchscreen and virtual-buttons properties' from the same series, where 'virtual-buttons' and 'virtual-touchscreen' are defined in 'touchscreen.yaml'. I could only reproduce the error after reverting the patch it depends on. Otherwise it passes the tests successfully and with no warning reports with dt-schema 04.2023 and yamllint 1.31.0 > See https://patchwork.ozlabs.org/patch/1779521 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit.
Some touchscreens are shipped with a physical layer on top of them where a number of buttons and a resized touchscreen surface might be available. In order to generate proper key events by overlay buttons and adjust the touch events to a clipped surface, these patches offer a documented, device-tree-based solution by means of helper functions. An implementation for a specific touchscreen driver is also included. The functions in ts-virtobj provide a simple workflow to acquire physical objects from the device tree, map them into the device driver structures as virtual objects and generate events according to the object descriptions. This solution has been tested with a JT240MHQS-E3 display, which uses the st1624 as a touchscreen and provides two overlay buttons and a frame that clips its effective surface. Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> --- Javier Carrasco (4): Input: ts-virtobj - Add touchsreen virtual object handling dt-bindings: touchscreen: add virtual-touchscreen and virtual-buttons properties Input: st1232 - add virtual touchscreen and buttons handling dt-bindings: input: touchscreen: st1232: add example with ts-virtobj .../input/touchscreen/sitronix,st1232.yaml | 40 +++ .../bindings/input/touchscreen/touchscreen.yaml | 54 ++++ MAINTAINERS | 7 + drivers/input/touchscreen/Kconfig | 9 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/st1232.c | 87 +++-- drivers/input/touchscreen/ts-virtobj.c | 360 +++++++++++++++++++++ include/linux/input/ts-virtobj.h | 95 ++++++ 8 files changed, 635 insertions(+), 18 deletions(-) --- base-commit: ac9a78681b921877518763ba0e89202254349d1b change-id: 20230510-feature-ts_virtobj_patch-e267540aae74 Best regards,