mbox series

[0/2] r8a779a0: enable PWM

Message ID 20230502170618.55967-1-wsa+renesas@sang-engineering.com
Headers show
Series r8a779a0: enable PWM | expand

Message

Wolfram Sang May 2, 2023, 5:06 p.m. UTC 
Having another look at the specs, I finally discovered a testpoint (CP2)
which we could use to test PWM4 on a Falcon board. Thanks go to Kieran
for setting up the scope and do the actual testing. This was the last
missing V3U bit from my side, hooray!

Phong Hoang (1):
  arm64: dts: renesas: r8a779a0: Add PWM nodes

Wolfram Sang (1):
  clk: renesas: r8a779a0: Add PWM clock

 arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 50 +++++++++++++++++++++++
 drivers/clk/renesas/r8a779a0-cpg-mssr.c   |  1 +
 2 files changed, 51 insertions(+)

Comments

Kieran Bingham May 3, 2023, 7:38 p.m. UTC | #1 
Quoting Geert Uytterhoeven (2023-05-03 11:14:52)
> Hi Wolfram,
> 
> On Tue, May 2, 2023 at 7:06 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > From: Phong Hoang <phong.hoang.wz@renesas.com>
> >
> > This patch adds PWM nodes for R-Car V3U (r8a779a0) SoC.
> >
> > Signed-off-by: Phong Hoang <phong.hoang.wz@renesas.com>
> > [wsa: rebased]
> > Tested-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v6.5.
> 
> > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > @@ -1108,6 +1108,56 @@ msiof5: spi@e6c28000 {
> >                         status = "disabled";
> >                 };
> >
> > +               pwm0: pwm@e6e30000 {
> 
> I'll move this before serial@e6e60000 while applying, to preserve sort
> order (by unit address).

I still wonder when we can have nice tools that will sort DT and format
DT files for us!


Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds