From patchwork Tue Apr 18 09:03:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Paracuellos X-Patchwork-Id: 675369 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94327C77B76 for ; Tue, 18 Apr 2023 09:03:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230357AbjDRJDf (ORCPT ); Tue, 18 Apr 2023 05:03:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231233AbjDRJDY (ORCPT ); Tue, 18 Apr 2023 05:03:24 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DCD15BA7; Tue, 18 Apr 2023 02:03:16 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id gw13so15150265wmb.3; Tue, 18 Apr 2023 02:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681808594; x=1684400594; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qq2Q2tk9q20ZsHUF956GXs78KCpVDJ6rH1bHkjjZwGc=; b=qQHF4YLiKxjqYN/aHsHrx357il4DxWI5STZ8jf/00e70uLcmXJaipA1RwKs86KYwLb tGzl+wKZ2Y3wkkG0HWmoAVqbTp+PnMFyRwre78hN5NNIrY7Yyh2nhOMMKaMGMkgwxVKw v+z6GAuvq49m1TjRNUJKiOqHj8+OSohukzQ0ZQSigqZU2bDPuBLqququu1V7NvE6tGL2 cguQbaduydLiTaTL9wzv1og/pUlXWk3gvaRoO0hGuCkKOeJIwAVkXsYiN2n1+L1ivJ+f /fo7Ay1jpkXfkLgnwgJl2F+PEpHrCZgQM5whG2sV1OH6FgOnI9xjYhNsvYLfrlb0ZbDF nVbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681808594; x=1684400594; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qq2Q2tk9q20ZsHUF956GXs78KCpVDJ6rH1bHkjjZwGc=; b=XucKtiTv6+3qHI2mP3pk/2jGYo1qgKcAvUCZkYgF1UluVELfFph5dYQBKJlPi8AZA/ 8bWLzTKUoioB2fQ7VjA1HLd1ncNhi1u70PJc+7weBUAagl9Wj7E5zBvZZMdBFb0Lom6X tN0LW+WpWA/Eyy9NkKv/F1rrgq0ECgdVd60Cz1wnuaB/QYdngxtd8n/2GDyZQO9C0qTr ZKEPJlbK+Q7hYMzmfP02NTl2bxh7jkCviK6zw726dgGS6LX3RH4OChAxH9OI0LFAxP/U q6cVih0cOpV//cT3dp8E0AFr27oBCkbb055l5dxyiukwhX0PD52BAH0mSmZd2nMJVCGX uPxg== X-Gm-Message-State: AAQBX9extnzGBulT+UUInnhCK1M70MHEv/q66IRE573jH7cuUKvlQ7Ty gqmCOsR3bh671UjyE7MolUICsMHgAa8= X-Google-Smtp-Source: AKy350ZoKrwnkjorG3phJ0G+UZ0OyNs5kprNSu8aCeLz6s09X6LUT7/XDqa+2DmDeWsHdO7DK7t7Yg== X-Received: by 2002:a05:600c:22d9:b0:3f1:72ee:97b7 with SMTP id 25-20020a05600c22d900b003f172ee97b7mr5807116wmg.15.1681808594245; Tue, 18 Apr 2023 02:03:14 -0700 (PDT) Received: from localhost.localdomain (61.red-88-10-54.dynamicip.rima-tde.net. [88.10.54.61]) by smtp.gmail.com with ESMTPSA id u7-20020a7bcb07000000b003ee70225ed2sm14341109wmj.15.2023.04.18.02.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 02:03:13 -0700 (PDT) From: Sergio Paracuellos To: linux-clk@vger.kernel.org Cc: linux-mips@vger.kernel.org, tsbogend@alpha.franken.de, john@phrozen.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, arinc.unal@arinc9.com Subject: [PATCH v3 0/9] mips: ralink: add complete clock and reset driver for mtmips SoCs Date: Tue, 18 Apr 2023 11:03:03 +0200 Message-Id: <20230418090312.2818879-1-sergio.paracuellos@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi all! This patchset is a big effort to properly implement a clock and reset driver for old ralink SoCs. This allow to properly define clocks in device tree and avoid to use fixed-clocks directly from 'arch/mips/ralink' architecture directory code. Device tree 'sysc' node will be both clock and reset provider using 'clock-cells' and 'reset-cells' properties. The ralink SoCs we are taking about are RT2880, RT3050, RT3052, RT3350, RT3352, RT3883, RT5350, MT7620, MT7628 and MT7688. Mostly the code in this new driver has been extracted from 'arch/mips/ralink' and cleanly put using kernel clock and reset driver APIs. The clock plans for this SoCs only talks about relation between CPU frequency and BUS frequency. This relation is different depending on the particular SoC. CPU clock is derived from XTAL frequencies. Depending on the SoC we have the following frequencies: * RT2880 SoC: - XTAL: 40 MHz. - CPU: 250, 266, 280 or 300 MHz. - BUS: CPU / 2 MHz. * RT3050, RT3052, RT3350: - XTAL: 40 MHz. - CPU: 320 or 384 MHz. - BUS: CPU / 3 MHz. * RT3352: - XTAL: 40 MHz. - CPU: 384 or 400 MHz. - BUS: CPU / 3 MHz. - PERIPH: 40 MHz. * RT3383: - XTAL: 40 MHz. - CPU: 250, 384, 480 or 500 MHz. - BUS: Depends on RAM Type and CPU: + RAM DDR2: 125. ELSE 83 MHz. + RAM DDR2: 128. ELSE 96 MHz. + RAM DDR2: 160. ELSE 120 MHz. + RAM DDR2: 166. ELSE 125 MHz. * RT5350: - XTAL: 40 MHz. - CPU: 300, 320 or 360 MHz. - BUS: CPU / 3, CPU / 4, CPU / 3 MHz. - PERIPH: 40 MHz. * MT7628 and MT7688: - XTAL: 20 MHz or 40 MHz. - CPU: 575 or 580 MHz. - BUS: CPU / 3. - PCMI2S: 480 MHz. - PERIPH: 40 MHz. * MT7620: - XTAL: 20 MHz or 40 MHz. - PLL: XTAL, 480, 600 MHz. - CPU: depends on PLL and some mult and dividers. - BUS: depends on PLL and some mult and dividers. - PERIPH: 40 or XTAL MHz. MT7620 is a bit more complex deriving CPU clock from a PLL and an bunch of register reads and predividers. To derive CPU and BUS frequencies in the MT7620 SoC 'mt7620_calc_rate()' helper is used. In the case XTAL can have different frequencies and we need a different clock frequency for peripherals 'periph' clock in introduced. The rest of the peripherals present in the SoC just follow their parent frequencies. I am using 'mtmips' inside for ralink clock driver. This is aligned with pinctrl series recently merged through pinctrl git tree [0]. I am maintaining ralink as prefix for compatible strings after discussions between Rob and Arinc in v2 of this series [1]. Changes have been compile tested for: - RT2880 - RT3883 - MT7620 Changes have been properly tested in RT5350 SoC based board (ALL5003 board) resulting in a working platform. Dts files for these SoCs in-tree except MT7621 are incomplete. We are planning to align with openWRT files at some point and add extra needed changes. Hence I am not touching them at all in these series. If this is a problem, please let me know and I will update them. Talking about merging this series I'd like all of the patches going through the MIPS tree if possible. Thanks in advance for your time. Best regards, Sergio Paracuellos Changes in v3: - Address Stephen comments in v2: + Drop unsused include ''. + Add fixed and factor clocks when it makes sense. + Make 'mtmips_periph_clk_ops' named variable. + WARN_ON -> WARN_ON_ONCE. + Avoid CONFIG_USB dependent code. Introduce new 'mtmips_clk_regs_init'. + Don't validate the bindings in the driver. + Make const 'struct clk_init_data' used inside macros. + do_div -> div_u64. + Make use of dev_err_probe. Changes in v2: - Address bindings documentation changes pointed out by Krzysztof: + Rename the file into 'mediatek,mtmips-sysc.yaml'. + Redo commit subject and log message. + Order compatibles alphabetically. + Redo bindings description taking into account this is a system controller node which provides both clocks and resets to the world. + Drop label from example. + Use 'syscon' as node name in example. + Drop no sense 'ralink,rt2880-reset' compatible string - Squash patches 6 and 7 together as pointed out by Stephen Boyd. Previoous series: v2: https://lore.kernel.org/linux-clk/CAMhs-H-BfZb3mD8E=LeJ4vT22uibQ1DnaZsfTrtRxSiv=8L5RA@mail.gmail.com/T/#t v1: https://lore.kernel.org/linux-clk/20230320161823.1424278-1-sergio.paracuellos@gmail.com/T/#t [0]: https://lore.kernel.org/linux-gpio/e9e6ad87-2db5-9767-ff39-64a302b06185@arinc9.com/T/#t [1]: https://lore.kernel.org/linux-clk/CAMhs-H-BfZb3mD8E=LeJ4vT22uibQ1DnaZsfTrtRxSiv=8L5RA@mail.gmail.com/T/#mfe725b6e3382c6fb09736472a846cbbc84f264dc Sergio Paracuellos (9): dt-bindings: clock: add mtmips SoCs system controller clk: ralink: add clock and reset driver for MTMIPS SoCs mips: ralink: rt288x: remove clock related code mips: ralink: rt305x: remove clock related code mips: ralink: rt3883: remove clock related code mips: ralink: mt7620: remove clock related code mips: ralink: remove reset related code mips: ralink: get cpu rate from new driver code MAINTAINERS: add Mediatek MTMIPS Clock maintainer .../bindings/clock/mediatek,mtmips-sysc.yaml | 65 + MAINTAINERS | 6 + arch/mips/include/asm/mach-ralink/mt7620.h | 35 - arch/mips/include/asm/mach-ralink/rt288x.h | 10 - arch/mips/include/asm/mach-ralink/rt305x.h | 21 - arch/mips/include/asm/mach-ralink/rt3883.h | 8 - arch/mips/ralink/clk.c | 26 +- arch/mips/ralink/common.h | 5 - arch/mips/ralink/mt7620.c | 226 ---- arch/mips/ralink/of.c | 4 - arch/mips/ralink/reset.c | 61 - arch/mips/ralink/rt288x.c | 31 - arch/mips/ralink/rt305x.c | 78 -- arch/mips/ralink/rt3883.c | 44 - drivers/clk/ralink/Kconfig | 7 + drivers/clk/ralink/Makefile | 1 + drivers/clk/ralink/clk-mtmips.c | 1134 +++++++++++++++++ 17 files changed, 1232 insertions(+), 530 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml create mode 100644 drivers/clk/ralink/clk-mtmips.c