| Message ID | 20230403-da9063-disable-unused-v3-0-cc4dc698864c@skidata.com |
|---|---|
| Headers | show |
| Series | regulator: da9063: disable unused voltage monitors | expand |
On Wed, 05 Apr 2023 19:14:33 +0200, Benjamin Bara wrote: > Follow-up for my initial patch regarding the disabling of unused > voltage monitors. We use the PWR_OK functionality, which asserts GP_FB2 > if every monitored voltage is in range. This patch should provide the > possibility to deactivate a voltage monitor from the DT if the regulator > might be disabled during run time. For this purpose, the regulator > notification support is used: > https://lore.kernel.org/all/cover.1622628333.git.matti.vaittinen@fi.rohmeurope.com/ > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/3] regulator: da9063: add voltage monitoring registers commit: 13186dae182ab1a2a52a53424672f49cf3e81f9b [2/3] regulator: da9063: implement setter for voltage monitoring commit: b8717a80e6ee6500ae396d21aac2a00947bba993 [3/3] dt-bindings: mfd: dlg,da9063: document voltage monitoring commit: 0271b61ba3bb06fff4726951667f46e68412b8c2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Wed, 05 Apr 2023, Benjamin Bara wrote: > From: Benjamin Bara <benjamin.bara@skidata.com> > > Document that the da9063 only provides under- *and* over-voltage > monitoring in one, and therefore requires both to be configured with the > same severity and value. Add an example for clarification. > > Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com> > --- > Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) Applied, thanks
Hi! Follow-up for my initial patch regarding the disabling of unused voltage monitors. We use the PWR_OK functionality, which asserts GP_FB2 if every monitored voltage is in range. This patch should provide the possibility to deactivate a voltage monitor from the DT if the regulator might be disabled during run time. For this purpose, the regulator notification support is used: https://lore.kernel.org/all/cover.1622628333.git.matti.vaittinen@fi.rohmeurope.com/ v2: https://lore.kernel.org/r/20230403-da9063-disable-unused-v2-0-2f1bd2a2434a@skidata.com --- Changelog: v3: 2: - add clarifications, reword XVP to voltage monitoring - improve error messages - ensure that only one severity is set 3: - document that ov and uv require same severity and level v2: - reworked solution, based on Adam Thomson's feedback --- Benjamin Bara (3): regulator: da9063: add voltage monitoring registers regulator: da9063: implement setter for voltage monitoring dt-bindings: mfd: dlg,da9063: document voltage monitoring .../devicetree/bindings/mfd/dlg,da9063.yaml | 17 ++- drivers/regulator/da9063-regulator.c | 147 +++++++++++++++++---- include/linux/mfd/da9063/registers.h | 23 ++++ 3 files changed, 157 insertions(+), 30 deletions(-) --- base-commit: 7e364e56293bb98cae1b55fd835f5991c4e96e7d change-id: 20230403-da9063-disable-unused-15836e2f4539 Best regards,