| Message ID | 20230309204608.237605-1-martin.kepplinger@puri.sm |
|---|---|
| Headers | show |
| Series | arm64: dts: imx8mq-librem5: updates and fixes until march 2023 | expand |
On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote: > From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> > > This reduces power consumption in system suspend by about 10%. Is there any other impact than this nice power gain? Otherwise, I would wonder why the quirk was enabled in the first place. Shawn > > Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > index 0b4b49fa1392a..f557632f574fa 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > @@ -1322,7 +1322,6 @@ &usb_dwc3_0 { > #address-cells = <1>; > #size-cells = <0>; > dr_mode = "otg"; > - snps,dis_u3_susphy_quirk; > usb-role-switch; > status = "okay"; > > -- > 2.30.2 >
Hi Shawn, On 2023-03-14 00:28, Shawn Guo wrote: > On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote: >> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> >> >> This reduces power consumption in system suspend by about 10%. > > Is there any other impact than this nice power gain? Otherwise, > I would wonder why the quirk was enabled in the first place. > This comes from the early days of board bring-up and IIRC it seemed to stabilize flashing using the mfgtools over USB. Whatever gremlin was in those early boards is long gone and this is no longer needed. Cheers Angus > Shawn > >> >> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> >> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> >> --- >> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi >> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi >> index 0b4b49fa1392a..f557632f574fa 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi >> @@ -1322,7 +1322,6 @@ &usb_dwc3_0 { >> #address-cells = <1>; >> #size-cells = <0>; >> dr_mode = "otg"; >> - snps,dis_u3_susphy_quirk; >> usb-role-switch; >> status = "okay"; >> >> -- >> 2.30.2 >>
hi Shawn and all interested in the Librem 5 phone, This is another round of updates to the phone DT description. Some are clear fixes, but some are important updates like the CSI changes that make the selfie cam work or the powersaving related things like the ddrc opp table entry and voltage changes. As previously this is all mixed together because the changes are small. If you prefer separate, small "topic-patchsets", please say so. thanks, martin Angus Ainslie (1): arm64: dts: imx8mq-librem5: add the magnetometer mount matrix Martin Kepplinger (4): arm64: dts: imx8mq-librem5: lower the mipi csi 1 frequencies arm64: dts: imx8mq-librem5: describe the clock for the csi sensors arm64: dts: imx8mq-librem5: fix audio-1v8 regulator name arm64: dts: imx8mq-librem5: add brightness levels to led-backlight Sebastian Krzyszkowiak (9): arm64: dts: imx8mq-librem5: Describe MIC_2V4 regulator arm64: dts: imx8mq-librem5: Set charger parameters for each batch arm64: dts: imx8mq-librem5: Set the DVS voltages lower arm64: dts: imx8mq-librem5: Bump usdhc2 frequency to 100MHz arm64: dts: imx8mq-librem5: Adjust proximity sensor's near levels arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0 arm64: dts: imx8mq-librem5: Bump BUCK1 suspend voltage to 0.81V arm64: dts: imx8mq-librem5: Reduce I2C frequency to 384kHz arm64: dts: imx8mq-librem5: Add 166MHz to DDRC OPP table .../boot/dts/freescale/imx8mq-librem5-r2.dts | 12 ++-- .../boot/dts/freescale/imx8mq-librem5-r3.dts | 2 +- .../boot/dts/freescale/imx8mq-librem5-r3.dtsi | 10 ++- .../boot/dts/freescale/imx8mq-librem5-r4.dts | 2 +- .../boot/dts/freescale/imx8mq-librem5.dtsi | 70 ++++++++++++++----- 5 files changed, 67 insertions(+), 29 deletions(-)