| Message ID | 20230131223529.11905-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Share RZ/G2L SoC DTSI with RZ/V2L SoC | expand |
Hi Prabhakar, On Tue, Jan 31, 2023 at 11:42 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Use a SoC specific macro for CPG and RESET so that we can re-use the > RZ/G2L SoC DTSI for RZ/V2L SoC by just updating the SoC specific macro. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > v1->v2 > * No change Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > @@ -1,12 +1,16 @@ > // SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > /* > - * Device Tree Source for the RZ/G2L and RZ/G2LC common SoC parts > + * Device Tree Source for the RZ/G2L, RZ/G2LC and RZ/V2L common SoC parts > * > * Copyright (C) 2021 Renesas Electronics Corp. > */ > > #include <dt-bindings/interrupt-controller/arm-gic.h> > + > +#ifndef SOC_CPG_PREFIX > #include <dt-bindings/clock/r9a07g044-cpg.h> > +#define SOC_CPG_PREFIX(X) R9A07G044_ ## X As we're setting a precedent, this might as well be just SOC_PREFIX(X). Some SoCs have multiple sets of definitions. I can make that change myself while/if applying. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > +#endif Gr{oetje,eeting}s, Geert
Hi Rob, Krzysztof, On Tue, Jan 31, 2023 at 11:42 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > This series aims to reuse RZ/G2L SoC DTSI with RZ/V2L as both the SoCs are > almost identical. > > v1 -> v2 > * Patch 1/2 unchanged, for patch 2/2 sorted the nodes based on the names. > > v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/20230127133909.144774-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > Cheers, > Prabhakar > > Lad Prabhakar (2): > arm64: dts: renesas: r9a07g044: Use SoC specific macro for CPG and > RESET > arm64: dts: renesas: r9a07g054: Reuse RZ/G2L SoC DTSI > > arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 254 ++--- > arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 1149 +++----------------- > 2 files changed, 256 insertions(+), 1147 deletions(-) Do you have an opinion on this series? Is this acceptable for you? The final generated DTBs are identical to before. Thanks! Gr{oetje,eeting}s, Geert
Hi Geert, On Fri, Mar 10, 2023 at 10:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Mon, Feb 13, 2023 at 3:16 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Tue, Jan 31, 2023 at 11:42 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > > > This series aims to reuse RZ/G2L SoC DTSI with RZ/V2L as both the SoCs are > > > almost identical. > > > > > > v1 -> v2 > > > * Patch 1/2 unchanged, for patch 2/2 sorted the nodes based on the names. > > > > > > v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/20230127133909.144774-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > > > > > Cheers, > > > Prabhakar > > > > > > Lad Prabhakar (2): > > > arm64: dts: renesas: r9a07g044: Use SoC specific macro for CPG and > > > RESET > > > arm64: dts: renesas: r9a07g054: Reuse RZ/G2L SoC DTSI > > > > > > arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 254 ++--- > > > arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 1149 +++----------------- > > > 2 files changed, 256 insertions(+), 1147 deletions(-) > > > > Do you have an opinion on this series? > > Is this acceptable for you? > > The final generated DTBs are identical to before. > > Given the feedback from Krzysztof and Rob on patch 1, and on IRC, > I'm rejecting this series. > Ok, I'll rebase CRU work by dropping this series. Cheers, Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Hi All, This series aims to reuse RZ/G2L SoC DTSI with RZ/V2L as both the SoCs are almost identical. v1 -> v2 * Patch 1/2 unchanged, for patch 2/2 sorted the nodes based on the names. v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/20230127133909.144774-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Cheers, Prabhakar Lad Prabhakar (2): arm64: dts: renesas: r9a07g044: Use SoC specific macro for CPG and RESET arm64: dts: renesas: r9a07g054: Reuse RZ/G2L SoC DTSI arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 254 ++--- arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 1149 +++----------------- 2 files changed, 256 insertions(+), 1147 deletions(-)