mbox series

[v2,00/12] dt-bindings: serial: cleanup and improvements

Message ID 20230124091602.44027-1-krzysztof.kozlowski@linaro.org
Headers show
Series dt-bindings: serial: cleanup and improvements | expand

Message

Krzysztof Kozlowski Jan. 24, 2023, 9:15 a.m. UTC
Hi,

Changes since v1:
1. Drop "dt-bindings: serial: restrict possible child node names"
   patch from this series, because it requires more discussion.
   I don't know yet how to solve the errors.
2. Add tags.
v1: https://lore.kernel.org/linux-devicetree/20230123151302.368277-1-krzysztof.kozlowski@linaro.org/T/#t

Best regards,
Krzysztof

Krzysztof Kozlowski (12):
  dt-bindings: serial: amlogic,meson-uart: allow other serial properties
  dt-bindings: serial: 8250: correct Nuvoton NPCM850 compatible
  dt-bindings: serial: pl011: allow ARM Primecell properties
  dt-bindings: serial: correct ref to serial.yaml
  dt-bindings: serial: cdsn,uart: add power-domains
  dt-bindings: serial: 8250_omap: drop rs485 properties
  dt-bindings: serial: fsl-imx-uart: drop common properties
  dt-bindings: serial: fsl-lpuart: drop rs485 properties
  dt-bindings: serial: fsl-lpuart: allow other serial properties
  dt-bindings: serial: st,stm32-uart: drop common properties
  dt-bindings: serial: drop unneeded quotes
  dt-bindings: serial: example cleanup

 .../devicetree/bindings/serial/8250.yaml      |  9 ++++---
 .../devicetree/bindings/serial/8250_omap.yaml | 23 +++++++---------
 .../bindings/serial/amlogic,meson-uart.yaml   | 15 ++++++-----
 .../devicetree/bindings/serial/cdns,uart.yaml | 19 +++++++++++---
 .../bindings/serial/fsl,s32-linflexuart.yaml  |  2 +-
 .../bindings/serial/fsl-imx-uart.yaml         | 11 ++------
 .../bindings/serial/fsl-lpuart.yaml           |  6 ++---
 .../bindings/serial/fsl-mxs-auart.yaml        |  2 +-
 .../devicetree/bindings/serial/pl011.yaml     |  1 +
 .../bindings/serial/renesas,em-uart.yaml      | 10 +++----
 .../bindings/serial/renesas,hscif.yaml        | 26 +++++++++----------
 .../bindings/serial/renesas,sci.yaml          | 24 ++++++++---------
 .../bindings/serial/renesas,scif.yaml         | 24 ++++++++---------
 .../bindings/serial/renesas,scifa.yaml        | 22 ++++++++--------
 .../bindings/serial/renesas,scifb.yaml        | 12 ++++-----
 .../devicetree/bindings/serial/serial.yaml    | 18 ++++++-------
 .../bindings/serial/sifive-serial.yaml        |  6 ++---
 .../bindings/serial/st,stm32-uart.yaml        |  7 -----
 .../bindings/serial/xlnx,opb-uartlite.yaml    |  6 ++---
 19 files changed, 120 insertions(+), 123 deletions(-)

Comments

Rob Herring (Arm) Jan. 25, 2023, 8:06 p.m. UTC | #1
On Tue, 24 Jan 2023 10:15:51 +0100, Krzysztof Kozlowski wrote:
> Reference common serial properties bindings to allow typical serial
> properties:
> 
>   meson-axg-jethome-jethub-j100.dtb: serial@23000: 'bluetooth', 'uart-has-rtscts' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> 
> ---
> 
> Changes since v1:
> 1. Add tag
> 2. Use local path (not absolute to /schemas/serial/serial.yaml)
> ---
>  .../devicetree/bindings/serial/amlogic,meson-uart.yaml       | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Rob Herring (Arm) Jan. 25, 2023, 8:06 p.m. UTC | #2
On Tue, 24 Jan 2023 10:19:07 +0100, Krzysztof Kozlowski wrote:
> Reference ARM Primecell bindings to allow typical Primecell device node properties:
> 
>   broadcom/bcm2711-rpi-400.dtb: serial@7e201000: Unevaluated properties are not allowed ('arm,primecell-periphid' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/serial/pl011.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Rob Herring (Arm) Jan. 25, 2023, 8:07 p.m. UTC | #3
On Tue, 24 Jan 2023 10:19:09 +0100, Krzysztof Kozlowski wrote:
> Few Xilinx DTS have power domains in serial node:
> 
>   zynqmp-zc1232-revA.dtb: serial@ff000000: Unevaluated properties are not allowed ('power-domains' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Michal Simek <michal.simek@amd.com>
> ---
>  .../devicetree/bindings/serial/cdns,uart.yaml   | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Rob Herring (Arm) Jan. 25, 2023, 8:08 p.m. UTC | #4
On Tue, 24 Jan 2023 10:19:11 +0100, Krzysztof Kozlowski wrote:
> The binding references serial and rs485 schemas, so there is no need to
> list their properties.  Simplify a bit by removing unneeded entries.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml | 7 -------
>  1 file changed, 7 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Rob Herring (Arm) Jan. 25, 2023, 8:08 p.m. UTC | #5
On Tue, 24 Jan 2023 10:19:13 +0100, Krzysztof Kozlowski wrote:
> Reference common serial properties bindings to allow typical serial
> properties:
> 
>   imx8qxp-ai_ml.dtb: serial@5a060000: Unevaluated properties are not allowed ('uart-has-rtscts' were unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Rob Herring (Arm) Jan. 25, 2023, 8:09 p.m. UTC | #6
On Tue, 24 Jan 2023 10:19:15 +0100, Krzysztof Kozlowski wrote:
> Cleanup by removing unneeded quotes from refs.  No functional impact
> except adjusting to preferred coding style.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/serial/8250.yaml            | 4 ++--
>  .../devicetree/bindings/serial/fsl,s32-linflexuart.yaml       | 2 +-
>  Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml    | 4 ++--
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml      | 2 +-
>  Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml   | 2 +-
>  5 files changed, 7 insertions(+), 7 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>