mbox series

[v2,0/3] drm/tiny: panel-mipi-dbi: Support separate I/O voltage supply

Message ID 20221201160245.2093816-1-otto.pflueger@abscue.de
Headers show
Series drm/tiny: panel-mipi-dbi: Support separate I/O voltage supply | expand

Message

Otto Pflüger Dec. 1, 2022, 4:02 p.m. UTC 
As stated in Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yml,
the MIPI DBI specification defines two power supplies, one for powering
the panel and one for the I/O voltage. The panel-mipi-dbi driver
currently only supports specifying a single "power-supply" in the
device tree.

Add support for a second power supply defined in a new "io-supply"
device tree property to make the driver properly configure the voltage
regulators on platforms where separate supplies are used.

Changes in v2:
 - Don't list power-supply in the properties section of
   panel-mipi-dbi-spi.yaml because it is already in panel-common.yaml

Otto Pflüger (3):
  drm/mipi-dbi: Support separate I/O regulator
  drm/tiny: panel-mipi-dbi: Read I/O supply from DT
  dt-bindings: display: panel: mipi-dbi-spi: Add io-supply

 .../bindings/display/panel/panel-mipi-dbi-spi.yaml |  8 +++++++-
 drivers/gpu/drm/drm_mipi_dbi.c                     | 14 ++++++++++++++
 drivers/gpu/drm/tiny/panel-mipi-dbi.c              |  5 +++++
 include/drm/drm_mipi_dbi.h                         |  7 ++++++-
 4 files changed, 32 insertions(+), 2 deletions(-)

Comments

Noralf Trønnes Dec. 3, 2022, 4:19 p.m. UTC | #1 
Den 01.12.2022 17.02, skrev Otto Pflüger:
> The MIPI DBI specification defines separate vdd (panel power) and
> vddi (I/O voltage) supplies. Displays that require different voltages
> for the different supplies do exist, so the supplies cannot be
> combined into one as they are now. Add a new io_regulator property to
> the mipi_dbi_dev struct which can be set by the panel driver along
> with the regulator property.
> 
> Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
> ---

Thanks for fixing this, I'll apply the patches in a few days.

Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Noralf Trønnes Dec. 3, 2022, 4:21 p.m. UTC | #2 
Den 01.12.2022 17.02, skrev Otto Pflüger:
> Add documentation for the new io-supply property, which specifies the
> regulator for the I/O voltage supply on platforms where the panel
> panel power and I/O supplies are separate.
> 
> Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
> ---

Reviewed-by: Noralf Trønnes <noralf@tronnes.org>