| Message ID | 20221125202008.64595-1-samuel@sholland.org |
|---|---|
| Headers | show |
| Series | dt-bindings: net: sunxi: Fix binding validation issues | expand |
On Fri, 25 Nov 2022 14:20:08 -0600 Samuel Holland <samuel@sholland.org> wrote: > This property has always been supported by the Linux driver; see > commit 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i"). In fact, the > original driver submission includes the phy-supply code but no mention > of it in the binding, so the omission appears to be accidental. In > addition, the property is documented in the binding for the previous > hardware generation, allwinner,sun7i-a20-gmac. > > Document phy-supply in the binding to fix devicetree validation for the > 25+ boards that already use this property. > > Fixes: 0441bde003be ("dt-bindings: net-next: Add DT bindings documentation for Allwinner dwmac-sun8i") > Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > index 34a47922296d..4f671478b288 100644 > --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > @@ -42,6 +42,9 @@ properties: > clock-names: > const: stmmaceth > > + phy-supply: > + description: PHY regulator > + > syscon: > $ref: /schemas/types.yaml#/definitions/phandle > description:
On Fri, 25 Nov 2022 14:20:08 -0600, Samuel Holland wrote: > This property has always been supported by the Linux driver; see > commit 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i"). In fact, the > original driver submission includes the phy-supply code but no mention > of it in the binding, so the omission appears to be accidental. In > addition, the property is documented in the binding for the previous > hardware generation, allwinner,sun7i-a20-gmac. > > Document phy-supply in the binding to fix devicetree validation for the > 25+ boards that already use this property. > > Fixes: 0441bde003be ("dt-bindings: net-next: Add DT bindings documentation for Allwinner dwmac-sun8i") > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
These patches fix issues found when running `make dtbs_check` on sunxi boards. I am not 100% sure about the change in the first two patches, but I think I understand what is happening, and the change has the desired effect. It fixes errors of the form: arch/arm/boot/dts/sun6i-a31s-colorfly-e708-q1.dtb: ethernet@1c30000: Unevaluated properties are not allowed ('mdio', 'reset-names', 'resets', 'snps,fixed-burst', 'snps,force_sf_dma_mode', 'snps,pbl' were unexpected) where all of the listed properties are defined in snps,dwmac.yaml. The third patch fixes an unrelated omission in the sun8i-emac binding. Samuel Holland (3): dt-bindings: net: sun7i-gmac: Fix snps,dwmac.yaml inheritance dt-bindings: net: sun8i-emac: Fix snps,dwmac.yaml inheritance dt-bindings: net: sun8i-emac: Add phy-supply property .../devicetree/bindings/net/allwinner,sun7i-a20-gmac.yaml | 5 ++--- .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 6 +++++- 2 files changed, 7 insertions(+), 4 deletions(-)