[v1,0/2] soc: add NPCM LPC BPC driver support

This patch set adds LPC BIOS Post code (BPC) support for the
Nuvoton NPCM Baseboard Management Controller (BMC).

Nuvoton BMC NPCM LPC BIOS Post Code (BPC) monitoring two
configurable I/O addresses written by the host on the
Low Pin Count (LPC) bus, the capture data stored in 128-word FIFO.

NPCM BPC can support capture double words.

The NPCM LPC BPC driver tested on NPCM750 Olympus board and NPCM845 EVB.

Tomer Maimon (2):
  dt-binding: soc: nuvoton: Add NPCM BPC LPC documentation
  soc: nuvoton: add NPCM LPC BPC driver

 .../bindings/soc/nuvoton/npcm-lpc-bpc.yaml    | 112 +++++
 drivers/soc/Kconfig                           |   1 +
 drivers/soc/Makefile                          |   1 +
 drivers/soc/nuvoton/Kconfig                   |  24 ++
 drivers/soc/nuvoton/Makefile                  |   3 +
 drivers/soc/nuvoton/npcm-lpc-bpc.c            | 396 ++++++++++++++++++
 6 files changed, 537 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/nuvoton/npcm-lpc-bpc.yaml
 create mode 100644 drivers/soc/nuvoton/Kconfig
 create mode 100644 drivers/soc/nuvoton/Makefile
 create mode 100644 drivers/soc/nuvoton/npcm-lpc-bpc.c

hi Krzysztof,

Thanks for your comments.

On Thu, 24 Nov 2022 at 18:18, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 24/11/2022 16:38, Tomer Maimon wrote:
> > Hi Krzysztof,
> >
> > Thanks a lot for your comments.
> >
> > On Wed, 23 Nov 2022 at 12:03, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 22/11/2022 21:12, Tomer Maimon wrote:
> >>
> >> 1. Subject: drop second, redundant "documentation" (dt-bindings are
> >> documentation).
> > O.K.
> >>
> >> 2. Use subject prefixes matching the subsystem (git log --oneline -- ...).
> > this is what I did dt-binding: soc: nuvoton... do you mean dt-binding: nuvoton.
>
> You didn't run the command, did you?
I did run this command "git log --oneline
Documentation/devicetree/bindings/soc" and I got this log list
e47206d71e67 dt-binding: soc: nuvoton: Add NPCM BPC LPC documentation
121494030c53 dt-bindings: soc: add i.MX93 mediamix blk ctrl
4fed4d20c59b dt-bindings: soc: add i.MX93 SRC
c7ebd54158d3 dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
2345fc8dc2ec dt-bindings: soc: imx: add interconnect property for
i.MX8MM vpu blk ctrl
c1d9381ce430 dt-bindings: soc: imx: drop minItems for i.MX8MM vpu blk ctrl
f3894f969cf5 dt-bindings: soc: mediatek: Add display mutex support for MT6795
b2d7616e13c4 dt-bindings: soc: qcom: apr: add missing properties
301628d80501 ASoC: dt-bindings: qcom,q6adm: convert to dtschema
7b0ad4629d1f ASoC: dt-bindings: qcom,q6asm: convert to dtschema
b2496de1dfdd dt-bindings: soc: qcom: apr: correct service children

most of the subjects are similar to what I did, if it is not correct
please let me know exactly what to write (beside the word
documentation that I will remove)

>
> >>
> >>> Added device tree binding documentation for Nuvoton BMC NPCM BIOS Post
> >>> Code (BPC).
> >>>
>
>
> (...)
>
>
> >>
> >> No, only bus schemas could have it. Here additionalProperties: false.
> >>
> >> It seems there are already few LPC controllers and all are put in
> >> different places:
> >> Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
> >> Documentation/devicetree/bindings/arm/hisilicon/low-pin-count.yaml
> >>
> >> Maybe Rob why this was made not really as two bindings - for bus
> >> controller and devices?
> > As mention above, next patch I will describe only the BPC device.
> >>
> >> Best regards,
> >> Krzysztof
> >>
> >
> > In general, I waiting for Arnd approval for adding the NPCM BPC driver to SoC.
> > After Arnd approval, I will send a new patch revision.
>
>
> To be clear - bindings must be accepted (Reviewed or Acked) before
> driver is.
>
> Best regards,
> Krzysztof
>

Best regards,

Tomer