mbox series

[v7,0/4] Add devicetree support for max6639

Message ID 20221121122932.2493174-1-Naresh.Solanki@9elements.com
Headers show
Series Add devicetree support for max6639 | expand

Message

Naresh Solanki Nov. 21, 2022, 12:29 p.m. UTC 
These patches adds devicetree support for MAX6639.

Changes in V7:
- Split the patch into
 1. add dt support for max6639
 2. Add pwm support
- Ad DT property min-rpm in fan-common.yaml
Changes in V6:
- Remove unused header file
- minor cleanup 
Changes in V5:
- Add pwms support
Changes V4:
- Fix dt error
- update comment
Changes V3:
- correct fan dt property name
- remove unrelevent changes
Changes V2:
- Fix dt schema error.
Changes:
- Add fan-common dt schema.
- add dt-binding support for max6639
- add max6639 specific property

Marcello Sylvester Bauer (1):
  dt-bindings: hwmon: Add binding for max6639

Naresh Solanki (3):
  dt-bindings: hwmon: fan: Add fan binding to schema
  hwmon: (max6639) Change from pdata to dt configuration
  hwmon: (max6639) Add pwm support

 .../devicetree/bindings/hwmon/fan-common.yaml |  47 ++
 .../bindings/hwmon/maxim,max6639.yaml         |  93 ++++
 drivers/hwmon/Kconfig                         |   1 +
 drivers/hwmon/max6639.c                       | 460 +++++++++++++++---
 include/linux/platform_data/max6639.h         |  15 -
 5 files changed, 527 insertions(+), 89 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
 create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
 delete mode 100644 include/linux/platform_data/max6639.h


base-commit: 27fea302952d8c90cafbdbee96bafeca03544401

Comments

Naresh Solanki Nov. 29, 2022, 4:03 p.m. UTC | #1 
On 29-11-2022 09:27 pm, Krzysztof Kozlowski wrote:
> On 29/11/2022 16:46, Naresh Solanki wrote:
>> Hi Krzysztof,
>>
>> On 29-11-2022 01:42 pm, Krzysztof Kozlowski wrote:
>>> On 21/11/2022 13:29, Naresh Solanki wrote:
>>>
>>>> +  pulses-per-revolution:
>>>> +    description:
>>>> +      The number of pulse from fan sensor per revolution.
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +
>>>> +  target-rpm:
>>>> +    description:
>>>> +      Target RPM the fan should be configured during driver probe.
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +
>>>> +  pwms:
>>>> +    description:
>>>> +      PWM provider.
>>>
>>> Ah, so it is not a PWM provider by this FAN controller? A bit confusing
>>> description. Instead maybe:
>>> 	PWM signal for the fan
>> Sure.
>>>
>>> and do you expect more than one PWM for one fan?
>> One pwm per fan
> 
> then:
>    maxItems: 1
> 
Sure
> Best regards,
> Krzysztof
> 
Regards,
Naresh