| Message ID | 20221118133216.17037-1-walker.chen@starfivetech.com |
|---|---|
| Headers | show |
| Series | JH7110 Power Domain Support | expand |
On 18/11/2022 14:32, Walker Chen wrote: > Add bindings for the power domain controller on the StarFive JH71XX SoC. > Subject: drop second, redundant "bindings". > Signed-off-by: Walker Chen <walker.chen@starfivetech.com> > --- > .../bindings/power/starfive,jh71xx-power.yaml | 46 +++++++++++++++++++ 1st patch should be squashed here. Headers are part of bindings file. > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml > > diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml > new file mode 100644 > index 000000000000..2537303b4829 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml Filename like compatible. > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/starfive,jh71xx-power.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH71xx Power Domains Controller > + > +maintainers: > + - Walker Chen <walker.chen@starfivetech.com> > + > +description: | > + StarFive JH71xx SoCs include support for multiple power domains which can be > + powered on/off by software based on different application scenes to save power. > + > +properties: > + compatible: > + items: No items. You have just one item, > + - enum: > + - starfive,jh7110-pmu > + Best regards, Krzysztof
On 2022/11/21 18:12, Krzysztof Kozlowski wrote: > On 18/11/2022 14:32, Walker Chen wrote: >> Add power domain definitions for the StarFive JH7110 SoC. >> >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >> --- >> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 include/dt-bindings/power/jh7110-power.h >> >> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >> new file mode 100644 >> index 000000000000..24160c46fbaf >> --- /dev/null >> +++ b/include/dt-bindings/power/jh7110-power.h > > Filename matching compatible or bindings file. So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver should also be changed to "starfive,jh7110-power". Is it right ? > >> @@ -0,0 +1,18 @@ >> +/* SPDX-License-Identifier: (GPL-2.0) */ > > Dual license for bindings. Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. > >> +/* >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. >> + * Author: Walker Chen <walker.chen@starfivetech.com> >> + */ >> +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ >> +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ > > Best regards, > Krzysztof >
On 22/11/2022 08:46, Walker Chen wrote: > On 2022/11/21 18:12, Krzysztof Kozlowski wrote: >> On 18/11/2022 14:32, Walker Chen wrote: >>> Add power domain definitions for the StarFive JH7110 SoC. >>> >>> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >>> --- >>> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> create mode 100644 include/dt-bindings/power/jh7110-power.h >>> >>> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >>> new file mode 100644 >>> index 000000000000..24160c46fbaf >>> --- /dev/null >>> +++ b/include/dt-bindings/power/jh7110-power.h >> >> Filename matching compatible or bindings file. > > So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver > should also be changed to "starfive,jh7110-power". Is it right ? I said filename should be changed. I don't remember what was your compatible, but if I did not comment there, in means it looked fine. > >> >>> @@ -0,0 +1,18 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0) */ >> >> Dual license for bindings. > > Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. Any reasons why not using the licenses recommended by checkpatch? Best regards, Krzysztof
On 2022/11/22 16:03, Krzysztof Kozlowski wrote: > On 22/11/2022 08:46, Walker Chen wrote: >> On 2022/11/21 18:12, Krzysztof Kozlowski wrote: >>> On 18/11/2022 14:32, Walker Chen wrote: >>>> Add power domain definitions for the StarFive JH7110 SoC. >>>> >>>> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >>>> --- >>>> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >>>> 1 file changed, 18 insertions(+) >>>> create mode 100644 include/dt-bindings/power/jh7110-power.h >>>> >>>> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >>>> new file mode 100644 >>>> index 000000000000..24160c46fbaf >>>> --- /dev/null >>>> +++ b/include/dt-bindings/power/jh7110-power.h >>> >>> Filename matching compatible or bindings file. >> >> So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver >> should also be changed to "starfive,jh7110-power". Is it right ? > > I said filename should be changed. I don't remember what was your > compatible, but if I did not comment there, in means it looked fine. > >> >>> >>>> @@ -0,0 +1,18 @@ >>>> +/* SPDX-License-Identifier: (GPL-2.0) */ >>> >>> Dual license for bindings. >> >> Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. > > Any reasons why not using the licenses recommended by checkpatch? > Well, it sounds like a better way to decide which license to use by checkpatch. Thanks for your tip. Best Regards, Walker Chen
On Tue, Nov 22, 2022 at 09:22:03PM +0800, Walker Chen wrote: > On 2022/11/21 18:13, Krzysztof Kozlowski wrote: > > On 18/11/2022 14:32, Walker Chen wrote: > >> Add bindings for the power domain controller on the StarFive JH71XX SoC. > >> > > > > Subject: drop second, redundant "bindings". > > Will fix. > > > > >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> > >> --- > >> .../bindings/power/starfive,jh71xx-power.yaml | 46 +++++++++++++++++++ > > > > 1st patch should be squashed here. Headers are part of bindings file. > > Will be done in the next version of patch. > > > > >> 1 file changed, 46 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml > >> new file mode 100644 > >> index 000000000000..2537303b4829 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml > > > > Filename like compatible. > > As mentioned in the previous email, the compatible in the driver should be changed to "starfive,jh7110-power". Is the h/w block called 'power' or 'pmu'? Call it what the h/w is called. Rob
On 2022/11/30 23:24, Rob Herring wrote: > On Tue, Nov 22, 2022 at 09:22:03PM +0800, Walker Chen wrote: >> On 2022/11/21 18:13, Krzysztof Kozlowski wrote: >> > On 18/11/2022 14:32, Walker Chen wrote: >> >> Add bindings for the power domain controller on the StarFive JH71XX SoC. >> >> >> > >> > Subject: drop second, redundant "bindings". >> >> Will fix. >> >> > >> >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >> >> --- >> >> .../bindings/power/starfive,jh71xx-power.yaml | 46 +++++++++++++++++++ >> > >> > 1st patch should be squashed here. Headers are part of bindings file. >> >> Will be done in the next version of patch. >> >> > >> >> 1 file changed, 46 insertions(+) >> >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> >> >> >> diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> >> new file mode 100644 >> >> index 000000000000..2537303b4829 >> >> --- /dev/null >> >> +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> > >> > Filename like compatible. >> >> As mentioned in the previous email, the compatible in the driver should be changed to "starfive,jh7110-power". > > Is the h/w block called 'power' or 'pmu'? Call it what the h/w is > called. h/w block is called PMU, is the abbreviation of Power Management Unit. It is more appropriate to change the compatile to 'starfive,jh7110-pmu'. Best Regards, Walker Chen