From patchwork Fri Nov 11 16:18:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 624015 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F75C433FE for ; Fri, 11 Nov 2022 16:18:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233015AbiKKQSO (ORCPT ); Fri, 11 Nov 2022 11:18:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232841AbiKKQSO (ORCPT ); Fri, 11 Nov 2022 11:18:14 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C053865E57; Fri, 11 Nov 2022 08:18:12 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id z14so7068156wrn.7; Fri, 11 Nov 2022 08:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ekBaJphyqfmOYkytyrR3z1wogeXER5E+SCF5H0rXjtI=; b=TbEzvWNDq7YvXvBvGpFQPOG7x8z9bpqnVDb5936JHGIWYmtbx8AdbCwbHKlaqAylpy RbQAqXNASJE2JT76nlngJsXZIzOQy8rjttLJXVfcAlU6EbdpKYF7aVucyVu1EUS610EX Qm9G7Lo7576Uzn9zRJ3gDXqTRZnHaDiWbCC57HvlJxnnwasjfZgGXl4QY6RDyeh6lDDm odN79gkC1XexHDnWCT059yCqgHsnD8o003HlgezN2cXARbGXbeHjiMLUcrVoIYLSPXPj yAT/bG3KcW829rKbJrLkA3O9Idgpji055MPijDF/lc3cMLseXE48JkNrn2ao/nbHUebi xk6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ekBaJphyqfmOYkytyrR3z1wogeXER5E+SCF5H0rXjtI=; b=BKby/jYCGuLKdTaMBwfQL6e0yBz5qMqhMYjHuK1Pczqf/deqY3w3wQhT5aeE9pkcBW /953hiRBSv91ABbVBv0kLLew3oTFuHsAjdaHG83hUuAvvRK8I+1XMno+gv+s8gHv6k9j 76R0ZOw6aAB35c+Lkc14+5S/ATLc3+s4L/nb1UIdLwy2gGTGhzGioTfAPlhzGO8aUTKw 6GA9rnnMAR0VIAgo2CfB6gukgWSplveu7X6wVFNwFN2G9O2yxWEuz8APK3clzTpvyzQ+ zJ1j5zmf78kl1J9Jk5yWFfMMqWc+oOjS0PV5z/7dL+xoAUHzmrJqCTaUUFKED/12RCFe 1mAg== X-Gm-Message-State: ANoB5pmgwyMRleznzFIyLVP/pM3Y5Wp4F7Feq6GTS4DCelxgmuTnG1ea w3LdoZsQaLMs+CjN7KegSKk= X-Google-Smtp-Source: AA0mqf4MFQD8mRau9KVl7w6CUOifOCeWfzO7+r7u17yFoZi3DwpKM5KMzzdzYXXu8hWApMpLxrzkwQ== X-Received: by 2002:a5d:458c:0:b0:236:7005:7e4f with SMTP id p12-20020a5d458c000000b0023670057e4fmr1810831wrq.337.1668183491250; Fri, 11 Nov 2022 08:18:11 -0800 (PST) Received: from localhost (p200300e41f201d00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f20:1d00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id f20-20020a05600c155400b003c6f3e5ba42sm10971340wmg.46.2022.11.11.08.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 08:18:10 -0800 (PST) From: Thierry Reding To: Rob Herring , Joerg Roedel Cc: Will Deacon , Robin Murphy , Nicolin Chen , Krishna Reddy , Ashish Mhetre , Dmitry Osipenko , Alyssa Rosenzweig , Janne Grunau , Sameer Pujar , Lucas Stach , devicetree@vger.kernel.org, iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, asahi@lists.linux.dev Subject: [PATCH v11 0/5] iommu: Support mappings/reservations in reserved-memory regions Date: Fri, 11 Nov 2022 17:18:01 +0100 Message-Id: <20221111161806.630527-1-thierry.reding@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Thierry Reding Hi, This version has several fixes over the previous v10, which can be found here: https://lore.kernel.org/all/20221103133900.1473855-1-thierry.reding@gmail.com/ Most notably this introduces a better mechanism to deal with DMA address translation issues caused by a mismatch of #address-cells in child and DMA parent nodes. This now introduces #dma-address-cells and #dma-size- cells, which can be used to override #address-cells and #size-cells and define a DMA bus that can be wider than the control bus. An example is included in the DT bindings, but here is an extract of what I've used to test this: reserved-memory { #address-cells = <2>; #size-cells = <2>; ranges; /* * Creates an identity mapping for the framebuffer that * the firmware has setup to scan out a bootsplash from. */ fb: framebuffer@92cb2000 { reg = <0x0 0x92cb2000 0x0 0x00800000>; iommu-addresses = <&dc0 0x0 0x92cb2000 0x0 0x00800000>; }; /* * Creates a reservation in the IOVA space to prevent * any buffers from being mapped to that region. Note * that on Tegra the range is actually quite different * from this, but it would conflict with the display * driver that I tested this against, so this is just * a dummy region for testing. */ adsp: reservation-adsp { iommu-addresses = <&dc0 0x0 0x90000000 0x0 0x00010000>; }; }; host1x@50000000 { dc@54200000 { memory-region = <&fb>, <&adsp>; }; }; This is abbreviated a little to focus on the essentials. Note also that the ADSP reservation is not actually used on this device and the driver for this doesn't exist yet, but I wanted to include this variant for testing, because we'll want to use these bindings for the reservation use-case as well at some point. I've also been able to make use of this binding and the IOMMU code in conjunction with the simple-framebuffer driver to hand over a display configuration set up by UEFI to the Linux kernel. Janne has confirmed[0] this to be suitable for indirect mappings as well, though these patches don't implement that feature yet. Potential extensions to this have been discussed but are not yet included at this time to not further complicate things. Thierry [0]: https://lore.kernel.org/all/20220909144504.GA4024@jannau.net/ Thierry Reding (5): of: Introduce support for #dma-{address,size}-cells of: Introduce of_translate_dma_region() dt-bindings: reserved-memory: Document iommu-addresses iommu: Implement of_iommu_get_resv_regions() iommu: dma: Use of_iommu_get_resv_regions() .../reserved-memory/reserved-memory.yaml | 73 ++++++++++++++ drivers/iommu/dma-iommu.c | 3 + drivers/iommu/of_iommu.c | 94 +++++++++++++++++++ drivers/of/address.c | 84 +++++++++++++---- drivers/of/base.c | 70 +++++++++++--- drivers/of/of_private.h | 14 ++- include/linux/of.h | 17 +++- include/linux/of_address.h | 4 +- include/linux/of_iommu.h | 8 ++ 9 files changed, 329 insertions(+), 38 deletions(-)